New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 716658 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

[About] Design fix-it (non-cros)

Project Member Reported by bettes@chromium.org, Apr 28 2017

Issue description

Chrome://chrome is one of our most visited webUI, so I'd like to clean it up as soon as possible

1. Update the text logo to image logos

Channel logos and chromium included below:
https://drive.google.com/open?id=0BxMIIGI80eU-WG5razhhbVB1Mkk

2. Update the padding in the top two rows. The padding around the up-to-date checkmark is different to align with new logo.

*** Spec below is measured at 2x so divide numbers in half. Sorry :/ ***

https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/notes/about#%3Fz=width&f=hidden

3. Place copyright text in it's own card to separate it from the primary UI


 



 
about_chrome.png
106 KB View Download

Comment 1 by dpa...@chromium.org, Apr 28 2017

Cc: steve...@chromium.org dbeam@chromium.org
1. Logos changes are being tracked by issue 619120 (currently assigned to Steven). Per my previous investigation (see linked bug), the change seems fairly involved, and therefore I think it is unlikely to be able to merge such a change to M59.

I'll take a look at 2 and 3.
Labels: M60
Labels: -M60 M-60
Labels: -Hotlist-Settings-AboutCrOS Hotlist-MD-Settings-AboutCrOS
Project Member

Comment 5 by bugdroid1@chromium.org, May 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7cf21a287bc149f34de83c2bb57b61e6d206fa6b

commit 7cf21a287bc149f34de83c2bb57b61e6d206fa6b
Author: dpapad <dpapad@chromium.org>
Date: Tue May 16 19:31:55 2017

MD Settings: About page, move copyright text in it's own card.

BUG=716658,716656
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2888493002
Cr-Commit-Position: refs/heads/master@{#472184}

[modify] https://crrev.com/7cf21a287bc149f34de83c2bb57b61e6d206fa6b/chrome/browser/resources/settings/about_page/about_page.html

Cc: jmukthavaram@chromium.org
Labels: Needs-Feedback
Tested this issue on Windows 7 & Mac 10.12.4 using chrome #60.0.3107.4 as per comment#0.
Observations:
------------
1.Observed chaneel logos (Dev,beta,stable) logos displayed on chrome://settings/help (About Chrome page) which is working as intended. 

2. No padding issue observed on top two rows & the padding around the up-to-date checkmark alignment is proper with new logo.

3.'Copyright text' separate card is displayed on chrome://settings/help (About Chrome page) which is working as intended.

dpapad@,Could you please confirm the fix on step 2 & expected behavior for the same.

Please find the attached screencast for reference.
Thanks..11

 
716658.mp4
1.2 MB View Download

Comment 7 by bettes@chromium.org, Jun 16 2017

Spacing between cards isn't to spec. Expected is 16px. See my comment in #1

>> *** Spec below is measured at 2x so divide numbers in half. Sorry :/ ***

Comment 8 by dpa...@chromium.org, Oct 24 2017

Owner: ----
Status: Available (was: Assigned)
Marking bugs (mostly lower priority ones) that I am unlikely to get to soon as Available.
Owner: scottchen@chromium.org
Status: Started (was: Available)
Labels: -Hotlist-MD-Settings-AboutCrOS Hotlist-MD-Settings-About
Updating to the correct hotlist, but note, we have a lot of CrOS specific issues with this UI also (Hotlist-MD-Settings-AboutCrOS), it would be good to coordinate any efforts.

Cc: tbuck...@chromium.org
Cc: scottchen@chromium.org
Owner: ----
Status: Available (was: Started)
Just want to clarify, I was originally working on making multi-card sections possible, got kind of close but was fighting with animation a lot and since this was low-pri we shelved it.

FWIW the CL in progress is here: https://chromium-review.googlesource.com/c/chromium/src/+/882013

Sign in to add a comment