New issue
Advanced search Search tips

Issue 716649 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Oct 31
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task

Blocking:
issue 688908



Sign in to add a comment

Remove usage of -webkit-user-modify from DevTools

Project Member Reported by xiaoche...@chromium.org, Apr 28 2017

Issue description

We should remove any internal usage of -webkit-user-modify to unblock the deprecation of this non-standard property.
 
Used in:
- WebKit/Source/devtools/front_end/ui/filter.css
- WebKit/Source/devtools/front_end/sdk/CSSMetadata.js
- WebKit/Source/devtools/front_end/ui/textPrompt.css
- WebKit/Source/devtools/front_end/ui/inspectorCommon.css
- WebKit/Source/devtools/front_end/sources/sourcesView.css
- WebKit/Source/devtools/front_end/elements/elementsPanel.css
- WebKit/Source/devtools/front_end/resources/resourcesPanel.css
- WebKit/Source/devtools/front_end/elements/elementsTreeOutline.css
Blocking: 688908

Comment 3 by allada@chromium.org, Apr 28 2017

Owner: einbinder@chromium.org
Status: Assigned (was: Untriaged)
Joel can you please adjust our list?
Right now we use this to force plaintext-only mode. It looks like the alternative is contenteditable="contenteditable", which is also deprecated. I'll try to do something based on measuring characters in a textarea.
#4: Please use contenteditable="plaintext-only"

Editing-tf has agreed to standardize it: https://lists.w3.org/Archives/Public/public-editing-tf/2017Mar/0004.html

While the spec says it's deprecated, it hasn't been updated for a while...

Thanks!
Ah, I made a typo. Thats what I meant. Ok that is easy enough.
Project Member

Comment 7 by bugdroid1@chromium.org, May 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/adda99ec72497e2d3c7ca09f8ab68413a283a966

commit adda99ec72497e2d3c7ca09f8ab68413a283a966
Author: einbinder <einbinder@chromium.org>
Date: Thu May 04 02:39:07 2017

DevTools: Migrate from -webkit-user-modify to contenteditable

BUG= 716649 

Review-Url: https://codereview.chromium.org/2859623002
Cr-Commit-Position: refs/heads/master@{#469249}

[modify] https://crrev.com/adda99ec72497e2d3c7ca09f8ab68413a283a966/third_party/WebKit/Source/devtools/front_end/elements/elementsPanel.css
[modify] https://crrev.com/adda99ec72497e2d3c7ca09f8ab68413a283a966/third_party/WebKit/Source/devtools/front_end/elements/elementsTreeOutline.css
[modify] https://crrev.com/adda99ec72497e2d3c7ca09f8ab68413a283a966/third_party/WebKit/Source/devtools/front_end/resources/resourcesPanel.css
[modify] https://crrev.com/adda99ec72497e2d3c7ca09f8ab68413a283a966/third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js
[modify] https://crrev.com/adda99ec72497e2d3c7ca09f8ab68413a283a966/third_party/WebKit/Source/devtools/front_end/sources/sourcesView.css
[modify] https://crrev.com/adda99ec72497e2d3c7ca09f8ab68413a283a966/third_party/WebKit/Source/devtools/front_end/ui/InplaceEditor.js
[modify] https://crrev.com/adda99ec72497e2d3c7ca09f8ab68413a283a966/third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js
[modify] https://crrev.com/adda99ec72497e2d3c7ca09f8ab68413a283a966/third_party/WebKit/Source/devtools/front_end/ui/filter.css
[modify] https://crrev.com/adda99ec72497e2d3c7ca09f8ab68413a283a966/third_party/WebKit/Source/devtools/front_end/ui/inspectorCommon.css
[modify] https://crrev.com/adda99ec72497e2d3c7ca09f8ab68413a283a966/third_party/WebKit/Source/devtools/front_end/ui/textPrompt.css

I guess this is done now?
Status: Archived (was: Assigned)
Bulk closing low-priority issues with no activity. Please re-file and refer to the closed issue if it's essential to fix.

Sign in to add a comment