New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 716647 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android , Windows
Pri: 3
Type: Bug
Proj-XR


Participants' hotlists:
VR-Automated-Tests


Sign in to add a comment

Add test to ensure rAF continues to fire during WebVR presentation to external display only (& rIC behavior)

Project Member Reported by ddorwin@chromium.org, Apr 28 2017

Issue description

 Issue 704341  and issue 712865 track regressions where Chrome stopped firing window.requestAnimationFrame and window.requestIdleCallback while WebVR is presenting on Android.

We should add a test to ensure these continue to fire at the expected rate (whatever that is - but non-zero) when presenting. (We may also want to check for other behaviors during presentation, though I don't know what those might be.) The test should run on all platforms.
 
This should be pretty easy to do with layout tests, which will handle the "on all platforms" part.
As noted in  issue 718246 , the behavior of requestAnimationFrame should depend on whether the page is visible. That means this test should check that it is not fired on Android and is on desktop.

We might be able to use a page visibility API in the layout tests (and we should include this in a WPT), but we may also want a content browser test where we can set platform-specific expectations.
Owner: bsheedy@chromium.org
Status: Started (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2955fd67d0776eb1cd58c54d843321220151a10f

commit 2955fd67d0776eb1cd58c54d843321220151a10f
Author: bsheedy <bsheedy@chromium.org>
Date: Mon Dec 11 19:39:27 2017

Add VR window.rAF test

Adds a test to ensure that WebVR presentation on Android causes
window.requestAnimationFrame to stop firing, but resumes once
presentation is finished.

Bug:  716647 
Change-Id: I1569ba8813fbb74ffdfa0a741b0e5889069ee24f
Reviewed-on: https://chromium-review.googlesource.com/818204
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523174}
[modify] https://crrev.com/2955fd67d0776eb1cd58c54d843321220151a10f/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrTransitionTest.java
[add] https://crrev.com/2955fd67d0776eb1cd58c54d843321220151a10f/chrome/test/data/android/webvr_instrumentation/html/test_window_raf_stops_firing_while_presenting.html

Summary: Add test to ensure rAF & rIC continue to fire during WebVR presentation to external display (was: Add test to ensure requestAnimationFrame & requestIdleCallback continue to fire during WebVR presentation)
Labels: OS-Windows
Labels: OS-Android
Summary: Add test to ensure rAF continues to fire during WebVR presentation to external display only (& rIC behavior) (was: Add test to ensure rAF & rIC continue to fire during WebVR presentation to external display)
I'm not sure we settled on rIC because only Chrome implements it IIRC. We may want to file a separate bug for that.
Status: Fixed (was: Started)
A test for this on desktop was added in https://chromium-review.googlesource.com/c/chromium/src/+/834760
Labels: Test-Complete M-65
Components: Blink>WebXR

Sign in to add a comment