New issue
Advanced search Search tips

Issue 716636 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Do not fill in a capability dictionary entry if it's an empty array

Project Member Reported by mcasas@chromium.org, Apr 28 2017

Issue description

To avoid having a dictionary entry which is an empty array,
see attachment:

 
Screenshot from 2017-04-28 15:21:22.png
16.6 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b6da435540cdb1774a04fcf9a45c98158caf299c

commit b6da435540cdb1774a04fcf9a45c98158caf299c
Author: mcasas <mcasas@chromium.org>
Date: Sat Apr 29 01:33:46 2017

Image Capture: two small nits

Android Auto Exposure is always available, make the implementation
reflect that.

In blink, don't fill dictionary entries with empty arrays.

BUG= 716636 

Review-Url: https://codereview.chromium.org/2842103002
Cr-Commit-Position: refs/heads/master@{#468205}

[modify] https://crrev.com/b6da435540cdb1774a04fcf9a45c98158caf299c/media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java
[modify] https://crrev.com/b6da435540cdb1774a04fcf9a45c98158caf299c/third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp

Comment 2 by mcasas@chromium.org, Apr 29 2017

Labels: Merge-Request-59
Status: Fixed (was: Started)
Project Member

Comment 3 by sheriffbot@chromium.org, Apr 30 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 30 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d3e4e78a1a67585d69fe8e8f182aa2c0c713771

commit 7d3e4e78a1a67585d69fe8e8f182aa2c0c713771
Author: Miguel Casas-Sanchez <mcasas@chromium.org>
Date: Sun Apr 30 20:33:13 2017

Image Capture: two small nits

Android Auto Exposure is always available, make the implementation
reflect that.

In blink, don't fill dictionary entries with empty arrays.

BUG= 716636 

Review-Url: https://codereview.chromium.org/2842103002
Cr-Commit-Position: refs/heads/master@{#468205}
(cherry picked from commit b6da435540cdb1774a04fcf9a45c98158caf299c)

Review-Url: https://codereview.chromium.org/2851973002 .
Cr-Commit-Position: refs/branch-heads/3071@{#311}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/7d3e4e78a1a67585d69fe8e8f182aa2c0c713771/media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java
[modify] https://crrev.com/7d3e4e78a1a67585d69fe8e8f182aa2c0c713771/third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp

Comment 5 by mcasas@chromium.org, Apr 30 2017

Cc: fbeaufort@chromium.org
Labels: M-59
Status: Verified (was: Fixed)
Verified in Chrome Canary 60.0.3088.0.

Sign in to add a comment