New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 716635 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 26
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug


Show other hotlists

Hotlists containing this issue:
ExternalMedia-Mounting


Sign in to add a comment

NOTREACHED() in storage_monitor_chromeos.cc::OnMountEvent()

Reported by teguhhof...@gmail.com, Apr 28 2017

Issue description

[1028:1028:0425/235806.777587:ERROR:storage_monitor_chromeos.cc(166)] NOTREACHED() hit.  [Reason: info:NOTREACHED()] 
[1:1:0426/025949.975278:ERROR:pdfium_engine.cc(2262)] NOTREACHED() hit.  [Reason: info:NOTREACHED()]
[1025:1025:0425/232120.465416:ERROR:network_metrics_provider.cc(405)] NOTREACHED() hit.  [Reason: info:NOTREACHED()] 
[909:909:0426/032825.142682:ERROR:extension_pref_value_map.cc(73)] NOTREACHED() hit.  [Reason: info:NOTREACHED()] 


What steps will reproduce the problem?
(1) I have no idea. Run crouton and use xiwi, have a few tabs open and possibly some extensions.
 
debug-logs_20170428-180851.tgz
2.2 MB Download

Comment 1 by ajha@chromium.org, Jul 14 2017

Labels: OS-Chrome
Cc: tommycli@chromium.org klemenko@google.com
Components: OS>Systems
Summary: NOTREACHED() in storage_monitor_chromeos.cc::OnMountEvent() (was: NOTREACHED() has been reached)
Thanks for the report, which I just found.  It looks like
- the extension_pref_value_map issue is tracked in  bug 772638 .
- the network_metrics_provider is tracked in bug 636015.

I'll arbitrarily narrow this issue down the the chromeos one:
https://cs.chromium.org/chromium/src/components/storage_monitor/storage_monitor_chromeos.cc?l=163

CCing folks who touched this file recently and hence might be familiar with it

(pdfium bugs should be filed against pdfium, and I don't want to bother right now)

Labels: CrOSFilesFeature-ExternalMedia
Owner: amistry@chromium.org
Status: Assigned (was: Unconfirmed)
I've run across this and seen it a number of times in logs (in 67+). Since I'm looking at mounting issues, I'll take a stab.
Cc: amistry@chromium.org
Owner: ----
Status: Available (was: Assigned)
I've taken a look and this essentially happens when there's an unmount failure. Then StorageMonitorCros will retain the mount point and the next time you insert a disk with the same mount point, it'll be ignored by StorageMonitorCros. The only use of StorageMonitorCros for disks is the system.storage.onAttached API, which doesn't appear to be widely used.
Can you remove the NOTREACHED() please? NOTREACHED() is a crash in debug..
Cc: thestig@chromium.org
 Issue 898263  has been merged into this issue.
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d9a675ef69c1a03c235e62ee1a4c9bf95144f15

commit 2d9a675ef69c1a03c235e62ee1a4c9bf95144f15
Author: Michael Spang <spang@chromium.org>
Date: Tue Oct 23 21:52:13 2018

Remove NOTREACHED in StorageMonitorCros::OnMountEvent

Logging in with a USB drive connected is enough to hit this NOTREACHED().
DiskMountManager re-fires "mounting" notifications inside
RefreshAfterEnumerateMountEntries.

Bug:  716635 
Test: log in with dcheck_always_on=true build

Change-Id: I70c3b7e8064c7465a78c53e6574b20c38b74c168
Reviewed-on: https://chromium-review.googlesource.com/c/1297234
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602116}
[modify] https://crrev.com/2d9a675ef69c1a03c235e62ee1a4c9bf95144f15/components/storage_monitor/storage_monitor_chromeos.cc

Owner: spang@chromium.org
Status: Fixed (was: Available)

Sign in to add a comment