New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 716633 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Install base, not test, images on guado_labstation

Reported by jrbarnette@chromium.org, Apr 28 2017

Issue description

Currently, the guado_labstation-release builder creates
test images.  This has the side effect that the images
for which we build payloads are test image payloads, which
in turn means that guado labstations in chromeos6 are
running test images.

We want both the labstations to run base, not test images
(this is already being done for beaglebone_servo images).

This change comes in two parts, one trivial, one of unknown
difficulty:
  * The trivial operation is to change chromite so that it
    builds only base images.  That will cause the labstation
    images we install in the lab to be base images.
  * The unknown item is to make sure that labstation base
    images have all the packages they need.  I expect we've
    never tested this.  It may just work, but it may require
    adjusting ebuild dependencies.

 
Looking at the guado_labstation-release configuration, I see
that not only does it build a test image, it configures hardware
tests (even though there are no DUTs to test), and it currently
doesn't build a base image.

Probably, the required chromite changes look like this:

diff --git a/cbuildbot/chromeos_config.py b/cbuildbot/chromeos_config.py
index 39fce6eb..ff92f591 100644
--- a/cbuildbot/chromeos_config.py
+++ b/cbuildbot/chromeos_config.py
@@ -3312,17 +3312,10 @@ def ApplyCustomOverrides(site_config, ge_build_config):
       ),
 
       'guado_labstation-release': {
-          'hw_tests': [
-              config_lib.HWTestConfig(constants.HWTEST_CANARY_SUITE,
-                                      num=1, timeout=120*60, warn_only=True,
-                                      async=True, retry=False, max_retries=None,
-                                      file_bugs=False),
-          ],
-          'image_test':False,
-          'images':['test'],
+          'hw_tests': [],
+          'images':['base'],
           'signer_tests':False,
           'paygen':False,
-          'vm_tests':[],
       },
 
       'lumpy-chrome-pfq': {

Project Member

Comment 2 by bugdroid1@chromium.org, May 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/30f420c24866f9db3789844d205bb7b98aeb566b

commit 30f420c24866f9db3789844d205bb7b98aeb566b
Author: Kevin Cheng <kevcheng@google.com>
Date: Mon May 08 19:43:43 2017

chromeos_config: Add in base image for guado_labstation release config.

BUG=chromium:716633
TEST=None
Change-Id: Id38c04a40422b2f1ce3a6eb2fc9572e1078e0c67
Reviewed-on: https://chromium-review.googlesource.com/491507
Commit-Ready: Kevin Cheng <kevcheng@chromium.org>
Tested-by: Kevin Cheng <kevcheng@chromium.org>
Reviewed-by: Kevin Cheng <kevcheng@chromium.org>

[modify] https://crrev.com/30f420c24866f9db3789844d205bb7b98aeb566b/cbuildbot/config_dump.json
[modify] https://crrev.com/30f420c24866f9db3789844d205bb7b98aeb566b/cbuildbot/chromeos_config.py

Comment 3 by aut...@google.com, May 9 2017

Owner: kevcheng@chromium.org
Labels: akeshet-pending-downgrade
ChromeOS Infra P1 Bugscrub.

P1 Bugs in this component should be important enough to get weekly status updates.

Is this already fixed?  -> Fixed
Is this no longer relevant? -> Archived or WontFix
Is this not a P1, based on go/chromeos-infra-bug-slo rubric? -> lower priority.
Is this a Feature Request rather than a bug? Type -> Feature
Is this missing important information or scope needed to decide how to proceed? -> Ask question on bug, possibly reassign.
Does this bug have the wrong owner? -> reassign.

Bugs that remain in this state next week will be downgraded to P2.

Comment 5 by sosa@chromium.org, Jul 18 2017

Owner: sbasi@chromium.org
Labels: -Pri-1 -akeshet-pending-downgrade Pri-2
Components: Infra>Client>ChromeOS>CI
Components: -Infra>Client>ChromeOS
Status: Assigned (was: Available)

Sign in to add a comment