New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 716604 link

Starred by 1 user
Status: Fixed
Owner:
ctzsm@chromium.org
Closed: Jun 2017
Cc:
█ gsennton@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

combine Webview Native and Browser layers into a single one

Project Member Reported by sgu...@chromium.org, Apr 28 2017 
webview architecturally was designed to have a native layer that handles interaction with Java, and a browser layer that has the implementation. The initial design was such that:

WebView
      Java
   =======================
     C++ Native
     C++ Browser
=======================================
Content
    C++


While this was designed for separating the Java logic from Native, it felt artificial, created extra code complexity in browser and was not compatible with rest of the chromium code.

We will now allow Browser code to talk to Java directly. This may lead to further simplification in Browser code (for example getting rid of interfaces we added to browser)

Also move graphics files to its own subdir. 

As for the work, it would be good to start with
1: a description of subdirs and files that move there, and get consensus
2: do a mechanical move
3: reduce code complexity by getting rid of interfaces and delegates that was designed. For example Awcontentsclientbridge was completely designed as a bridge from Native to Java because of the requirement above.

Comment 1 by boliu@chromium.org, Apr 28 2017 

there's tools/git/move_source_file.py and mass-rename.py

Comment 2 by gsennton@chromium.org, May 3 2017

Cc: gsennton@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, May 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86

commit 0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86
Author: ctzsm <ctzsm@chromium.org>
Date: Tue May 09 04:27:37 2017

[WebView] Move files from native to browser

This patch:
- Moved files from native to broswer mechanically by
using tools/git/move_source_file.py.

- Moved content in //android_webview/native/BUILD.gn to
//android_webview/BUILD.gn.

- Updated //android_webview/test/BUILD.gn for unit tests in
//android_webview/native/.

- Updated corresponding include_rules to //android_webview/broswer/DEPS.

- Contains a lot of formatting from git cl format.

BUG= 716604 
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2863233002
Cr-Commit-Position: refs/heads/master@{#470203}

[modify] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/BUILD.gn
[modify] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/DEPS
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/address_parser.cc
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/address_parser.h
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/address_parser_internal.cc
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/address_parser_internal.h
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/address_parser_unittest.cc
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/android_protocol_handler.cc
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/android_protocol_handler.h
[add] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/android_webview_jni_registrar.cc
[add] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/android_webview_jni_registrar.h
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/aw_autofill_client.cc
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/aw_autofill_client.h
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/aw_contents.cc
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/aw_contents.h
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/aw_contents_background_thread_client.cc
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/aw_contents_background_thread_client.h
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/aw_contents_client_bridge.cc
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/aw_contents_client_bridge.h
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/aw_contents_client_bridge_unittest.cc
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/aw_contents_io_thread_client_impl.cc
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/aw_contents_io_thread_client_impl.h
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/aw_contents_lifecycle_notifier.cc
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/aw_contents_lifecycle_notifier.h
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/aw_contents_statics.cc
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/aw_contents_statics.h
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/aw_debug.cc
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/aw_debug.h
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/aw_devtools_server.cc
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/aw_devtools_server.h
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/aw_form_database.cc
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/aw_form_database.h
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/aw_gl_functor.cc
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/aw_gl_functor.h
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/aw_http_auth_handler.cc
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/aw_http_auth_handler.h
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/aw_locale_manager_impl.cc
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/aw_locale_manager_impl.h
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/aw_media_url_interceptor.cc
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/aw_media_url_interceptor.h
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/aw_media_url_interceptor_unittest.cc
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/aw_metrics_log_uploader.cc
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/aw_metrics_log_uploader.h
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/aw_metrics_service_client_impl.cc
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/aw_metrics_service_client_impl.h
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/aw_pdf_exporter.cc
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/aw_pdf_exporter.h
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/aw_picture.cc
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/aw_picture.h
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/aw_quota_manager_bridge_impl.cc
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/aw_quota_manager_bridge_impl.h
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/aw_renderer_priority_manager.cc
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/aw_renderer_priority_manager.h
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/aw_resource.cc
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/aw_settings.cc
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/aw_settings.h
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/aw_web_contents_delegate.cc
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/aw_web_contents_delegate.h
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/aw_web_contents_view_delegate.cc
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/aw_web_contents_view_delegate.h
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/aw_web_preferences_populater_impl.cc
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/aw_web_preferences_populater_impl.h
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/aw_web_resource_response_impl.cc
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/aw_web_resource_response_impl.h
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/cookie_manager.cc
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/cookie_manager.h
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/input_stream_impl.cc
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/input_stream_impl.h
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/input_stream_unittest.cc
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/java_browser_view_renderer_helper.cc
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/java_browser_view_renderer_helper.h
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/net_init_native_callback.cc
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/permission/aw_permission_request.cc
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/permission/aw_permission_request.h
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/permission/aw_permission_request_delegate.cc
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/permission/aw_permission_request_delegate.h
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/permission/media_access_permission_request.cc
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/permission/media_access_permission_request.h
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/permission/media_access_permission_request_unittest.cc
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/permission/permission_request_handler.cc
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/permission/permission_request_handler.h
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/permission/permission_request_handler_client.cc
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/permission/permission_request_handler_client.h
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/permission/permission_request_handler_unittest.cc
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/permission/simple_permission_request.cc
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/permission/simple_permission_request.h
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/popup_touch_handle_drawable.cc
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/popup_touch_handle_drawable.h
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/state_serializer.cc
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/state_serializer.h
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/state_serializer_unittest.cc
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/token_binding_manager_bridge.cc
[rename] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/browser/token_binding_manager_bridge.h
[modify] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/lib/main/aw_main_delegate.cc
[modify] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/lib/main/webview_jni_onload.cc
[modify] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/lib/main/webview_tests.cc
[delete] https://crrev.com/3248f4867e7ac406e88ac458ae1d34c168506636/android_webview/native/BUILD.gn
[delete] https://crrev.com/3248f4867e7ac406e88ac458ae1d34c168506636/android_webview/native/DEPS
[delete] https://crrev.com/3248f4867e7ac406e88ac458ae1d34c168506636/android_webview/native/android_webview_jni_registrar.cc
[delete] https://crrev.com/3248f4867e7ac406e88ac458ae1d34c168506636/android_webview/native/android_webview_jni_registrar.h
[modify] https://crrev.com/0baa01dcbb179dd9c4ede2ceeff24fbe5e885e86/android_webview/test/BUILD.gn

Comment 4 by gsennton@chromium.org, May 11 2017 

Can we just have the browser/ code depend on JNI now? (to allow new changes to just add jni-code in browser/ instead of native/)

Comment 5 by boliu@chromium.org, May 11 2017 

yes

Comment 6 by boliu@chromium.org, May 11 2017 

This merges the gn targets as well: https://chromium-review.googlesource.com/c/503647/
Project Member

Comment 7 by bugdroid1@chromium.org, May 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5630c518ab23e14c676b14975c132ef2323e633

commit c5630c518ab23e14c676b14975c132ef2323e633
Author: Bo Liu <boliu@chromium.org>
Date: Thu May 11 23:45:41 2017

aw: Remove native source_set

Since native/ has been entirely moved into browser/, the target should
move as well. Cleaned up a few unneeded DEPS as well.

BUG= 716604 

Change-Id: I77fb632279b96318e5aa6d4eefe70046df41188f
Reviewed-on: https://chromium-review.googlesource.com/503647
Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Bo Liu <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#471123}
[modify] https://crrev.com/c5630c518ab23e14c676b14975c132ef2323e633/android_webview/BUILD.gn

Comment 8 by gsennton@chromium.org, May 12 2017 

Thanks Bo!
Project Member

Comment 9 by bugdroid1@chromium.org, May 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9ca8b8cd2b338ecd2dd2bcb72762fed23c811f0c

commit 9ca8b8cd2b338ecd2dd2bcb72762fed23c811f0c
Author: ctzsm <ctzsm@chromium.org>
Date: Wed May 17 03:41:11 2017

[WebView] Merge AwContentsClientBridgeBase into AwContentsClientBridge

AwContentsClientBridgeBase was a browser/ layer interface
for AwContentsClientBridge, since we can make jni calls from
browser/ already, we don't need this interface anymore.

This CL removes AwContentsClientBridgeBase, and put code into
AwContentsClientBridge.

BUG= 716604 

Review-Url: https://codereview.chromium.org/2888623004
Cr-Commit-Position: refs/heads/master@{#472307}

[modify] https://crrev.com/9ca8b8cd2b338ecd2dd2bcb72762fed23c811f0c/android_webview/BUILD.gn
[modify] https://crrev.com/9ca8b8cd2b338ecd2dd2bcb72762fed23c811f0c/android_webview/browser/aw_content_browser_client.cc
[modify] https://crrev.com/9ca8b8cd2b338ecd2dd2bcb72762fed23c811f0c/android_webview/browser/aw_contents.cc
[modify] https://crrev.com/9ca8b8cd2b338ecd2dd2bcb72762fed23c811f0c/android_webview/browser/aw_contents_client_bridge.cc
[modify] https://crrev.com/9ca8b8cd2b338ecd2dd2bcb72762fed23c811f0c/android_webview/browser/aw_contents_client_bridge.h
[delete] https://crrev.com/bc5732b54102e0c89f3098e03ddb865636d5a8bd/android_webview/browser/aw_contents_client_bridge_base.cc
[delete] https://crrev.com/bc5732b54102e0c89f3098e03ddb865636d5a8bd/android_webview/browser/aw_contents_client_bridge_base.h
[modify] https://crrev.com/9ca8b8cd2b338ecd2dd2bcb72762fed23c811f0c/android_webview/browser/aw_javascript_dialog_manager.cc
[modify] https://crrev.com/9ca8b8cd2b338ecd2dd2bcb72762fed23c811f0c/android_webview/browser/net/aw_network_delegate.cc
[modify] https://crrev.com/9ca8b8cd2b338ecd2dd2bcb72762fed23c811f0c/android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc
Project Member

Comment 10 by bugdroid1@chromium.org, May 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/45f8d9f431184fa691b3671c22618e540bb0b286

commit 45f8d9f431184fa691b3671c22618e540bb0b286
Author: ctzsm <ctzsm@chromium.org>
Date: Wed May 17 21:52:37 2017

[WebView] Remove more redundant classes

Since we removed native/ layer, we could make jni calls
from browser/, so no need of separation anymore.

This CL:

1) Merged
aw_http_auth_handler_base.{h,cc} -> aw_http_auth_handler.{h,cc}

2) Removed
aw_locale_manager.h
aw_locale_manager_impl.{h,cc}
aw_web_preferences_populater.{h,cc}
aw_web_preferences_populater_impl.{h,cc}

3) Removed corresponding class factory functions in
JniDependencyFactory and AwMainDelegate.

BUG= 716604 

Review-Url: https://codereview.chromium.org/2884353003
Cr-Commit-Position: refs/heads/master@{#472580}

[modify] https://crrev.com/45f8d9f431184fa691b3671c22618e540bb0b286/android_webview/BUILD.gn
[modify] https://crrev.com/45f8d9f431184fa691b3671c22618e540bb0b286/android_webview/browser/aw_content_browser_client.cc
[modify] https://crrev.com/45f8d9f431184fa691b3671c22618e540bb0b286/android_webview/browser/aw_content_browser_client.h
[modify] https://crrev.com/45f8d9f431184fa691b3671c22618e540bb0b286/android_webview/browser/aw_http_auth_handler.cc
[modify] https://crrev.com/45f8d9f431184fa691b3671c22618e540bb0b286/android_webview/browser/aw_http_auth_handler.h
[delete] https://crrev.com/447617afdade1a98437ffab3bde18c7100fcd667/android_webview/browser/aw_http_auth_handler_base.cc
[delete] https://crrev.com/447617afdade1a98437ffab3bde18c7100fcd667/android_webview/browser/aw_http_auth_handler_base.h
[delete] https://crrev.com/447617afdade1a98437ffab3bde18c7100fcd667/android_webview/browser/aw_locale_manager.h
[delete] https://crrev.com/447617afdade1a98437ffab3bde18c7100fcd667/android_webview/browser/aw_locale_manager_impl.cc
[delete] https://crrev.com/447617afdade1a98437ffab3bde18c7100fcd667/android_webview/browser/aw_locale_manager_impl.h
[modify] https://crrev.com/45f8d9f431184fa691b3671c22618e540bb0b286/android_webview/browser/aw_login_delegate.cc
[modify] https://crrev.com/45f8d9f431184fa691b3671c22618e540bb0b286/android_webview/browser/aw_login_delegate.h
[delete] https://crrev.com/447617afdade1a98437ffab3bde18c7100fcd667/android_webview/browser/aw_web_preferences_populater.cc
[delete] https://crrev.com/447617afdade1a98437ffab3bde18c7100fcd667/android_webview/browser/aw_web_preferences_populater.h
[delete] https://crrev.com/447617afdade1a98437ffab3bde18c7100fcd667/android_webview/browser/aw_web_preferences_populater_impl.cc
[delete] https://crrev.com/447617afdade1a98437ffab3bde18c7100fcd667/android_webview/browser/aw_web_preferences_populater_impl.h
[modify] https://crrev.com/45f8d9f431184fa691b3671c22618e540bb0b286/android_webview/browser/jni_dependency_factory.h
[modify] https://crrev.com/45f8d9f431184fa691b3671c22618e540bb0b286/android_webview/lib/main/aw_main_delegate.cc
[modify] https://crrev.com/45f8d9f431184fa691b3671c22618e540bb0b286/android_webview/lib/main/aw_main_delegate.h
Project Member

Comment 11 by bugdroid1@chromium.org, May 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8cfa2b45fec4dbfe7edbdc32e114669f9640578e

commit 8cfa2b45fec4dbfe7edbdc32e114669f9640578e
Author: ctzsm <ctzsm@chromium.org>
Date: Fri May 19 03:54:22 2017

[WebView] Remove jni_dependency_factory.h

This CL:

Removes the dependency on JniDependencyFactory due
to the merging of native/ and browser/.

Replaced aw_quota_manager_bridge.{h,cc} with the
actual implementation aw_quota_manager_bridge_impl.{h,cc}.

A few cleanup according to changes above.

BUG= 716604 

Review-Url: https://codereview.chromium.org/2888173003
Cr-Commit-Position: refs/heads/master@{#473071}

[modify] https://crrev.com/8cfa2b45fec4dbfe7edbdc32e114669f9640578e/android_webview/BUILD.gn
[modify] https://crrev.com/8cfa2b45fec4dbfe7edbdc32e114669f9640578e/android_webview/browser/android_webview_jni_registrar.cc
[modify] https://crrev.com/8cfa2b45fec4dbfe7edbdc32e114669f9640578e/android_webview/browser/aw_browser_context.cc
[modify] https://crrev.com/8cfa2b45fec4dbfe7edbdc32e114669f9640578e/android_webview/browser/aw_browser_context.h
[modify] https://crrev.com/8cfa2b45fec4dbfe7edbdc32e114669f9640578e/android_webview/browser/aw_content_browser_client.cc
[modify] https://crrev.com/8cfa2b45fec4dbfe7edbdc32e114669f9640578e/android_webview/browser/aw_content_browser_client.h
[modify] https://crrev.com/8cfa2b45fec4dbfe7edbdc32e114669f9640578e/android_webview/browser/aw_quota_manager_bridge.cc
[modify] https://crrev.com/8cfa2b45fec4dbfe7edbdc32e114669f9640578e/android_webview/browser/aw_quota_manager_bridge.h
[delete] https://crrev.com/338aeaad66d93ce040f5757e2d29502810031d67/android_webview/browser/aw_quota_manager_bridge_impl.cc
[delete] https://crrev.com/338aeaad66d93ce040f5757e2d29502810031d67/android_webview/browser/aw_quota_manager_bridge_impl.h
[delete] https://crrev.com/338aeaad66d93ce040f5757e2d29502810031d67/android_webview/browser/jni_dependency_factory.h
[modify] https://crrev.com/8cfa2b45fec4dbfe7edbdc32e114669f9640578e/android_webview/java/src/org/chromium/android_webview/AwQuotaManagerBridge.java
[modify] https://crrev.com/8cfa2b45fec4dbfe7edbdc32e114669f9640578e/android_webview/lib/main/aw_main_delegate.cc
[modify] https://crrev.com/8cfa2b45fec4dbfe7edbdc32e114669f9640578e/android_webview/lib/main/aw_main_delegate.h
Project Member

Comment 12 by bugdroid1@chromium.org, May 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/82bd374dd151cbcd4ca02ad091a48822050e507c

commit 82bd374dd151cbcd4ca02ad091a48822050e507c
Author: ctzsm <ctzsm@chromium.org>
Date: Fri May 19 20:36:01 2017

[WebView] Merge AwMetricsServiceClient and move few files to new place

This CL:

1) Move files around to let them make more sense.
browser/net_init_native_callback.cc -> browser/net/init_native_callback.cc
browser/aw_resource.cc -> common/aw_resource.cc

2) Removed aw_metrics_service_client.{h,cc} and
use aw_metrics_service_client_impl.{h,cc} to replace them.

Hitting the same banned function usage:
Use base/task_scheduler/post_task.h instead of the blocking pool.

Hence requires no presubmit check.

NOPRESUBMIT=true
BUG= 716604 

Review-Url: https://codereview.chromium.org/2886283005
Cr-Commit-Position: refs/heads/master@{#473299}

[modify] https://crrev.com/82bd374dd151cbcd4ca02ad091a48822050e507c/android_webview/BUILD.gn
[modify] https://crrev.com/82bd374dd151cbcd4ca02ad091a48822050e507c/android_webview/browser/android_webview_jni_registrar.cc
[modify] https://crrev.com/82bd374dd151cbcd4ca02ad091a48822050e507c/android_webview/browser/aw_metrics_service_client.cc
[modify] https://crrev.com/82bd374dd151cbcd4ca02ad091a48822050e507c/android_webview/browser/aw_metrics_service_client.h
[delete] https://crrev.com/af4727a9a29c33197e12a7284b9ecad63422b081/android_webview/browser/aw_metrics_service_client_impl.cc
[delete] https://crrev.com/af4727a9a29c33197e12a7284b9ecad63422b081/android_webview/browser/aw_metrics_service_client_impl.h
[rename] https://crrev.com/82bd374dd151cbcd4ca02ad091a48822050e507c/android_webview/browser/net/init_native_callback.cc
[rename] https://crrev.com/82bd374dd151cbcd4ca02ad091a48822050e507c/android_webview/common/aw_resource.cc
[modify] https://crrev.com/82bd374dd151cbcd4ca02ad091a48822050e507c/android_webview/renderer/aw_content_renderer_client.cc
Project Member

Comment 13 by bugdroid1@chromium.org, May 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e9928ffd65c7b5def5a8a5af659ab647f437e3b8

commit e9928ffd65c7b5def5a8a5af659ab647f437e3b8
Author: ctzsm <ctzsm@chromium.org>
Date: Tue May 23 00:56:44 2017

[WebView] Replace AwContentsIoThreadClient, InputStream and AwWebResourceResponse

This CL:

1) Replaced AwContentsIoThreadClient with AwContentsIoThreadClientImpl
2) Replaced InputStream with InputStreamImpl
3) Replaced AwWebResourceResponse with AwWebResourceResponseImpl, and
   moved implementation into browser/net/.

Replacing them due to the merge of native/ and browser/

BUG= 716604 

Review-Url: https://codereview.chromium.org/2889193004
Cr-Commit-Position: refs/heads/master@{#473769}

[modify] https://crrev.com/e9928ffd65c7b5def5a8a5af659ab647f437e3b8/android_webview/BUILD.gn
[modify] https://crrev.com/e9928ffd65c7b5def5a8a5af659ab647f437e3b8/android_webview/browser/android_protocol_handler.cc
[modify] https://crrev.com/e9928ffd65c7b5def5a8a5af659ab647f437e3b8/android_webview/browser/aw_contents.cc
[rename] https://crrev.com/e9928ffd65c7b5def5a8a5af659ab647f437e3b8/android_webview/browser/aw_contents_io_thread_client.cc
[modify] https://crrev.com/e9928ffd65c7b5def5a8a5af659ab647f437e3b8/android_webview/browser/aw_contents_io_thread_client.h
[delete] https://crrev.com/a252bab61a3811269fdca54ca84083856a7e2934/android_webview/browser/aw_contents_io_thread_client_impl.h
[modify] https://crrev.com/e9928ffd65c7b5def5a8a5af659ab647f437e3b8/android_webview/browser/aw_contents_statics.cc
[modify] https://crrev.com/e9928ffd65c7b5def5a8a5af659ab647f437e3b8/android_webview/browser/aw_web_contents_delegate.cc
[delete] https://crrev.com/a252bab61a3811269fdca54ca84083856a7e2934/android_webview/browser/aw_web_resource_response_impl.h
[rename] https://crrev.com/e9928ffd65c7b5def5a8a5af659ab647f437e3b8/android_webview/browser/input_stream.cc
[modify] https://crrev.com/e9928ffd65c7b5def5a8a5af659ab647f437e3b8/android_webview/browser/input_stream.h
[delete] https://crrev.com/a252bab61a3811269fdca54ca84083856a7e2934/android_webview/browser/input_stream_impl.h
[modify] https://crrev.com/e9928ffd65c7b5def5a8a5af659ab647f437e3b8/android_webview/browser/input_stream_unittest.cc
[rename] https://crrev.com/e9928ffd65c7b5def5a8a5af659ab647f437e3b8/android_webview/browser/net/aw_web_resource_response.cc
[modify] https://crrev.com/e9928ffd65c7b5def5a8a5af659ab647f437e3b8/android_webview/browser/net/aw_web_resource_response.h
Project Member

Comment 15 by bugdroid1@chromium.org, May 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/323e56e432cb28e97150b1b2a36225b751e3c398

commit 323e56e432cb28e97150b1b2a36225b751e3c398
Author: ctzsm <ctzsm@chromium.org>
Date: Thu May 25 18:59:59 2017

[WebView] Flatten lib/main to lib

Moves all files under lib/main to lib/ since two levels
here didn't make sense.

With some git cl format.

BUG= 716604 

Review-Url: https://codereview.chromium.org/2901333003
Cr-Commit-Position: refs/heads/master@{#474736}

[modify] https://crrev.com/323e56e432cb28e97150b1b2a36225b751e3c398/android_webview/BUILD.gn
[rename] https://crrev.com/323e56e432cb28e97150b1b2a36225b751e3c398/android_webview/lib/aw_main_delegate.cc
[rename] https://crrev.com/323e56e432cb28e97150b1b2a36225b751e3c398/android_webview/lib/aw_main_delegate.h
[rename] https://crrev.com/323e56e432cb28e97150b1b2a36225b751e3c398/android_webview/lib/webview_entry_point.cc
[rename] https://crrev.com/323e56e432cb28e97150b1b2a36225b751e3c398/android_webview/lib/webview_jni_onload.cc
[rename] https://crrev.com/323e56e432cb28e97150b1b2a36225b751e3c398/android_webview/lib/webview_jni_onload.h
[rename] https://crrev.com/323e56e432cb28e97150b1b2a36225b751e3c398/android_webview/lib/webview_tests.cc
[modify] https://crrev.com/323e56e432cb28e97150b1b2a36225b751e3c398/android_webview/test/BUILD.gn
[modify] https://crrev.com/323e56e432cb28e97150b1b2a36225b751e3c398/chrome/browser/android/monochrome_entry_point.cc

Comment 16 by ctzsm@chromium.org, Jun 2 2017

Status: Fixed (was: Assigned)
Project Member

Comment 17 by bugdroid1@chromium.org, Jun 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db647e049928d104ea3ba97d43ccbcfd2330ba94

commit db647e049928d104ea3ba97d43ccbcfd2330ba94
Author: fanjinsong <fanjinsong@sogou-inc.com>
Date: Fri Jun 09 20:26:45 2017

Fix header guard and namespace in android_webview

BUG= 716604 
TEST=
R=sgurun@chromium.org

Review-Url: https://codereview.chromium.org/2928823004
Cr-Commit-Position: refs/heads/master@{#478394}

[modify] https://crrev.com/db647e049928d104ea3ba97d43ccbcfd2330ba94/AUTHORS
[modify] https://crrev.com/db647e049928d104ea3ba97d43ccbcfd2330ba94/android_webview/browser/aw_browser_terminator.cc
[modify] https://crrev.com/db647e049928d104ea3ba97d43ccbcfd2330ba94/android_webview/browser/aw_browser_terminator.h
[modify] https://crrev.com/db647e049928d104ea3ba97d43ccbcfd2330ba94/android_webview/browser/aw_content_browser_client.h
[modify] https://crrev.com/db647e049928d104ea3ba97d43ccbcfd2330ba94/android_webview/browser/aw_contents_background_thread_client.h
[modify] https://crrev.com/db647e049928d104ea3ba97d43ccbcfd2330ba94/android_webview/browser/aw_contents_client_bridge_unittest.cc
[modify] https://crrev.com/db647e049928d104ea3ba97d43ccbcfd2330ba94/android_webview/browser/aw_contents_lifecycle_notifier.h
[modify] https://crrev.com/db647e049928d104ea3ba97d43ccbcfd2330ba94/android_webview/browser/aw_contents_statics.h
[modify] https://crrev.com/db647e049928d104ea3ba97d43ccbcfd2330ba94/android_webview/browser/aw_devtools_manager_delegate.h
[modify] https://crrev.com/db647e049928d104ea3ba97d43ccbcfd2330ba94/android_webview/browser/aw_picture.h
[modify] https://crrev.com/db647e049928d104ea3ba97d43ccbcfd2330ba94/android_webview/browser/aw_printing_message_filter.h
[modify] https://crrev.com/db647e049928d104ea3ba97d43ccbcfd2330ba94/android_webview/browser/aw_renderer_priority_manager.h
[modify] https://crrev.com/db647e049928d104ea3ba97d43ccbcfd2330ba94/android_webview/browser/child_frame.cc
[modify] https://crrev.com/db647e049928d104ea3ba97d43ccbcfd2330ba94/android_webview/browser/child_frame.h
[modify] https://crrev.com/db647e049928d104ea3ba97d43ccbcfd2330ba94/android_webview/browser/compositor_frame_consumer.h
[modify] https://crrev.com/db647e049928d104ea3ba97d43ccbcfd2330ba94/android_webview/browser/cookie_manager.cc
[modify] https://crrev.com/db647e049928d104ea3ba97d43ccbcfd2330ba94/android_webview/browser/net/aw_cookie_store_wrapper.h
[modify] https://crrev.com/db647e049928d104ea3ba97d43ccbcfd2330ba94/android_webview/browser/net/aw_network_change_notifier_factory.h
[modify] https://crrev.com/db647e049928d104ea3ba97d43ccbcfd2330ba94/android_webview/browser/net/input_stream_reader.h
[modify] https://crrev.com/db647e049928d104ea3ba97d43ccbcfd2330ba94/android_webview/browser/parent_compositor_draw_constraints.cc
[modify] https://crrev.com/db647e049928d104ea3ba97d43ccbcfd2330ba94/android_webview/browser/permission/aw_permission_request.cc
[modify] https://crrev.com/db647e049928d104ea3ba97d43ccbcfd2330ba94/android_webview/browser/permission/aw_permission_request.h
[modify] https://crrev.com/db647e049928d104ea3ba97d43ccbcfd2330ba94/android_webview/browser/permission/aw_permission_request_delegate.cc
[modify] https://crrev.com/db647e049928d104ea3ba97d43ccbcfd2330ba94/android_webview/browser/permission/aw_permission_request_delegate.h
[modify] https://crrev.com/db647e049928d104ea3ba97d43ccbcfd2330ba94/android_webview/browser/permission/media_access_permission_request.h
[modify] https://crrev.com/db647e049928d104ea3ba97d43ccbcfd2330ba94/android_webview/browser/permission/permission_request_handler.cc
[modify] https://crrev.com/db647e049928d104ea3ba97d43ccbcfd2330ba94/android_webview/browser/permission/permission_request_handler.h
[modify] https://crrev.com/db647e049928d104ea3ba97d43ccbcfd2330ba94/android_webview/browser/permission/permission_request_handler_client.cc
[modify] https://crrev.com/db647e049928d104ea3ba97d43ccbcfd2330ba94/android_webview/browser/permission/permission_request_handler_client.h
[modify] https://crrev.com/db647e049928d104ea3ba97d43ccbcfd2330ba94/android_webview/browser/permission/permission_request_handler_unittest.cc
[modify] https://crrev.com/db647e049928d104ea3ba97d43ccbcfd2330ba94/android_webview/browser/permission/simple_permission_request.h
[modify] https://crrev.com/db647e049928d104ea3ba97d43ccbcfd2330ba94/android_webview/browser/popup_touch_handle_drawable.cc
[modify] https://crrev.com/db647e049928d104ea3ba97d43ccbcfd2330ba94/android_webview/browser/popup_touch_handle_drawable.h
[modify] https://crrev.com/db647e049928d104ea3ba97d43ccbcfd2330ba94/android_webview/browser/renderer_host/aw_render_view_host_ext.h
[modify] https://crrev.com/db647e049928d104ea3ba97d43ccbcfd2330ba94/android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.h
[modify] https://crrev.com/db647e049928d104ea3ba97d43ccbcfd2330ba94/android_webview/browser/scoped_app_gl_state_restore.h
[modify] https://crrev.com/db647e049928d104ea3ba97d43ccbcfd2330ba94/android_webview/browser/state_serializer.h
[modify] https://crrev.com/db647e049928d104ea3ba97d43ccbcfd2330ba94/android_webview/browser/test/rendering_test.cc
[modify] https://crrev.com/db647e049928d104ea3ba97d43ccbcfd2330ba94/android_webview/browser/token_binding_manager_bridge.cc
[modify] https://crrev.com/db647e049928d104ea3ba97d43ccbcfd2330ba94/android_webview/common/crash_reporter/aw_microdump_crash_reporter.h
[modify] https://crrev.com/db647e049928d104ea3ba97d43ccbcfd2330ba94/android_webview/common/crash_reporter/crash_keys.h
[modify] https://crrev.com/db647e049928d104ea3ba97d43ccbcfd2330ba94/android_webview/lib/webview_jni_onload.cc
[modify] https://crrev.com/db647e049928d104ea3ba97d43ccbcfd2330ba94/android_webview/renderer/aw_content_settings_client.cc
[modify] https://crrev.com/db647e049928d104ea3ba97d43ccbcfd2330ba94/android_webview/renderer/aw_render_frame_ext.h
[modify] https://crrev.com/db647e049928d104ea3ba97d43ccbcfd2330ba94/android_webview/renderer/aw_render_thread_observer.cc
Project Member

Comment 18 by bugdroid1@chromium.org, Aug 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d4cac414581a80495c1fa06a7f0e8f8409ee692

commit 4d4cac414581a80495c1fa06a7f0e8f8409ee692
Author: Shimi Zhang <ctzsm@chromium.org>
Date: Thu Aug 10 17:38:29 2017

aw: Remove aw_browser_process.{h,cc}

We combined android_webview/native/ and android_webview/browser/
already, so we could make JNI calls in android_webview/browser/
now. These files are not necessary anymore, so remove them and
make JNI call directly.

Bug:  716604 
Change-Id: Ic7d80830b2e8fa5cca687b38b8d5f4e540425579
Reviewed-on: https://chromium-review.googlesource.com/609114
Reviewed-by: Gustav Sennton <gsennton@chromium.org>
Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493448}
[modify] https://crrev.com/4d4cac414581a80495c1fa06a7f0e8f8409ee692/android_webview/BUILD.gn
[delete] https://crrev.com/008f8daf59e8d74ea3bf5a27e7d5d3ae9132c4bd/android_webview/browser/aw_browser_process.cc
[delete] https://crrev.com/008f8daf59e8d74ea3bf5a27e7d5d3ae9132c4bd/android_webview/browser/aw_browser_process.h
[modify] https://crrev.com/4d4cac414581a80495c1fa06a7f0e8f8409ee692/android_webview/browser/aw_browser_terminator.cc
►

Sign in to add a comment