New issue
Advanced search Search tips

Issue 716601 link

Starred by 1 user
Status: Fixed
Owner:
chengx@chromium.org
Closed: May 2017
Cc:
grt@chromium.org
brucedaw...@chromium.org
gab@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

The jumplist class is leaking temp files in JumpListIcons directory

Project Member Reported by chengx@chromium.org, Apr 28 2017 
The JumpListIcons folder sometimes has a few empty temp files with 0 KB in size, which indicates the jumplist code is leaking temp files. This can cause severe performance issue.

All the temp files stored in the JumpListIcons directory should be 28 KB as it store the icons' content. Any empty temp files there should be deleted timely by the jumplist code.
Project Member

Comment 1 by bugdroid1@chromium.org, May 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ced3697c2cfa3e1d5814f8bbf9456aaf4a75543b

commit ced3697c2cfa3e1d5814f8bbf9456aaf4a75543b
Author: chengx <chengx@chromium.org>
Date: Mon May 01 18:21:39 2017

Delete JumpList temp file when failing to write the icon's content to it

Currently, an empty temp file is created before a JumpList icon's
content is written to it. However, the temp file is not deleted right
away if the content writing fails, which explains why there're empty
icon temp files in the jumplist folder sometimes. This indicates we're
leaking temp files and may cause performance issues.

This CL fixes this issue by deleting the empty temp files right away
when necessary.

BUG= 40407 ,  179576 ,  715902 ,  716601 

Review-Url: https://codereview.chromium.org/2852763003
Cr-Commit-Position: refs/heads/master@{#468357}

[modify] https://crrev.com/ced3697c2cfa3e1d5814f8bbf9456aaf4a75543b/chrome/browser/win/jumplist.cc

Comment 2 by chengx@chromium.org, May 1 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment