New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 716599 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Gtk3: Tooltips on Adwaita render with a grey background

Project Member Reported by thomasanderson@chromium.org, Apr 28 2017

Issue description

Adwaita tooltips should have a black background, but Chrome renders them as light grey.  This makes the white tooltip text unreadable.
 
Labels: -Type-Bug M-59 OS-Linux Type-Bug-Regression
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, May 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/376a670d2f7ec27bedaf8fae558809c0c60c4b49

commit 376a670d2f7ec27bedaf8fae558809c0c60c4b49
Author: thomasanderson <thomasanderson@google.com>
Date: Wed May 03 22:23:04 2017

Gtk3: Add background class to tooltips

This CL fixes the tooltip background color on the non-Dark variant of
Adwaita which requires tooltips have the "background" class [1].

Additionally, this CL avoids creating a selector with a GtkWindow
parent class on Gtk 3.20.  This avoids tinting the tooltip with the
window background color if tooltips have transparency (FYI: Chrome
tooltips are opaque, so the alpha will be ignored).

[1] https://github.com/GNOME/gtk/blob/ee3994f715a2f53519f1478d2f08c6548471a8ae/gtk/theme/Adwaita/gtk-contained.css#L4387

BUG= 716599 
R=erg@chromium.org

Review-Url: https://codereview.chromium.org/2855063002
Cr-Commit-Position: refs/heads/master@{#469165}

[modify] https://crrev.com/376a670d2f7ec27bedaf8fae558809c0c60c4b49/chrome/browser/ui/libgtkui/gtk_util.h
[modify] https://crrev.com/376a670d2f7ec27bedaf8fae558809c0c60c4b49/chrome/browser/ui/libgtkui/native_theme_gtk3.cc

Labels: Merge-Request-59
Project Member

Comment 4 by sheriffbot@chromium.org, May 4 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, May 4 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f750c37727efbda389408dc93b81c8861cacae5d

commit f750c37727efbda389408dc93b81c8861cacae5d
Author: thomasanderson <thomasanderson@chromium.org>
Date: Thu May 04 23:49:19 2017

[Merge to M59] Gtk3: Add background class to tooltips

> This CL fixes the tooltip background color on the non-Dark variant of
> Adwaita which requires tooltips have the "background" class [1].
>
> Additionally, this CL avoids creating a selector with a GtkWindow
> parent class on Gtk 3.20.  This avoids tinting the tooltip with the
> window background color if tooltips have transparency (FYI: Chrome
> tooltips are opaque, so the alpha will be ignored).
>
> [1] https://github.com/GNOME/gtk/blob/ee3994f715a2f53519f1478d2f08c6548471a8ae/gtk/theme/Adwaita/gtk-contained.css#L4387
>
> BUG= 716599 
> R=erg@chromium.org
>
> Review-Url: https://codereview.chromium.org/2855063002
> Cr-Commit-Position: refs/heads/master@{#469165}

BUG= 716599 
TBR=erg@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2863843002
Cr-Commit-Position: refs/branch-heads/3071@{#410}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/f750c37727efbda389408dc93b81c8861cacae5d/chrome/browser/ui/libgtkui/gtk_util.h
[modify] https://crrev.com/f750c37727efbda389408dc93b81c8861cacae5d/chrome/browser/ui/libgtkui/native_theme_gtk3.cc

Status: Fixed (was: Started)
Cc: thomasanderson@chromium.org sandeepkumars@chromium.org
 Issue 716335  has been merged into this issue.
Components: Infra>Git
Labels: TE-Verified-M59 TE-Verified-59.0.3071.47
Verified the issue on Linux open suse using chrome beta#59.0.3071.47 as per the steps & video provided in above merged issue (716335).

Observed tool tip background is in black color & text displayed in white color when theme is GTK+ & Classic also.

As issue working as intended ,adding TE Verified labels.

Please find the attached screen cast for reference.
Thank you..!!
716599.webm
1.0 MB View Download

Sign in to add a comment