New issue
Advanced search Search tips

Issue 716595 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

PrintPreviewDestinationSearchTest.Select is failing for Linux MSAN

Project Member Reported by skau@chromium.org, Apr 28 2017

Issue description

PrintPreviewDestinationSearchTest.Select seems to be failing again on the linux msan bot. Here's the first failure: https://build.chromium.org/p/chromium.memory/builders/Linux%20MSan%20Tests/builds/411 .
 

Comment 1 by sky@chromium.org, Apr 28 2017

I manually reset to fe0c8a56f34301a2092281832d79498f3ca45023 , which is the commit before the failure (previous run of the bot) and I still see the failure. So, either I'm doing something wrong in trying to repro, or the test was failing earlier on.

Comment 2 by skau@chromium.org, Apr 28 2017

I'm seeing MSan causing the browser to crash when print preview is opened.  I'm trying to investigate why.  I've been seeing this failure locally for a few days.

Comment 3 by skau@chromium.org, Apr 28 2017

It's weird that it just started crashing.  That test has been in there for a while:
https://cs.chromium.org/chromium/src/chrome/test/data/webui/print_preview_destination_search_test.js?type=cs&q=ReceiveFailedSetup&sq=package:chromium&l=219

It's behaving correctly, but the console error is causing the test to fail.  I'll have a fix out for it shortly.

Comment 4 by sky@chromium.org, May 2 2017

skau has fix fix out for review here: https://codereview.chromium.org/2848093002/ .
Project Member

Comment 5 by bugdroid1@chromium.org, May 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d61afbf71f7ccea7bf8b2e5632e3f3d052a7813f

commit d61afbf71f7ccea7bf8b2e5632e3f3d052a7813f
Author: skau <skau@chromium.org>
Date: Tue May 02 22:27:32 2017

Process null capabilities as a capability fetch failure.

We can never do anything if a request for printer capabilities returns
null.  Thus, assert that it's non-null and call the failure code if capabilities is null.

This also fixes PrintPreviewDestinationSearchTest.Select which has been
failing on the Linux MSan buildbot sporadically.

BUG= 708739 , 716595 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2848093002
Cr-Commit-Position: refs/heads/master@{#468794}

[modify] https://crrev.com/d61afbf71f7ccea7bf8b2e5632e3f3d052a7813f/chrome/browser/resources/print_preview/native_layer.js
[modify] https://crrev.com/d61afbf71f7ccea7bf8b2e5632e3f3d052a7813f/chrome/browser/ui/webui/print_preview/print_preview_handler.cc
[modify] https://crrev.com/d61afbf71f7ccea7bf8b2e5632e3f3d052a7813f/chrome/test/data/webui/print_preview_destination_search_test.js

Comment 6 by skau@chromium.org, May 3 2017

Status: Fixed (was: Started)
browser_tests are now passing
https://build.chromium.org/p/chromium.memory/builders/Linux%20MSan%20Tests/builds/532

Sign in to add a comment