Double clicking network request doesn't always open it in a new tab
Reported by
workalis...@gmail.com,
Apr 28 2017
|
|||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.81 Safari/537.36 Steps to reproduce the problem: 1. Load any page with DevTools open. 2. Go to the Network tab. 3. Double click on any network request row What is the expected behavior? The url of the network request should open in a new tab What went wrong? This works about 50% of the time now. Clicking outside the Network Request list and then double-clicking on a row seems to improve success rates, but not to 100%. Did this work before? Yes 57 Chrome version: 58.0.3029.81 Channel: stable OS Version: OS X 10.12.4 Flash Version: I'm using a Mac Trackpad, and it happens with both double-tap and physical double-click. Also happens both with the trackpad on my laptop and the external trackpad. Also happens on any file type. For a while it looked like XHR requests were having more trouble than, say, images or css files. But now I'm having about the same amount of trouble with all file types. I haven't found a consistent way to double-click to get these to open. I've tried: * clicking inside the website pane then doubleclicking the row; * closing the details pane then doubleclicking the row; * clicking inside the details pane then doubleclicking the row; * clicking a different row then doubleclicking the row; * doubleclicking in different places in the row. It seemed for a while like some of these were improving success rates, but now I think it may have just been random chance.
,
May 1 2017
,
May 4 2017
Able to reproduce the issue on Windows 10, Ubuntu 14.04 and Mac 10.12.2 using reported version #58.0.3029.81 and latest canary #60.0.3088.3. Bisect Information: ===================== Good build: 58.0.3006.0 Revision(448862) Bad Build : 58.0.3007.0 Revision(449173) Change Log URL: https://chromium.googlesource.com/chromium/src/+log/a79a95466df9d013721167cf2f0c8ba849214207..1c12127b721f833f37b81553e19b8eb0392da651 From the above change log suspecting below change Review URL: https://codereview.chromium.org/2496133002 tkent@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Adding label ReleaseBlock-Stable as it seems to be a recent regression. Please feel free to remove the same if not appropriate. Thanks...!!
,
May 4 2017
,
May 4 2017
,
May 4 2017
Please target for M59.
,
May 8 2017
DevTools code relies on the bug behavior we fixed.
,
May 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6d44fde7f95c979cd78698142389b6fe4fa8916f commit 6d44fde7f95c979cd78698142389b6fe4fa8916f Author: tkent <tkent@chromium.org> Date: Thu May 11 05:55:21 2017 DevTools: Fix a regression that double-clicking an item in the Network tab doesn't open the item in a new tab. ViewportDataGrid._update() has the following code: tBody.insertBefore(element, previousElement.nextSibling); where |previousElement.nextSibling| can be |element|. The code did nothing before [1], but we remove |element| from |tBody| and add it to |tBody| again after [1]. Because the code is executed in 'mousedown' event handler, 'dblclick' event for |element| wasn't dispatched. This CL updates ViewportDataGrid so that it skips to call insertBefore() if |element| is |previousElement.nextSibling|. [1] https://chromium.googlesource.com/chromium/src/+/1c12127b721f833f37b81553e19b8eb0392da651 BUG= 716583 Review-Url: https://codereview.chromium.org/2869643002 Cr-Commit-Position: refs/heads/master@{#470833} [modify] https://crrev.com/6d44fde7f95c979cd78698142389b6fe4fa8916f/third_party/WebKit/Source/devtools/front_end/data_grid/ViewportDataGrid.js
,
May 12 2017
,
May 12 2017
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/40c9f80c84d855a837d0be558173f8a27679d110 commit 40c9f80c84d855a837d0be558173f8a27679d110 Author: Kent Tamura <tkent@chromium.org> Date: Fri May 12 08:49:30 2017 Merge "DevTools: Fix a regression that double-clicking an item in the Network tab doesn't open the item in a new tab." to M59 ViewportDataGrid._update() has the following code: tBody.insertBefore(element, previousElement.nextSibling); where |previousElement.nextSibling| can be |element|. The code did nothing before [1], but we remove |element| from |tBody| and add it to |tBody| again after [1]. Because the code is executed in 'mousedown' event handler, 'dblclick' event for |element| wasn't dispatched. This CL updates ViewportDataGrid so that it skips to call insertBefore() if |element| is |previousElement.nextSibling|. [1] https://chromium.googlesource.com/chromium/src/+/1c12127b721f833f37b81553e19b8eb0392da651 BUG= 716583 Review-Url: https://codereview.chromium.org/2869643002 Cr-Original-Commit-Position: refs/heads/master@{#470833} Review-Url: https://codereview.chromium.org/2879833002 . Cr-Commit-Position: refs/branch-heads/3071@{#526} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/40c9f80c84d855a837d0be558173f8a27679d110/third_party/WebKit/Source/devtools/front_end/data_grid/ViewportDataGrid.js
,
May 17 2017
Rechecked this issue on Windows 10, MAC 10.12.4, Ubuntu 14.04 using build 59.0.3071.61. Fix is working as intended, double clicking the network url's from a network tab of dev tools, opens appropriate page in a new tab of chrome Window. Adding TE-Verified labels. Thanks.! |
|||||||||||||||
►
Sign in to add a comment |
|||||||||||||||
Comment 1 by ligim...@chromium.org
, Apr 28 2017