New issue
Advanced search Search tips

Issue 716582 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 11
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Direct-leak in dyld_register_image_state_change_handler

Project Member Reported by ClusterFuzz, Apr 28 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5857453712605184

Fuzzer: v8_builtins_generator
Job Type: mac_asan_d8
Platform Id: mac

Crash Type: Direct-leak
Crash Address: 
Crash State:
  dyld_register_image_state_change_handler
  _xpc_collect_images
  _libxpc_initializer
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=mac_asan_d8&range=466203:466217

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5857453712605184


Issue filed automatically.

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Owner: machenb...@chromium.org
Status: Assigned (was: Untriaged)
Michael, that seems like some leak in a system framework. How can we add suppressions for Mac?
Cc: machenb...@chromium.org infe...@chromium.org
Owner: mbarbe...@chromium.org
Why are we checking for leaks on mac asan in the first place? In order to do so, we should have a CI bot for this first. Neither Chromium (e.g. https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Builder/builds/51056) nor V8 (e.g. https://build.chromium.org/p/client.v8/builders/V8%20Mac64%20ASAN/builds/12049) switch on leak detection for asan.

mbarbella or inferno, who added this job type? Can we just disable leak detection? Or is there a clusterfuzz-side suppression file?

If leak detection should indeed be switched on on Clusterfuzz, I'll work on switching it on in our CI too...
Project Member

Comment 3 by ClusterFuzz, May 22 2017

ClusterFuzz has detected this issue as fixed in range 473072:473103.

Detailed report: https://clusterfuzz.com/testcase?key=5857453712605184

Fuzzer: v8_builtins_generator
Job Type: mac_asan_d8
Platform Id: mac

Crash Type: Direct-leak
Crash Address: 
Crash State:
  dyld_register_image_state_change_handler
  _xpc_collect_images
  _libxpc_initializer
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=mac_asan_d8&range=466203:466217
Fixed: https://clusterfuzz.com/revisions?job=mac_asan_d8&range=473072:473103

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5857453712605184


See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 4 by ClusterFuzz, May 22 2017

ClusterFuzz has detected this issue as fixed in range 473072:473103.

Detailed report: https://clusterfuzz.com/testcase?key=5857453712605184

Fuzzer: v8_builtins_generator
Job Type: mac_asan_d8
Platform Id: mac

Crash Type: Direct-leak
Crash Address: 
Crash State:
  dyld_register_image_state_change_handler
  _xpc_collect_images
  _libxpc_initializer
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=mac_asan_d8&range=466203:466217
Fixed: https://clusterfuzz.com/revisions?job=mac_asan_d8&range=473072:473103

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5857453712605184


See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 5 by ClusterFuzz, May 22 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5857453712605184 is verified as fixed, so closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Status: Assigned (was: Verified)
Probably the clang roll fixed that. Still a question in comment 2 remains unanswered, mbarbella, inferno, friendly ping.
Labels: Needs-Feedback
Labels: -Needs-Feedback
Status: Fixed (was: Assigned)
Sorry for the extremely late reply. It's quite easy to disable leak detection for mac but I think it is something we'd like to have. Enabling it in the CI sounds better to me if it hasn't already been addressed. If there's still anything to do here, let me know.

Sign in to add a comment