Replace WriteToFileNetLogObserver with FileNetLogObserver |
|||
Issue descriptionIn particular for the implementation of --log-net-log. FileNetLogObserver has the advantage of not doing file I/O on the calling thread, well tested, and also supporting bounded mode logging. There should only be one implementation that we maintain, and have to extend when changing the file format.
,
Jul 8 2017
,
Jul 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b5dc585c02e13d733974b88f42ebe0b027c94b13 commit b5dc585c02e13d733974b88f42ebe0b027c94b13 Author: Eric Roman <eroman@chromium.org> Date: Mon Jul 10 18:14:41 2017 Use FileNetLogObserver in cronet (iOS). This replaces use of the deprecated WriteToFileNetLogObserver. It has the advantage of moving file I/O off the calling thread. Bug: 716570 Change-Id: I89a3c36617c1328f0e64409b341e6483815910f7 Reviewed-on: https://chromium-review.googlesource.com/564341 Reviewed-by: Matt Menke <mmenke@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#485314} [modify] https://crrev.com/b5dc585c02e13d733974b88f42ebe0b027c94b13/components/cronet/ios/cronet_environment.h [modify] https://crrev.com/b5dc585c02e13d733974b88f42ebe0b027c94b13/components/cronet/ios/cronet_environment.mm
,
Jul 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dec4e769529be35cae829c6636ddf8eb8b4e54d7 commit dec4e769529be35cae829c6636ddf8eb8b4e54d7 Author: Eric Roman <eroman@chromium.org> Date: Mon Jul 10 19:16:18 2017 Use FileNetLogObserver in Cast. This replaces use of the deprecated WriteToFileNetLogObserver. It has the advantage of moving file I/O off the calling thread. Bug: 716570 Change-Id: Idac0cec3d1eb59fedc1793e2f60f9244d0324789 Reviewed-on: https://chromium-review.googlesource.com/564074 Reviewed-by: Matt Menke <mmenke@chromium.org> Reviewed-by: Luke Halliwell <halliwell@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#485339} [modify] https://crrev.com/dec4e769529be35cae829c6636ddf8eb8b4e54d7/chromecast/browser/cast_net_log.cc [modify] https://crrev.com/dec4e769529be35cae829c6636ddf8eb8b4e54d7/chromecast/browser/cast_net_log.h
,
Jul 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/71a09f83e752f5d320b037ea6a81ed674b75240e commit 71a09f83e752f5d320b037ea6a81ed674b75240e Author: Eric Roman <eroman@chromium.org> Date: Mon Jul 10 19:27:58 2017 Use FileNetLogObserver in NetworkService. This replaces use of the deprecated WriteToFileNetLogObserver. It has the advantage of moving file I/O off the calling thread. Bug: 716570 Change-Id: I4a8c12ff5055cee4aa917aade451ec661785f005 Reviewed-on: https://chromium-review.googlesource.com/564065 Reviewed-by: Matt Menke <mmenke@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#485344} [modify] https://crrev.com/71a09f83e752f5d320b037ea6a81ed674b75240e/content/network/network_service.cc
,
Jul 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/39242679a2202b4bb17246c361d01efc01cb4c1c commit 39242679a2202b4bb17246c361d01efc01cb4c1c Author: Eric Roman <eroman@chromium.org> Date: Mon Jul 10 21:09:34 2017 Use FileNetLogObserver in the net-internals browser_tests. Bug: 716570 Change-Id: I9a81dff8ed17ff9d61b89c9ef887a918770a80a9 Reviewed-on: https://chromium-review.googlesource.com/563862 Reviewed-by: Matt Menke <mmenke@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#485386} [modify] https://crrev.com/39242679a2202b4bb17246c361d01efc01cb4c1c/chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.cc [modify] https://crrev.com/39242679a2202b4bb17246c361d01efc01cb4c1c/chrome/test/data/webui/net_internals/log_util.js [modify] https://crrev.com/39242679a2202b4bb17246c361d01efc01cb4c1c/net/log/file_net_log_observer.h
,
Jul 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6fedbf806dbb068d8cf0ae6bc1eae1ed8c56bac4 commit 6fedbf806dbb068d8cf0ae6bc1eae1ed8c56bac4 Author: Eric Roman <eroman@chromium.org> Date: Tue Jul 11 19:05:05 2017 Use FileNetLogObserver in headless builds. This replaces use of the deprecated WriteToFileNetLogObserver. It has the advantage of moving file I/O off the calling thread. Bug: 716570 Change-Id: I757c276b67c845bbcade777547b6a38342127460 Reviewed-on: https://chromium-review.googlesource.com/564198 Reviewed-by: Matt Menke <mmenke@chromium.org> Reviewed-by: Alex Clarke <alexclarke@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#485688} [modify] https://crrev.com/6fedbf806dbb068d8cf0ae6bc1eae1ed8c56bac4/headless/lib/browser/headless_net_log.cc [modify] https://crrev.com/6fedbf806dbb068d8cf0ae6bc1eae1ed8c56bac4/headless/lib/browser/headless_net_log.h
,
Jul 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/84702920824e6a9c0610ae34904652fc0424a93d commit 84702920824e6a9c0610ae34904652fc0424a93d Author: Eric Roman <eroman@chromium.org> Date: Tue Jul 11 19:07:37 2017 Revert "Use FileNetLogObserver in cronet (iOS)." This reverts commit b5dc585c02e13d733974b88f42ebe0b027c94b13. Reason for revert: Crashes on ios Original change's description: > Use FileNetLogObserver in cronet (iOS). > > This replaces use of the deprecated WriteToFileNetLogObserver. > It has the advantage of moving file I/O off the calling thread. > > Bug: 716570 > Change-Id: I89a3c36617c1328f0e64409b341e6483815910f7 > Reviewed-on: https://chromium-review.googlesource.com/564341 > Reviewed-by: Matt Menke <mmenke@chromium.org> > Commit-Queue: Eric Roman <eroman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#485314} TBR=eroman@chromium.org,mmenke@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 716570 Change-Id: I5ddb3641dca0c5f83f2522db0b4b3a09bbc1c25d Reviewed-on: https://chromium-review.googlesource.com/567240 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#485689} [modify] https://crrev.com/84702920824e6a9c0610ae34904652fc0424a93d/components/cronet/ios/cronet_environment.h [modify] https://crrev.com/84702920824e6a9c0610ae34904652fc0424a93d/components/cronet/ios/cronet_environment.mm
,
Jul 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/da0e6363c0a65af81447e336ecb8f87fa8de1c6c commit da0e6363c0a65af81447e336ecb8f87fa8de1c6c Author: Eric Roman <eroman@chromium.org> Date: Wed Jul 12 00:16:49 2017 Use FileNetLogObserver in content_shell. This replaces use of the deprecated WriteToFileNetLogObserver. It has the advantage of moving file I/O off the calling thread. Bug: 716570 Change-Id: Iad69073354f0bdb8fe5ab1efaa245bfa1d36d1d2 Reviewed-on: https://chromium-review.googlesource.com/564321 Reviewed-by: Matt Menke <mmenke@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#485739} [modify] https://crrev.com/da0e6363c0a65af81447e336ecb8f87fa8de1c6c/content/shell/browser/shell_net_log.cc [modify] https://crrev.com/da0e6363c0a65af81447e336ecb8f87fa8de1c6c/content/shell/browser/shell_net_log.h
,
Jul 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a8394ca4036e8f5b873f6081a1a50b747c1814f5 commit a8394ca4036e8f5b873f6081a1a50b747c1814f5 Author: Eric Roman <eroman@chromium.org> Date: Wed Jul 12 02:30:26 2017 Use FileNetLogObserver in mcs_probe. This replaces use of the deprecated WriteToFileNetLogObserver. It has the advantage of moving file I/O off the calling thread. Bug: 716570 Change-Id: I45a7ab7af11e6bd40892946821f3a3cebf15217f Reviewed-on: https://chromium-review.googlesource.com/564286 Reviewed-by: Matt Menke <mmenke@chromium.org> Reviewed-by: Nicolas Zea <zea@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#485805} [modify] https://crrev.com/a8394ca4036e8f5b873f6081a1a50b747c1814f5/google_apis/gcm/tools/mcs_probe.cc
,
Jul 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a33615a8760266c7ca997d866790ce089382809f commit a33615a8760266c7ca997d866790ce089382809f Author: Misha Efimov <mef@chromium.org> Date: Wed Jul 12 19:47:15 2017 Use FileNetLogObserver in cronet (iOS). This replaces use of the deprecated WriteToFileNetLogObserver. It has the advantage of moving file I/O off the calling thread. This is a re-land of https://chromium-review.googlesource.com/c/564341/, with fixes. Bug: 716570 Change-Id: I64ca0b05c5b6bce92eb1a28b1a77984f12fe9d6c Reviewed-on: https://chromium-review.googlesource.com/567325 Commit-Queue: Misha Efimov <mef@chromium.org> Reviewed-by: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#486064} [modify] https://crrev.com/a33615a8760266c7ca997d866790ce089382809f/components/cronet/ios/cronet_environment.h [modify] https://crrev.com/a33615a8760266c7ca997d866790ce089382809f/components/cronet/ios/cronet_environment.mm [modify] https://crrev.com/a33615a8760266c7ca997d866790ce089382809f/components/cronet/ios/test/cronet_netlog_test.mm
,
Jul 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f98299efa84a1affe3333525ef008a0805bf4019 commit f98299efa84a1affe3333525ef008a0805bf4019 Author: Eric Roman <eroman@chromium.org> Date: Thu Jul 13 03:40:58 2017 Delete WriteToFileNetLogObserver. It is no longer needed as consumers of WriteToFileNetLogObserver have been switched over to FileNetLogObserver. Bug: 716570 Change-Id: Ia70e04aebc8560f2799a84c8c691538c5beb5db5 Reviewed-on: https://chromium-review.googlesource.com/565450 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#486259} [modify] https://crrev.com/f98299efa84a1affe3333525ef008a0805bf4019/chrome/browser/ui/webui/net_internals/net_internals_ui.cc [modify] https://crrev.com/f98299efa84a1affe3333525ef008a0805bf4019/net/BUILD.gn [modify] https://crrev.com/f98299efa84a1affe3333525ef008a0805bf4019/net/log/net_log_util.cc [delete] https://crrev.com/da0d3ffe8defa1ebb38248fa6ee5eab50d469e43/net/log/write_to_file_net_log_observer.cc [delete] https://crrev.com/da0d3ffe8defa1ebb38248fa6ee5eab50d469e43/net/log/write_to_file_net_log_observer.h [delete] https://crrev.com/da0d3ffe8defa1ebb38248fa6ee5eab50d469e43/net/log/write_to_file_net_log_observer_unittest.cc
,
Jul 13 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Jul 8 2017