New issue
Advanced search Search tips

Issue 716569 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

webkit_tests failing on chromium.webkit/WebKit Android (Nexus4)

Project Member Reported by rogerta@chromium.org, Apr 28 2017

Issue description

webkit_tests failing on chromium.webkit/WebKit Android (Nexus4)

Builders failed on: 
- WebKit Android (Nexus4): 
  https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29


From log:
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.webkit%2FWebKit_Android__Nexus4_%2F64301%2F%2B%2Frecipes%2Fsteps%2Fwebkit_tests%2F0%2Fstdout

-------------------------------- 8< --------------------------------
08:43:12.220 32437 worker/2 fast/block/float/centered-float-avoidance-complexity.html output stderr lines:
08:43:12.220 32437   [11712:11712:0428/154310.323728:592784835:ERROR:shell_android.cc(72)] Not implemented reached in void content::Shell::PlatformSetTitle(const string16&): Floats and BFCs with horizontal margins
08:43:12.257 32437 "/b/c/b/WebKit_Android__Nexus4_/src/out/Release/image_diff --diff /tmp/tmpLG0DGd/actual.png /tmp/tmpLG0DGd/expected.png /tmp/tmpLG0DGd/diff.png" took 0.04s
08:43:12.258 30572 [454/1057] fast/block/float/centered-float-avoidance-complexity.html failed unexpectedly (image diff)
08:43:12.257 32437 worker/2 fast/block/float/centered-float-avoidance-complexity.html failed:
08:43:12.257 32437 worker/2  image diff

...

fast/block/float/centered-float-avoidance-complexity.html [ Failure Failure Crash Failure ]
fast/css3-text/css3-text-decoration/text-decoration-style-inherit.html [ Failure ]
fast/events/reveal-link-when-focused.html [ Failure Crash Failure Crash ]
fast/overflow/position-fixed-transform-clipping.html [ Failure ]
fast/table/border-collapsing/004.html [ Failure Crash Crash Crash ]
tables/mozilla/bugs/ bug2479 -3.html [ Failure Crash Failure Crash ]
tables/mozilla/bugs/ bug2479 -4.html [ Failure Failure Crash Failure ]
tables/mozilla/core/bloomberg.html [ Failure ]
tables/mozilla_expected_failures/bugs/ bug1055 -2.html [ Failure ]
tables/mozilla_expected_failures/bugs/ bug2479 -5.html [ Failure ]
-------------------------------- 8< --------------------------------

It seems this method should not be called on Android:

//content/shell/browser/shell_android.cc:
void Shell::PlatformSetTitle(const base::string16& title) {
  NOTIMPLEMENTED() << ": " << title;
}

 
Components: Blink>Layout>Scrollbars
Labels: -Sheriff-Chromium OS-Android
Owner: skobes@chromium.org
Status: Assigned (was: Available)
First build that shows the error:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/64282

Link showing difference in image has to do with scroll bar:
https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Android__Nexus4_/64308/layout-test-results/fast/block/float/centered-float-avoidance-complexity-diffs.html

Suspected change:
https://chromium.googlesource.com/chromium/src/+/697a467f819ce09da5209a3df13b8b92f33e35a4

Comment 2 by skobes@chromium.org, May 23 2017

Labels: Pri-2 Type-Bug
Status: Started (was: Assigned)
Note, I marked these tests failing in r468144 (which bugdroid for some reason failed to tag here).  Looking into the diffs now.

Comment 3 by skobes@chromium.org, May 23 2017

It looks like these are all passing now, except for tables/mozilla/core/bloomberg.html which has some image scaling artifacts.
Project Member

Comment 4 by bugdroid1@chromium.org, May 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2148aa92d80a764dbeb4d3ce8d99ed41b1f2bac7

commit 2148aa92d80a764dbeb4d3ce8d99ed41b1f2bac7
Author: Steve Kobes <skobes@chromium.org>
Date: Fri May 26 15:15:39 2017

Update expectations for some tests that now pass.

These started failing on Android after r467855 (changing scrollbar show logic),
but they seem to be passing now, except for one that needs a rebaseline for
unrelated reasons (image scaling artifacts).

Bug:  716569 
Change-Id: I4187ca03975dfa871bb68e97cd9be00b04687dbc
Reviewed-on: https://chromium-review.googlesource.com/513437
Commit-Queue: David Bokan <bokan@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475005}
[modify] https://crrev.com/2148aa92d80a764dbeb4d3ce8d99ed41b1f2bac7/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/2148aa92d80a764dbeb4d3ce8d99ed41b1f2bac7/third_party/WebKit/LayoutTests/platform/android/tables/mozilla/core/bloomberg-expected.png

Comment 5 by skobes@chromium.org, May 26 2017

Status: Fixed (was: Started)
WebKit Android (Nexus4) remains green after r475005:

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/65281

Sign in to add a comment