New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 716507 link

Starred by 2 users
Status: Available
Owner: ----
Cc:
█ robhogan@chromium.org
wangxianzhu@chromium.org
dgro...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Wrong width of row-spanning table cell sharing wider collapsed borders with cells in rows other than the first

Project Member Reported by wangxianzhu@chromium.org, Apr 28 2017 
Test: jsbin.com/tapacid

Expected: The blue squares should not be covered by any collapsed borders.
Actual: Blue square A is partly covered by the green border.

Other browsers:
Firefox: OK
IE: OK
Safari: Fail

To fix the issue, we may need to calculate collapsed borders per grid instead of per cell to support multiple border segments with different width at each side of a cell. LayoutTableCell::border(Left|Right|Top|Bottom) need to return the maximum width of the collapsed borders in each side.

Comment 1 by wangxianzhu@chromium.org, May 14 2017

Owner: wangxianzhu@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, May 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f8c4033754c54add7fbc1ce521116d88cda5c410

commit f8c4033754c54add7fbc1ce521116d88cda5c410
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Mon May 15 22:55:52 2017

Extract LayoutTableSection::CellStruct to a standalone class TableGridCell

This is a refactory before implmentation of grid based collapsed
borders.

BUG=716507,2902
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2884533002
Cr-Commit-Position: refs/heads/master@{#471936}

[modify] https://crrev.com/f8c4033754c54add7fbc1ce521116d88cda5c410/third_party/WebKit/Source/core/layout/BUILD.gn
[modify] https://crrev.com/f8c4033754c54add7fbc1ce521116d88cda5c410/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp
[modify] https://crrev.com/f8c4033754c54add7fbc1ce521116d88cda5c410/third_party/WebKit/Source/core/layout/LayoutTableSection.h
[add] https://crrev.com/f8c4033754c54add7fbc1ce521116d88cda5c410/third_party/WebKit/Source/core/layout/TableGridCell.cpp
[add] https://crrev.com/f8c4033754c54add7fbc1ce521116d88cda5c410/third_party/WebKit/Source/core/layout/TableGridCell.h
[modify] https://crrev.com/f8c4033754c54add7fbc1ce521116d88cda5c410/third_party/WebKit/Source/core/layout/TableLayoutAlgorithmAuto.cpp
[modify] https://crrev.com/f8c4033754c54add7fbc1ce521116d88cda5c410/third_party/WebKit/Source/core/paint/TableSectionPainter.cpp

Comment 3 by wangxianzhu@chromium.org, Jun 25 2017

Cc: wangxianzhu@chromium.org
Owner: ----
Status: Available (was: Started)
I'm unlikely to work on grid-cell-based collapsed borders soon.
Project Member

Comment 4 by sheriffbot@chromium.org, Jun 26 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by dgro...@chromium.org, Jun 26 2018

Status: Available (was: Untriaged)
►

Sign in to add a comment