ResizeObserver should disconnect/unobserve the MediaElement? |
||||||
Issue descriptionIIUC, we're leaking the resize observer because it's going to be kept in the MediaElement's observer map forever. Assigning to Tommy to confirm and fix.
,
May 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/11539c86d2827abf795281446643991e6705790a commit 11539c86d2827abf795281446643991e6705790a Author: avayvod <avayvod@chromium.org> Date: Mon May 08 18:54:33 2017 [Media, Controls] Cleanup resize observer before dereferencing. BUG= 716506 TEST=existing tests Review-Url: https://codereview.chromium.org/2863713002 Cr-Commit-Position: refs/heads/master@{#470066} [modify] https://crrev.com/11539c86d2827abf795281446643991e6705790a/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp
,
May 8 2017
,
May 8 2017
,
May 9 2017
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2a8571682829971095890c2c5269884ddc2d29cc commit 2a8571682829971095890c2c5269884ddc2d29cc Author: Anton Vayvod <avayvod@google.com> Date: Tue May 09 19:43:42 2017 [Media, Controls] Cleanup resize observer before dereferencing. BUG= 716506 TEST=existing tests Review-Url: https://codereview.chromium.org/2863713002 Cr-Commit-Position: refs/heads/master@{#470066} (cherry picked from commit 11539c86d2827abf795281446643991e6705790a) Review-Url: https://codereview.chromium.org/2865373002 . Cr-Commit-Position: refs/branch-heads/3071@{#486} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/2a8571682829971095890c2c5269884ddc2d29cc/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp
,
May 16 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by avayvod@chromium.org
, Apr 28 2017