New issue
Advanced search Search tips

Issue 716494 link

Starred by 2 users
Status: Fixed
Owner:
mthiesse@chromium.org
Closed: May 2017
Cc:
peconn@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

ChromeTabbedActivity2 supports_video_persistence() was accidentally removed from M59

Project Member Reported by mthiesse@chromium.org, Apr 28 2017 
I accidentally removed the supports_video_persistence flag from CTA2 in the AndroidManifest in this CL: https://codereview.chromium.org/2825133002

It was added back here in https://codereview.chromium.org/2851433002/, but needs to be merged back to M59.

Comment 1 by mthiesse@chromium.org, Apr 28 2017

Labels: Merge-Request-59
Would like to merge back https://codereview.chromium.org/2851433002/, which was submitted without a BUG id.
Project Member

Comment 2 by sheriffbot@chromium.org, Apr 29 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 3 by bugdroid1@chromium.org, May 1 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db5f19b8f3130dbd7e07afe0948de81ec7e35cb7

commit db5f19b8f3130dbd7e07afe0948de81ec7e35cb7
Author: Michael Thiessen <mthiesse@chromium.org>
Date: Mon May 01 14:53:35 2017

📺 Add supports_video_persistence back to ChromeTabbedActivity2.

I think it was accidentally removed in
https://codereview.chromium.org/2825133002.

BUG= 716494 

Review-Url: https://codereview.chromium.org/2851433002
Cr-Commit-Position: refs/heads/master@{#467628}
(cherry picked from commit e3ff7043bfaebcdf27b03f4cbf2a28ea7ae83e83)

Review-Url: https://codereview.chromium.org/2851173003 .
Cr-Commit-Position: refs/branch-heads/3071@{#320}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/db5f19b8f3130dbd7e07afe0948de81ec7e35cb7/chrome/android/java/AndroidManifest.xml

Comment 4 by mthiesse@chromium.org, May 1 2017

Status: Fixed (was: Available)

Comment 5 by peconn@chromium.org, May 3 2017 

 Issue 716010  has been merged into this issue.
►

Sign in to add a comment