Very similar to bug 586194 , this is to convert SessionStorage to using layered mojo services. This should hopefully be easy because it would reuse work from the LocalStorage reimplementation (and SS already uses LevelDB).
Appending component Internals>Services to S13N projects and changing the Type (for tracking sake) to Type=Task.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ab3de2ef31b1bcf76140c6ba61fbc5514ebf7749 commit ab3de2ef31b1bcf76140c6ba61fbc5514ebf7749 Author: Daniel Murphy <dmurph@chromium.org> Date: Fri Nov 17 23:49:19 2017 [SessionStorage] Renderer piping & browser stubs for mojofication. This change adds a feature flag and the piping to hook up & run a mojo implementation of SessionStorage. Nothing is implemented yet and all calls trip a NOTREACHED - this is just the setup for the renderer side of the feature. Bug: 716490 Change-Id: Id3ad5cf3fa1e27bf7e5ef9369818d94a1a5364d3 Reviewed-on: https://chromium-review.googlesource.com/767287 Reviewed-by: Oliver Chang <ochang@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#517619} [modify] https://crrev.com/ab3de2ef31b1bcf76140c6ba61fbc5514ebf7749/content/browser/BUILD.gn [modify] https://crrev.com/ab3de2ef31b1bcf76140c6ba61fbc5514ebf7749/content/browser/dom_storage/dom_storage_context_wrapper.cc [modify] https://crrev.com/ab3de2ef31b1bcf76140c6ba61fbc5514ebf7749/content/browser/dom_storage/dom_storage_context_wrapper.h [modify] https://crrev.com/ab3de2ef31b1bcf76140c6ba61fbc5514ebf7749/content/browser/dom_storage/dom_storage_session.cc [modify] https://crrev.com/ab3de2ef31b1bcf76140c6ba61fbc5514ebf7749/content/browser/dom_storage/dom_storage_session.h [modify] https://crrev.com/ab3de2ef31b1bcf76140c6ba61fbc5514ebf7749/content/browser/dom_storage/local_storage_context_mojo.h [add] https://crrev.com/ab3de2ef31b1bcf76140c6ba61fbc5514ebf7749/content/browser/dom_storage/session_storage_context_mojo.cc [add] https://crrev.com/ab3de2ef31b1bcf76140c6ba61fbc5514ebf7749/content/browser/dom_storage/session_storage_context_mojo.h [modify] https://crrev.com/ab3de2ef31b1bcf76140c6ba61fbc5514ebf7749/content/browser/dom_storage/session_storage_namespace_impl.cc [modify] https://crrev.com/ab3de2ef31b1bcf76140c6ba61fbc5514ebf7749/content/browser/storage_partition_impl.cc [modify] https://crrev.com/ab3de2ef31b1bcf76140c6ba61fbc5514ebf7749/content/browser/storage_partition_impl.h [modify] https://crrev.com/ab3de2ef31b1bcf76140c6ba61fbc5514ebf7749/content/common/storage_partition_service.mojom [modify] https://crrev.com/ab3de2ef31b1bcf76140c6ba61fbc5514ebf7749/content/public/common/content_features.cc [modify] https://crrev.com/ab3de2ef31b1bcf76140c6ba61fbc5514ebf7749/content/public/common/content_features.h [modify] https://crrev.com/ab3de2ef31b1bcf76140c6ba61fbc5514ebf7749/content/renderer/BUILD.gn [modify] https://crrev.com/ab3de2ef31b1bcf76140c6ba61fbc5514ebf7749/content/renderer/dom_storage/local_storage_cached_area.cc [modify] https://crrev.com/ab3de2ef31b1bcf76140c6ba61fbc5514ebf7749/content/renderer/dom_storage/local_storage_cached_area.h [modify] https://crrev.com/ab3de2ef31b1bcf76140c6ba61fbc5514ebf7749/content/renderer/dom_storage/local_storage_cached_areas.cc [modify] https://crrev.com/ab3de2ef31b1bcf76140c6ba61fbc5514ebf7749/content/renderer/dom_storage/local_storage_cached_areas.h [modify] https://crrev.com/ab3de2ef31b1bcf76140c6ba61fbc5514ebf7749/content/renderer/dom_storage/mock_leveldb_wrapper.cc [modify] https://crrev.com/ab3de2ef31b1bcf76140c6ba61fbc5514ebf7749/content/renderer/dom_storage/mock_leveldb_wrapper.h [add] https://crrev.com/ab3de2ef31b1bcf76140c6ba61fbc5514ebf7749/content/renderer/dom_storage/session_storage_namespace.cc [add] https://crrev.com/ab3de2ef31b1bcf76140c6ba61fbc5514ebf7749/content/renderer/dom_storage/session_storage_namespace.h [modify] https://crrev.com/ab3de2ef31b1bcf76140c6ba61fbc5514ebf7749/content/renderer/render_view_impl.cc [modify] https://crrev.com/ab3de2ef31b1bcf76140c6ba61fbc5514ebf7749/content/renderer/render_view_impl.h [modify] https://crrev.com/ab3de2ef31b1bcf76140c6ba61fbc5514ebf7749/content/renderer/renderer_blink_platform_impl.cc [modify] https://crrev.com/ab3de2ef31b1bcf76140c6ba61fbc5514ebf7749/content/renderer/renderer_blink_platform_impl.h [modify] https://crrev.com/ab3de2ef31b1bcf76140c6ba61fbc5514ebf7749/third_party/WebKit/Source/modules/storage/StorageNamespaceController.cpp [modify] https://crrev.com/ab3de2ef31b1bcf76140c6ba61fbc5514ebf7749/third_party/WebKit/Source/platform/exported/Platform.cpp [modify] https://crrev.com/ab3de2ef31b1bcf76140c6ba61fbc5514ebf7749/third_party/WebKit/public/platform/Platform.h [modify] https://crrev.com/ab3de2ef31b1bcf76140c6ba61fbc5514ebf7749/third_party/WebKit/public/web/WebViewClient.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d64c6711acbf9c224cc0a7f84551541fd660223f commit d64c6711acbf9c224cc0a7f84551541fd660223f Author: Bruce Dawson <brucedawson@chromium.org> Date: Sat Nov 18 18:43:02 2017 Revert "[SessionStorage] Renderer piping & browser stubs for mojofication." This reverts commit ab3de2ef31b1bcf76140c6ba61fbc5514ebf7749. Reason for revert: ODR violation - content::SessionStorageNamespace already exists. Original change's description: > [SessionStorage] Renderer piping & browser stubs for mojofication. > > This change adds a feature flag and the piping to hook up & run a mojo > implementation of SessionStorage. Nothing is implemented yet and all > calls trip a NOTREACHED - this is just the setup for the renderer side > of the feature. > > Bug: 716490 > Change-Id: Id3ad5cf3fa1e27bf7e5ef9369818d94a1a5364d3 > Reviewed-on: https://chromium-review.googlesource.com/767287 > Reviewed-by: Oliver Chang <ochang@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > Commit-Queue: Daniel Murphy <dmurph@chromium.org> > Cr-Commit-Position: refs/heads/master@{#517619} TBR=dmurph@chromium.org,jam@chromium.org,mek@chromium.org,ochang@chromium.org Change-Id: I51f09c1bc483ec16e3ae038d9117523c788b9442 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 716490 Reviewed-on: https://chromium-review.googlesource.com/777411 Reviewed-by: Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#517718} [modify] https://crrev.com/d64c6711acbf9c224cc0a7f84551541fd660223f/content/browser/BUILD.gn [modify] https://crrev.com/d64c6711acbf9c224cc0a7f84551541fd660223f/content/browser/dom_storage/dom_storage_context_wrapper.cc [modify] https://crrev.com/d64c6711acbf9c224cc0a7f84551541fd660223f/content/browser/dom_storage/dom_storage_context_wrapper.h [modify] https://crrev.com/d64c6711acbf9c224cc0a7f84551541fd660223f/content/browser/dom_storage/dom_storage_session.cc [modify] https://crrev.com/d64c6711acbf9c224cc0a7f84551541fd660223f/content/browser/dom_storage/dom_storage_session.h [modify] https://crrev.com/d64c6711acbf9c224cc0a7f84551541fd660223f/content/browser/dom_storage/local_storage_context_mojo.h [delete] https://crrev.com/f67f96409dff7976661ce53d4e7a91a86930dc94/content/browser/dom_storage/session_storage_context_mojo.cc [delete] https://crrev.com/f67f96409dff7976661ce53d4e7a91a86930dc94/content/browser/dom_storage/session_storage_context_mojo.h [modify] https://crrev.com/d64c6711acbf9c224cc0a7f84551541fd660223f/content/browser/dom_storage/session_storage_namespace_impl.cc [modify] https://crrev.com/d64c6711acbf9c224cc0a7f84551541fd660223f/content/browser/storage_partition_impl.cc [modify] https://crrev.com/d64c6711acbf9c224cc0a7f84551541fd660223f/content/browser/storage_partition_impl.h [modify] https://crrev.com/d64c6711acbf9c224cc0a7f84551541fd660223f/content/common/storage_partition_service.mojom [modify] https://crrev.com/d64c6711acbf9c224cc0a7f84551541fd660223f/content/public/common/content_features.cc [modify] https://crrev.com/d64c6711acbf9c224cc0a7f84551541fd660223f/content/public/common/content_features.h [modify] https://crrev.com/d64c6711acbf9c224cc0a7f84551541fd660223f/content/renderer/BUILD.gn [modify] https://crrev.com/d64c6711acbf9c224cc0a7f84551541fd660223f/content/renderer/dom_storage/local_storage_cached_area.cc [modify] https://crrev.com/d64c6711acbf9c224cc0a7f84551541fd660223f/content/renderer/dom_storage/local_storage_cached_area.h [modify] https://crrev.com/d64c6711acbf9c224cc0a7f84551541fd660223f/content/renderer/dom_storage/local_storage_cached_areas.cc [modify] https://crrev.com/d64c6711acbf9c224cc0a7f84551541fd660223f/content/renderer/dom_storage/local_storage_cached_areas.h [modify] https://crrev.com/d64c6711acbf9c224cc0a7f84551541fd660223f/content/renderer/dom_storage/mock_leveldb_wrapper.cc [modify] https://crrev.com/d64c6711acbf9c224cc0a7f84551541fd660223f/content/renderer/dom_storage/mock_leveldb_wrapper.h [delete] https://crrev.com/f67f96409dff7976661ce53d4e7a91a86930dc94/content/renderer/dom_storage/session_storage_namespace.cc [delete] https://crrev.com/f67f96409dff7976661ce53d4e7a91a86930dc94/content/renderer/dom_storage/session_storage_namespace.h [modify] https://crrev.com/d64c6711acbf9c224cc0a7f84551541fd660223f/content/renderer/render_view_impl.cc [modify] https://crrev.com/d64c6711acbf9c224cc0a7f84551541fd660223f/content/renderer/render_view_impl.h [modify] https://crrev.com/d64c6711acbf9c224cc0a7f84551541fd660223f/content/renderer/renderer_blink_platform_impl.cc [modify] https://crrev.com/d64c6711acbf9c224cc0a7f84551541fd660223f/content/renderer/renderer_blink_platform_impl.h [modify] https://crrev.com/d64c6711acbf9c224cc0a7f84551541fd660223f/third_party/WebKit/Source/modules/storage/StorageNamespaceController.cpp [modify] https://crrev.com/d64c6711acbf9c224cc0a7f84551541fd660223f/third_party/WebKit/Source/platform/exported/Platform.cpp [modify] https://crrev.com/d64c6711acbf9c224cc0a7f84551541fd660223f/third_party/WebKit/public/platform/Platform.h [modify] https://crrev.com/d64c6711acbf9c224cc0a7f84551541fd660223f/third_party/WebKit/public/web/WebViewClient.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0ce6e2c320e05b2118684a87cc8a6e860414e8e5 commit 0ce6e2c320e05b2118684a87cc8a6e860414e8e5 Author: Daniel Murphy <dmurph@chromium.org> Date: Tue Nov 21 01:54:26 2017 Revert "Revert "[SessionStorage] Renderer piping & browser stubs for mojofication."" This reverts commit d64c6711acbf9c224cc0a7f84551541fd660223f. Reason for revert: Fixing ODR violation Original change's description: > Revert "[SessionStorage] Renderer piping & browser stubs for mojofication." > > This reverts commit ab3de2ef31b1bcf76140c6ba61fbc5514ebf7749. > > Reason for revert: ODR violation - content::SessionStorageNamespace already exists. > > Original change's description: > > [SessionStorage] Renderer piping & browser stubs for mojofication. > > > > This change adds a feature flag and the piping to hook up & run a mojo > > implementation of SessionStorage. Nothing is implemented yet and all > > calls trip a NOTREACHED - this is just the setup for the renderer side > > of the feature. > > > > Bug: 716490 > > Change-Id: Id3ad5cf3fa1e27bf7e5ef9369818d94a1a5364d3 > > Reviewed-on: https://chromium-review.googlesource.com/767287 > > Reviewed-by: Oliver Chang <ochang@chromium.org> > > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > > Commit-Queue: Daniel Murphy <dmurph@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#517619} > > TBR=dmurph@chromium.org,jam@chromium.org,mek@chromium.org,ochang@chromium.org > > Change-Id: I51f09c1bc483ec16e3ae038d9117523c788b9442 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 716490 > Reviewed-on: https://chromium-review.googlesource.com/777411 > Reviewed-by: Bruce Dawson <brucedawson@chromium.org> > Commit-Queue: Bruce Dawson <brucedawson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#517718} TBR=dmurph@chromium.org,jam@chromium.org,mek@chromium.org,brucedawson@chromium.org,ochang@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 716490 Change-Id: Ie4eef6ba886e4c9e145dfac4903cc679c7a35d34 Reviewed-on: https://chromium-review.googlesource.com/779500 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by: Bruce Dawson <brucedawson@chromium.org> Reviewed-by: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#518054} [modify] https://crrev.com/0ce6e2c320e05b2118684a87cc8a6e860414e8e5/content/browser/BUILD.gn [modify] https://crrev.com/0ce6e2c320e05b2118684a87cc8a6e860414e8e5/content/browser/dom_storage/dom_storage_context_wrapper.cc [modify] https://crrev.com/0ce6e2c320e05b2118684a87cc8a6e860414e8e5/content/browser/dom_storage/dom_storage_context_wrapper.h [modify] https://crrev.com/0ce6e2c320e05b2118684a87cc8a6e860414e8e5/content/browser/dom_storage/dom_storage_session.cc [modify] https://crrev.com/0ce6e2c320e05b2118684a87cc8a6e860414e8e5/content/browser/dom_storage/dom_storage_session.h [modify] https://crrev.com/0ce6e2c320e05b2118684a87cc8a6e860414e8e5/content/browser/dom_storage/local_storage_context_mojo.h [add] https://crrev.com/0ce6e2c320e05b2118684a87cc8a6e860414e8e5/content/browser/dom_storage/session_storage_context_mojo.cc [add] https://crrev.com/0ce6e2c320e05b2118684a87cc8a6e860414e8e5/content/browser/dom_storage/session_storage_context_mojo.h [modify] https://crrev.com/0ce6e2c320e05b2118684a87cc8a6e860414e8e5/content/browser/dom_storage/session_storage_namespace_impl.cc [modify] https://crrev.com/0ce6e2c320e05b2118684a87cc8a6e860414e8e5/content/browser/storage_partition_impl.cc [modify] https://crrev.com/0ce6e2c320e05b2118684a87cc8a6e860414e8e5/content/browser/storage_partition_impl.h [modify] https://crrev.com/0ce6e2c320e05b2118684a87cc8a6e860414e8e5/content/common/storage_partition_service.mojom [modify] https://crrev.com/0ce6e2c320e05b2118684a87cc8a6e860414e8e5/content/public/common/content_features.cc [modify] https://crrev.com/0ce6e2c320e05b2118684a87cc8a6e860414e8e5/content/public/common/content_features.h [modify] https://crrev.com/0ce6e2c320e05b2118684a87cc8a6e860414e8e5/content/renderer/BUILD.gn [modify] https://crrev.com/0ce6e2c320e05b2118684a87cc8a6e860414e8e5/content/renderer/dom_storage/local_storage_cached_area.cc [modify] https://crrev.com/0ce6e2c320e05b2118684a87cc8a6e860414e8e5/content/renderer/dom_storage/local_storage_cached_area.h [modify] https://crrev.com/0ce6e2c320e05b2118684a87cc8a6e860414e8e5/content/renderer/dom_storage/local_storage_cached_areas.cc [modify] https://crrev.com/0ce6e2c320e05b2118684a87cc8a6e860414e8e5/content/renderer/dom_storage/local_storage_cached_areas.h [modify] https://crrev.com/0ce6e2c320e05b2118684a87cc8a6e860414e8e5/content/renderer/dom_storage/mock_leveldb_wrapper.cc [modify] https://crrev.com/0ce6e2c320e05b2118684a87cc8a6e860414e8e5/content/renderer/dom_storage/mock_leveldb_wrapper.h [add] https://crrev.com/0ce6e2c320e05b2118684a87cc8a6e860414e8e5/content/renderer/dom_storage/session_web_storage_namespace_impl.cc [add] https://crrev.com/0ce6e2c320e05b2118684a87cc8a6e860414e8e5/content/renderer/dom_storage/session_web_storage_namespace_impl.h [modify] https://crrev.com/0ce6e2c320e05b2118684a87cc8a6e860414e8e5/content/renderer/render_view_impl.cc [modify] https://crrev.com/0ce6e2c320e05b2118684a87cc8a6e860414e8e5/content/renderer/render_view_impl.h [modify] https://crrev.com/0ce6e2c320e05b2118684a87cc8a6e860414e8e5/content/renderer/renderer_blink_platform_impl.cc [modify] https://crrev.com/0ce6e2c320e05b2118684a87cc8a6e860414e8e5/content/renderer/renderer_blink_platform_impl.h [modify] https://crrev.com/0ce6e2c320e05b2118684a87cc8a6e860414e8e5/third_party/WebKit/Source/modules/storage/StorageNamespaceController.cpp [modify] https://crrev.com/0ce6e2c320e05b2118684a87cc8a6e860414e8e5/third_party/WebKit/Source/platform/exported/Platform.cpp [modify] https://crrev.com/0ce6e2c320e05b2118684a87cc8a6e860414e8e5/third_party/WebKit/public/platform/Platform.h [modify] https://crrev.com/0ce6e2c320e05b2118684a87cc8a6e860414e8e5/third_party/WebKit/public/web/WebViewClient.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3d39c5429cc35faeba40965585371bd50f79b759 commit 3d39c5429cc35faeba40965585371bd50f79b759 Author: Daniel Murphy <dmurph@chromium.org> Date: Tue Nov 21 03:24:07 2017 [LevelDB] Added CopyPrefixed operation & prefix changing in wrapper 1. Adds CopyPrefixed operation to leveldb.mojom which copies all data from a source prefix to a destination prefix. 2. Adds a ForkPrefix operation to LevelDBWrapperImpl, which uses the above operation to copy all data (and cached data) to a new LevelDBWrapperImpl at a new prefix. The is a prerequisite to servicification of SessionStorage, which needs a way to change the prefix of a wrapper after a shallow copy has occurred. Bug: 716490 Change-Id: I2ee7f46d2605614ff384f18126933ff13b4a8aed Reviewed-on: https://chromium-review.googlesource.com/736878 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by: Elliot Glaysher <erg@chromium.org> Cr-Commit-Position: refs/heads/master@{#518074} [modify] https://crrev.com/3d39c5429cc35faeba40965585371bd50f79b759/components/leveldb/leveldb_database_impl.cc [modify] https://crrev.com/3d39c5429cc35faeba40965585371bd50f79b759/components/leveldb/leveldb_database_impl.h [modify] https://crrev.com/3d39c5429cc35faeba40965585371bd50f79b759/components/leveldb/leveldb_service_unittest.cc [modify] https://crrev.com/3d39c5429cc35faeba40965585371bd50f79b759/components/leveldb/public/interfaces/leveldb.mojom [modify] https://crrev.com/3d39c5429cc35faeba40965585371bd50f79b759/content/browser/dom_storage/local_storage_context_mojo.cc [modify] https://crrev.com/3d39c5429cc35faeba40965585371bd50f79b759/content/browser/leveldb_wrapper_impl.cc [modify] https://crrev.com/3d39c5429cc35faeba40965585371bd50f79b759/content/browser/leveldb_wrapper_impl.h [modify] https://crrev.com/3d39c5429cc35faeba40965585371bd50f79b759/content/browser/leveldb_wrapper_impl_unittest.cc [modify] https://crrev.com/3d39c5429cc35faeba40965585371bd50f79b759/content/test/fake_leveldb_database.cc [modify] https://crrev.com/3d39c5429cc35faeba40965585371bd50f79b759/content/test/fake_leveldb_database.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/21937bc7a31238f566fd4fc1ef1685cdd2518748 commit 21937bc7a31238f566fd4fc1ef1685cdd2518748 Author: Daniel Murphy <dmurph@chromium.org> Date: Thu Feb 08 00:57:43 2018 [SessionStorageMojo] Updating piping for better sequences and lifetimes. Bug: 716490 Change-Id: Ief73b6f0e9b64290a333bd87a1ac213740eac168 Reviewed-on: https://chromium-review.googlesource.com/889411 Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#535226} [modify] https://crrev.com/21937bc7a31238f566fd4fc1ef1685cdd2518748/content/browser/dom_storage/dom_storage_context_impl.cc [modify] https://crrev.com/21937bc7a31238f566fd4fc1ef1685cdd2518748/content/browser/dom_storage/dom_storage_context_wrapper.cc [modify] https://crrev.com/21937bc7a31238f566fd4fc1ef1685cdd2518748/content/browser/dom_storage/dom_storage_context_wrapper.h [modify] https://crrev.com/21937bc7a31238f566fd4fc1ef1685cdd2518748/content/browser/dom_storage/dom_storage_session.cc [modify] https://crrev.com/21937bc7a31238f566fd4fc1ef1685cdd2518748/content/browser/dom_storage/dom_storage_session.h [modify] https://crrev.com/21937bc7a31238f566fd4fc1ef1685cdd2518748/content/browser/dom_storage/local_storage_context_mojo.cc [modify] https://crrev.com/21937bc7a31238f566fd4fc1ef1685cdd2518748/content/browser/dom_storage/local_storage_context_mojo.h [modify] https://crrev.com/21937bc7a31238f566fd4fc1ef1685cdd2518748/content/browser/dom_storage/session_storage_context_mojo.cc [modify] https://crrev.com/21937bc7a31238f566fd4fc1ef1685cdd2518748/content/browser/dom_storage/session_storage_context_mojo.h [modify] https://crrev.com/21937bc7a31238f566fd4fc1ef1685cdd2518748/content/browser/dom_storage/session_storage_namespace_impl.cc [modify] https://crrev.com/21937bc7a31238f566fd4fc1ef1685cdd2518748/content/browser/dom_storage/session_storage_namespace_impl.h [modify] https://crrev.com/21937bc7a31238f566fd4fc1ef1685cdd2518748/content/public/browser/dom_storage_context.h [modify] https://crrev.com/21937bc7a31238f566fd4fc1ef1685cdd2518748/content/renderer/dom_storage/local_storage_cached_area.cc [modify] https://crrev.com/21937bc7a31238f566fd4fc1ef1685cdd2518748/content/renderer/dom_storage/local_storage_cached_area.h [modify] https://crrev.com/21937bc7a31238f566fd4fc1ef1685cdd2518748/content/renderer/dom_storage/local_storage_cached_area_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e3eec92c21746c6b98dd78de4b91ed4bd9a5a145 commit e3eec92c21746c6b98dd78de4b91ed4bd9a5a145 Author: Daniel Murphy <dmurph@chromium.org> Date: Fri Feb 23 19:09:15 2018 [SessionStorage] Minting cloned namespace IDs from source renderer For the mojo version of session storage, the 'cloning' of namespaces has to to be called on the same mojo pipe as all session storage data operations. This patch allows that to happen by letting the source renderer mint the new namespace ID (and thus allowing it to call 'clone' with that ID). Bug: 716490 Change-Id: I7d1e20c7b1387e9caeab868217cf25c7a0119342 Reviewed-on: https://chromium-review.googlesource.com/910109 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#538846} [modify] https://crrev.com/e3eec92c21746c6b98dd78de4b91ed4bd9a5a145/content/browser/dom_storage/dom_storage_context_impl.cc [modify] https://crrev.com/e3eec92c21746c6b98dd78de4b91ed4bd9a5a145/content/browser/dom_storage/dom_storage_context_impl.h [modify] https://crrev.com/e3eec92c21746c6b98dd78de4b91ed4bd9a5a145/content/browser/dom_storage/dom_storage_context_wrapper.cc [modify] https://crrev.com/e3eec92c21746c6b98dd78de4b91ed4bd9a5a145/content/browser/dom_storage/dom_storage_context_wrapper.h [modify] https://crrev.com/e3eec92c21746c6b98dd78de4b91ed4bd9a5a145/content/browser/dom_storage/dom_storage_session.cc [modify] https://crrev.com/e3eec92c21746c6b98dd78de4b91ed4bd9a5a145/content/browser/dom_storage/dom_storage_session.h [modify] https://crrev.com/e3eec92c21746c6b98dd78de4b91ed4bd9a5a145/content/browser/dom_storage/session_storage_context_mojo.cc [modify] https://crrev.com/e3eec92c21746c6b98dd78de4b91ed4bd9a5a145/content/browser/dom_storage/session_storage_context_mojo.h [modify] https://crrev.com/e3eec92c21746c6b98dd78de4b91ed4bd9a5a145/content/browser/dom_storage/session_storage_namespace_impl.cc [modify] https://crrev.com/e3eec92c21746c6b98dd78de4b91ed4bd9a5a145/content/browser/dom_storage/session_storage_namespace_impl.h [modify] https://crrev.com/e3eec92c21746c6b98dd78de4b91ed4bd9a5a145/content/browser/frame_host/render_frame_host_impl.cc [modify] https://crrev.com/e3eec92c21746c6b98dd78de4b91ed4bd9a5a145/content/browser/storage_partition_impl.cc [modify] https://crrev.com/e3eec92c21746c6b98dd78de4b91ed4bd9a5a145/content/browser/storage_partition_impl.h [modify] https://crrev.com/e3eec92c21746c6b98dd78de4b91ed4bd9a5a145/content/common/BUILD.gn [add] https://crrev.com/e3eec92c21746c6b98dd78de4b91ed4bd9a5a145/content/common/dom_storage/dom_storage_namespace_ids.cc [add] https://crrev.com/e3eec92c21746c6b98dd78de4b91ed4bd9a5a145/content/common/dom_storage/dom_storage_namespace_ids.h [modify] https://crrev.com/e3eec92c21746c6b98dd78de4b91ed4bd9a5a145/content/common/frame.mojom [modify] https://crrev.com/e3eec92c21746c6b98dd78de4b91ed4bd9a5a145/content/common/storage_partition_service.mojom [modify] https://crrev.com/e3eec92c21746c6b98dd78de4b91ed4bd9a5a145/content/renderer/dom_storage/local_storage_cached_area.cc [modify] https://crrev.com/e3eec92c21746c6b98dd78de4b91ed4bd9a5a145/content/renderer/dom_storage/local_storage_cached_area.h [modify] https://crrev.com/e3eec92c21746c6b98dd78de4b91ed4bd9a5a145/content/renderer/dom_storage/local_storage_cached_areas.cc [modify] https://crrev.com/e3eec92c21746c6b98dd78de4b91ed4bd9a5a145/content/renderer/dom_storage/local_storage_cached_areas.h [modify] https://crrev.com/e3eec92c21746c6b98dd78de4b91ed4bd9a5a145/content/renderer/dom_storage/mock_leveldb_wrapper.cc [modify] https://crrev.com/e3eec92c21746c6b98dd78de4b91ed4bd9a5a145/content/renderer/dom_storage/mock_leveldb_wrapper.h [modify] https://crrev.com/e3eec92c21746c6b98dd78de4b91ed4bd9a5a145/content/renderer/render_view_impl.cc [modify] https://crrev.com/e3eec92c21746c6b98dd78de4b91ed4bd9a5a145/content/renderer/renderer_blink_platform_impl.cc [modify] https://crrev.com/e3eec92c21746c6b98dd78de4b91ed4bd9a5a145/content/renderer/renderer_blink_platform_impl.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c1f6e69990d95139fc114fb47dd7f2e55be1967a commit c1f6e69990d95139fc114fb47dd7f2e55be1967a Author: Daniel Murphy <dmurph@chromium.org> Date: Thu Mar 29 00:28:28 2018 [SessionStorage] Fixed mojo session storage change events. Bug: 716490 Change-Id: Ia9f62a49145183f348081a1aa28ae8d0acbacf35 Reviewed-on: https://chromium-review.googlesource.com/985245 Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#546674} [modify] https://crrev.com/c1f6e69990d95139fc114fb47dd7f2e55be1967a/content/renderer/dom_storage/DEPS [modify] https://crrev.com/c1f6e69990d95139fc114fb47dd7f2e55be1967a/content/renderer/dom_storage/local_storage_cached_area.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/02b843382aa35ac4b4eb51b968a7188b63e32f68 commit 02b843382aa35ac4b4eb51b968a7188b63e32f68 Author: Daniel Murphy <dmurph@chromium.org> Date: Tue Apr 03 03:48:47 2018 [LevelDBWrapper] Allow Observers to be managed externally. This change is necessary for mojo'd SessionStorage to manage observers for shallow copying. Bug: 716490 Change-Id: I5a899be566327decc3a447fe56b72bfba735ffd6 Reviewed-on: https://chromium-review.googlesource.com/984859 Reviewed-by: Ken Rockot <rockot@chromium.org> Reviewed-by: Oliver Chang <ochang@chromium.org> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#547619} [modify] https://crrev.com/02b843382aa35ac4b4eb51b968a7188b63e32f68/content/browser/leveldb_wrapper_impl.cc [modify] https://crrev.com/02b843382aa35ac4b4eb51b968a7188b63e32f68/content/browser/leveldb_wrapper_impl.h [modify] https://crrev.com/02b843382aa35ac4b4eb51b968a7188b63e32f68/content/common/leveldb_wrapper.mojom [modify] https://crrev.com/02b843382aa35ac4b4eb51b968a7188b63e32f68/mojo/public/cpp/bindings/associated_interface_ptr.h [modify] https://crrev.com/02b843382aa35ac4b4eb51b968a7188b63e32f68/mojo/public/cpp/bindings/interface_ptr_set.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/df60c65e1b71b142788e5fe384261ee8e5e75bd3 commit df60c65e1b71b142788e5fe384261ee8e5e75bd3 Author: Daniel Murphy <dmurph@chromium.org> Date: Thu Apr 12 21:22:08 2018 [SessionStorage] Remove unnecessary DomStorageSession class and avoid UAF Bug: 716490 Change-Id: I94e6faf11937273273d1e3e48b661a5fe6c700b7 Reviewed-on: https://chromium-review.googlesource.com/985232 Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#550364} [modify] https://crrev.com/df60c65e1b71b142788e5fe384261ee8e5e75bd3/content/browser/BUILD.gn [modify] https://crrev.com/df60c65e1b71b142788e5fe384261ee8e5e75bd3/content/browser/dom_storage/dom_storage_context_wrapper.cc [modify] https://crrev.com/df60c65e1b71b142788e5fe384261ee8e5e75bd3/content/browser/dom_storage/dom_storage_context_wrapper.h [delete] https://crrev.com/7bc83d1f4245a435eb6246d8b36b111aa1cf19eb/content/browser/dom_storage/dom_storage_session.cc [delete] https://crrev.com/7bc83d1f4245a435eb6246d8b36b111aa1cf19eb/content/browser/dom_storage/dom_storage_session.h [modify] https://crrev.com/df60c65e1b71b142788e5fe384261ee8e5e75bd3/content/browser/dom_storage/session_storage_context_mojo.cc [modify] https://crrev.com/df60c65e1b71b142788e5fe384261ee8e5e75bd3/content/browser/dom_storage/session_storage_context_mojo.h [modify] https://crrev.com/df60c65e1b71b142788e5fe384261ee8e5e75bd3/content/browser/dom_storage/session_storage_namespace_impl.cc [modify] https://crrev.com/df60c65e1b71b142788e5fe384261ee8e5e75bd3/content/browser/dom_storage/session_storage_namespace_impl.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dab0c207000c39a89353fcd4b15a9736aa58b84b commit dab0c207000c39a89353fcd4b15a9736aa58b84b Author: Daniel Murphy <dmurph@chromium.org> Date: Fri Apr 13 01:09:40 2018 [SessionStorage] Metadata parsing and writing for mojo version. Bug: 716490 Change-Id: If2b0672af149abf44dd475a2196e7b727cb450a7 Reviewed-on: https://chromium-review.googlesource.com/986880 Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#550454} [modify] https://crrev.com/dab0c207000c39a89353fcd4b15a9736aa58b84b/components/services/leveldb/public/cpp/util.cc [modify] https://crrev.com/dab0c207000c39a89353fcd4b15a9736aa58b84b/components/services/leveldb/public/cpp/util.h [modify] https://crrev.com/dab0c207000c39a89353fcd4b15a9736aa58b84b/content/browser/BUILD.gn [add] https://crrev.com/dab0c207000c39a89353fcd4b15a9736aa58b84b/content/browser/dom_storage/session_storage_metadata.cc [add] https://crrev.com/dab0c207000c39a89353fcd4b15a9736aa58b84b/content/browser/dom_storage/session_storage_metadata.h [add] https://crrev.com/dab0c207000c39a89353fcd4b15a9736aa58b84b/content/browser/dom_storage/session_storage_metadata_unittest.cc [modify] https://crrev.com/dab0c207000c39a89353fcd4b15a9736aa58b84b/content/test/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b979f2c889c665d934a5d5aed2848adff6acb6d4 commit b979f2c889c665d934a5d5aed2848adff6acb6d4 Author: Daniel Murphy <dmurph@chromium.org> Date: Fri Apr 13 22:40:37 2018 [SessionStorageS13N] Data map & tests Bug: 716490 Change-Id: I990f15d48f1556464d5558e2d8398f6b0c32f250 Reviewed-on: https://chromium-review.googlesource.com/1008824 Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#550767} [modify] https://crrev.com/b979f2c889c665d934a5d5aed2848adff6acb6d4/content/browser/BUILD.gn [add] https://crrev.com/b979f2c889c665d934a5d5aed2848adff6acb6d4/content/browser/dom_storage/session_storage_data_map.cc [add] https://crrev.com/b979f2c889c665d934a5d5aed2848adff6acb6d4/content/browser/dom_storage/session_storage_data_map.h [add] https://crrev.com/b979f2c889c665d934a5d5aed2848adff6acb6d4/content/browser/dom_storage/session_storage_data_map_unittest.cc [modify] https://crrev.com/b979f2c889c665d934a5d5aed2848adff6acb6d4/content/browser/dom_storage/session_storage_metadata.h [modify] https://crrev.com/b979f2c889c665d934a5d5aed2848adff6acb6d4/content/test/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f93971923f4c999e61bbdb91bbc6a7aeecffcef3 commit f93971923f4c999e61bbdb91bbc6a7aeecffcef3 Author: Daniel Murphy <dmurph@chromium.org> Date: Sat Apr 14 00:27:23 2018 [SessionStorageS13N] Fixed possible double-open of namespace in renderer. Bug: 716490 Change-Id: Ia7b81f19e365b8fc2385ee1bbf843fa5c63a051b Reviewed-on: https://chromium-review.googlesource.com/1011560 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#550829} [modify] https://crrev.com/f93971923f4c999e61bbdb91bbc6a7aeecffcef3/content/renderer/dom_storage/local_storage_cached_areas.cc [modify] https://crrev.com/f93971923f4c999e61bbdb91bbc6a7aeecffcef3/content/renderer/dom_storage/local_storage_cached_areas_unittest.cc [modify] https://crrev.com/f93971923f4c999e61bbdb91bbc6a7aeecffcef3/content/renderer/dom_storage/mock_leveldb_wrapper.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6558385bba1d80b80f641f9b73cfb214d1e771a8 commit 6558385bba1d80b80f641f9b73cfb214d1e771a8 Author: Mostyn Bramley-Moore <mostynb@vewd.com> Date: Mon Apr 16 16:38:08 2018 [jumbo] avoid 'declaration shadows a variable' warnings CL https://chromium-review.googlesource.com/c/chromium/src/+/1008824 added two consts inside SessionStorageDataMap::GetOptions() that shadow existing consts and generate warnigs in jumbo builds. These consts were only used once each, so we may as well just use the values directly. TBR=dmurph@chromium.org Bug: 716490 Change-Id: I09505a9df50ef6d3cc2bc002254027cd791cdcdf Reviewed-on: https://chromium-review.googlesource.com/1013458 Reviewed-by: Daniel Bratell <bratell@opera.com> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#551005} [modify] https://crrev.com/6558385bba1d80b80f641f9b73cfb214d1e771a8/content/browser/dom_storage/session_storage_data_map.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f665b54282aee234ed8e5c9e82a94e1fd3c6aec7 commit f665b54282aee234ed8e5c9e82a94e1fd3c6aec7 Author: Daniel Murphy <dmurph@chromium.org> Date: Tue Apr 24 21:35:28 2018 [SessionStorageS13N] Custom LevelDBWrapper implementation for cloning Adds the SessionStorageLevelDBWrapper class, which works with the SessionStorageMetadata and SessionStorageDataMap classes to support shallow cloning for SessionStorage data maps. TBR-ing jam for content/browser/BUILD.gn TBR: jam@chromium.org Bug: 716490 Change-Id: I1a3ad1a79f39ef001bd4489591d6e99ab0f6347f Reviewed-on: https://chromium-review.googlesource.com/954410 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#553288} [modify] https://crrev.com/f665b54282aee234ed8e5c9e82a94e1fd3c6aec7/content/browser/BUILD.gn [add] https://crrev.com/f665b54282aee234ed8e5c9e82a94e1fd3c6aec7/content/browser/dom_storage/session_storage_leveldb_wrapper.cc [add] https://crrev.com/f665b54282aee234ed8e5c9e82a94e1fd3c6aec7/content/browser/dom_storage/session_storage_leveldb_wrapper.h [add] https://crrev.com/f665b54282aee234ed8e5c9e82a94e1fd3c6aec7/content/browser/dom_storage/session_storage_leveldb_wrapper_unittest.cc [modify] https://crrev.com/f665b54282aee234ed8e5c9e82a94e1fd3c6aec7/content/browser/dom_storage/session_storage_metadata.cc [modify] https://crrev.com/f665b54282aee234ed8e5c9e82a94e1fd3c6aec7/content/browser/dom_storage/session_storage_metadata.h [modify] https://crrev.com/f665b54282aee234ed8e5c9e82a94e1fd3c6aec7/content/browser/dom_storage/session_storage_metadata_unittest.cc [modify] https://crrev.com/f665b54282aee234ed8e5c9e82a94e1fd3c6aec7/content/browser/leveldb_wrapper_impl_unittest.cc [modify] https://crrev.com/f665b54282aee234ed8e5c9e82a94e1fd3c6aec7/content/test/BUILD.gn [add] https://crrev.com/f665b54282aee234ed8e5c9e82a94e1fd3c6aec7/content/test/gmock_util.h [add] https://crrev.com/f665b54282aee234ed8e5c9e82a94e1fd3c6aec7/content/test/leveldb_wrapper_test_util.cc [add] https://crrev.com/f665b54282aee234ed8e5c9e82a94e1fd3c6aec7/content/test/leveldb_wrapper_test_util.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6c5b887561702883deed15c21105db2d4d2baa5a commit 6c5b887561702883deed15c21105db2d4d2baa5a Author: Daniel Murphy <dmurph@chromium.org> Date: Wed Apr 25 21:45:37 2018 [SessionStorageS13N] Fix renderer event firing matcher class Bug: 716490 Change-Id: Ie4ace578d7076c515d9ed1ef3dbb1494eeb3a550 Reviewed-on: https://chromium-review.googlesource.com/1028717 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#553765} [modify] https://crrev.com/6c5b887561702883deed15c21105db2d4d2baa5a/content/renderer/dom_storage/DEPS [modify] https://crrev.com/6c5b887561702883deed15c21105db2d4d2baa5a/content/renderer/dom_storage/local_storage_cached_area.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bdbd066301338e95446e0e5704ad80b4be03df0c commit bdbd066301338e95446e0e5704ad80b4be03df0c Author: Daniel Murphy <dmurph@chromium.org> Date: Wed Apr 25 22:24:10 2018 [SessionStorageS13N] SessionStorageNamespace mojo implementation. Creates the browser-side implementation of the SessionStorageNamespace mojo interface. The namespace holds the per-origin storage area and provides ways to both connect to the data and shallow-clone the data. TBR: jam@chromium.org for content/browser/BUILD.gn Bug: 716490 Change-Id: I9df5812afdacf4330728c590d47ecfdf93e320bd Reviewed-on: https://chromium-review.googlesource.com/1015894 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#553792} [modify] https://crrev.com/bdbd066301338e95446e0e5704ad80b4be03df0c/content/browser/BUILD.gn [modify] https://crrev.com/bdbd066301338e95446e0e5704ad80b4be03df0c/content/browser/dom_storage/session_storage_data_map_unittest.cc [modify] https://crrev.com/bdbd066301338e95446e0e5704ad80b4be03df0c/content/browser/dom_storage/session_storage_leveldb_wrapper.h [modify] https://crrev.com/bdbd066301338e95446e0e5704ad80b4be03df0c/content/browser/dom_storage/session_storage_leveldb_wrapper_unittest.cc [add] https://crrev.com/bdbd066301338e95446e0e5704ad80b4be03df0c/content/browser/dom_storage/session_storage_namespace_impl_mojo.cc [add] https://crrev.com/bdbd066301338e95446e0e5704ad80b4be03df0c/content/browser/dom_storage/session_storage_namespace_impl_mojo.h [add] https://crrev.com/bdbd066301338e95446e0e5704ad80b4be03df0c/content/browser/dom_storage/session_storage_namespace_impl_mojo_unittest.cc [modify] https://crrev.com/bdbd066301338e95446e0e5704ad80b4be03df0c/content/test/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fac097030a5a5c37825eb907d5eb5ae0c86aef71 commit fac097030a5a5c37825eb907d5eb5ae0c86aef71 Author: Daniel Murphy <dmurph@chromium.org> Date: Fri May 18 19:39:44 2018 [SessionStorageS13N] Storage events come from renderer, not browser Bug: 716490 Change-Id: If6420f0ece7938299f8597d15f56e9391a9cf437 Reviewed-on: https://chromium-review.googlesource.com/1065077 Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#559993} [modify] https://crrev.com/fac097030a5a5c37825eb907d5eb5ae0c86aef71/content/renderer/dom_storage/local_storage_cached_area.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f36bec395cfd4b4be3efb451810abd4fbbbad887 commit f36bec395cfd4b4be3efb451810abd4fbbbad887 Author: Daniel Murphy <dmurph@chromium.org> Date: Fri May 18 20:35:52 2018 [SessionStorageS13N] SessionStorage mojo context, and supporting fixes This patch implements the mojo service for SessionStorage, using a lot of classes that have been created / reviewed in previous patches. There are various small changes and fixes to these other classes, including new tests for bugs that were uncovered when testing the entire system. This patch also introduces new test helpers and tries to consolidate some testing logic for dom storage. Bug: 716490 Change-Id: I91acd0041c92f764e9577aae312b7dd30baf37af Reviewed-on: https://chromium-review.googlesource.com/1028767 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by: Mark Pearson <mpearson@chromium.org> Reviewed-by: Ken Rockot <rockot@chromium.org> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#560014} [modify] https://crrev.com/f36bec395cfd4b4be3efb451810abd4fbbbad887/base/metrics/histogram_functions.h [modify] https://crrev.com/f36bec395cfd4b4be3efb451810abd4fbbbad887/components/services/leveldb/public/cpp/util.cc [modify] https://crrev.com/f36bec395cfd4b4be3efb451810abd4fbbbad887/components/services/leveldb/public/cpp/util.h [modify] https://crrev.com/f36bec395cfd4b4be3efb451810abd4fbbbad887/content/browser/dom_storage/dom_storage_context_wrapper.cc [modify] https://crrev.com/f36bec395cfd4b4be3efb451810abd4fbbbad887/content/browser/dom_storage/local_storage_context_mojo.h [modify] https://crrev.com/f36bec395cfd4b4be3efb451810abd4fbbbad887/content/browser/dom_storage/local_storage_context_mojo_unittest.cc [modify] https://crrev.com/f36bec395cfd4b4be3efb451810abd4fbbbad887/content/browser/dom_storage/session_storage_context_mojo.cc [modify] https://crrev.com/f36bec395cfd4b4be3efb451810abd4fbbbad887/content/browser/dom_storage/session_storage_context_mojo.h [add] https://crrev.com/f36bec395cfd4b4be3efb451810abd4fbbbad887/content/browser/dom_storage/session_storage_context_mojo_unittest.cc [modify] https://crrev.com/f36bec395cfd4b4be3efb451810abd4fbbbad887/content/browser/dom_storage/session_storage_data_map_unittest.cc [modify] https://crrev.com/f36bec395cfd4b4be3efb451810abd4fbbbad887/content/browser/dom_storage/session_storage_database.cc [modify] https://crrev.com/f36bec395cfd4b4be3efb451810abd4fbbbad887/content/browser/dom_storage/session_storage_database.h [modify] https://crrev.com/f36bec395cfd4b4be3efb451810abd4fbbbad887/content/browser/dom_storage/session_storage_leveldb_wrapper.cc [modify] https://crrev.com/f36bec395cfd4b4be3efb451810abd4fbbbad887/content/browser/dom_storage/session_storage_leveldb_wrapper_unittest.cc [modify] https://crrev.com/f36bec395cfd4b4be3efb451810abd4fbbbad887/content/browser/dom_storage/session_storage_metadata.cc [modify] https://crrev.com/f36bec395cfd4b4be3efb451810abd4fbbbad887/content/browser/dom_storage/session_storage_metadata.h [modify] https://crrev.com/f36bec395cfd4b4be3efb451810abd4fbbbad887/content/browser/dom_storage/session_storage_metadata_unittest.cc [modify] https://crrev.com/f36bec395cfd4b4be3efb451810abd4fbbbad887/content/browser/dom_storage/session_storage_namespace_impl_mojo.cc [modify] https://crrev.com/f36bec395cfd4b4be3efb451810abd4fbbbad887/content/browser/dom_storage/session_storage_namespace_impl_mojo.h [modify] https://crrev.com/f36bec395cfd4b4be3efb451810abd4fbbbad887/content/browser/dom_storage/session_storage_namespace_impl_mojo_unittest.cc [add] https://crrev.com/f36bec395cfd4b4be3efb451810abd4fbbbad887/content/browser/dom_storage/test/fake_leveldb_database_error_on_write.cc [add] https://crrev.com/f36bec395cfd4b4be3efb451810abd4fbbbad887/content/browser/dom_storage/test/fake_leveldb_database_error_on_write.h [add] https://crrev.com/f36bec395cfd4b4be3efb451810abd4fbbbad887/content/browser/dom_storage/test/fake_leveldb_service.cc [add] https://crrev.com/f36bec395cfd4b4be3efb451810abd4fbbbad887/content/browser/dom_storage/test/fake_leveldb_service.h [add] https://crrev.com/f36bec395cfd4b4be3efb451810abd4fbbbad887/content/browser/dom_storage/test/mojo_test_with_file_service.cc [add] https://crrev.com/f36bec395cfd4b4be3efb451810abd4fbbbad887/content/browser/dom_storage/test/mojo_test_with_file_service.h [modify] https://crrev.com/f36bec395cfd4b4be3efb451810abd4fbbbad887/content/browser/frame_host/render_frame_host_impl.cc [modify] https://crrev.com/f36bec395cfd4b4be3efb451810abd4fbbbad887/content/browser/leveldb_wrapper_impl.cc [modify] https://crrev.com/f36bec395cfd4b4be3efb451810abd4fbbbad887/content/browser/leveldb_wrapper_impl.h [modify] https://crrev.com/f36bec395cfd4b4be3efb451810abd4fbbbad887/content/browser/leveldb_wrapper_impl_unittest.cc [modify] https://crrev.com/f36bec395cfd4b4be3efb451810abd4fbbbad887/content/test/BUILD.gn [modify] https://crrev.com/f36bec395cfd4b4be3efb451810abd4fbbbad887/content/test/leveldb_wrapper_test_util.cc [modify] https://crrev.com/f36bec395cfd4b4be3efb451810abd4fbbbad887/content/test/leveldb_wrapper_test_util.h [modify] https://crrev.com/f36bec395cfd4b4be3efb451810abd4fbbbad887/services/service_manager/public/cpp/service.h [modify] https://crrev.com/f36bec395cfd4b4be3efb451810abd4fbbbad887/services/service_manager/public/cpp/test/BUILD.gn [modify] https://crrev.com/f36bec395cfd4b4be3efb451810abd4fbbbad887/services/service_manager/public/cpp/test/test_connector_factory.cc [modify] https://crrev.com/f36bec395cfd4b4be3efb451810abd4fbbbad887/services/service_manager/public/cpp/test/test_connector_factory.h [add] https://crrev.com/f36bec395cfd4b4be3efb451810abd4fbbbad887/services/service_manager/public/cpp/test/test_service_decorator.cc [add] https://crrev.com/f36bec395cfd4b4be3efb451810abd4fbbbad887/services/service_manager/public/cpp/test/test_service_decorator.h [modify] https://crrev.com/f36bec395cfd4b4be3efb451810abd4fbbbad887/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/16ed078ec81bef8b070fe52ad907d82f81f4d7f7 commit 16ed078ec81bef8b070fe52ad907d82f81f4d7f7 Author: Daniel Murphy <dmurph@chromium.org> Date: Sat May 26 00:15:13 2018 [SessionStorageS13N] Migration browsertest. Adds browsertest for testing migration from the old SessionStorage database to the new version, and verifies that the new version is written. Also adds support for starting a shell with a session storage namespace. Bug: 716490 Change-Id: I5dd1f4e6b1213454fda4bae24540c00a696f7f21 Reviewed-on: https://chromium-review.googlesource.com/1070888 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by: Daniel Murphy <dmurph@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#562079} [modify] https://crrev.com/16ed078ec81bef8b070fe52ad907d82f81f4d7f7/content/browser/dom_storage/dom_storage_browsertest.cc [modify] https://crrev.com/16ed078ec81bef8b070fe52ad907d82f81f4d7f7/content/browser/dom_storage/session_storage_context_mojo.h [modify] https://crrev.com/16ed078ec81bef8b070fe52ad907d82f81f4d7f7/content/browser/dom_storage/session_storage_namespace_impl.h [modify] https://crrev.com/16ed078ec81bef8b070fe52ad907d82f81f4d7f7/content/shell/browser/shell.cc [modify] https://crrev.com/16ed078ec81bef8b070fe52ad907d82f81f4d7f7/content/shell/browser/shell.h [modify] https://crrev.com/16ed078ec81bef8b070fe52ad907d82f81f4d7f7/content/test/BUILD.gn [add] https://crrev.com/16ed078ec81bef8b070fe52ad907d82f81f4d7f7/content/test/data/dom_storage/store_session_storage_data.html [add] https://crrev.com/16ed078ec81bef8b070fe52ad907d82f81f4d7f7/content/test/data/dom_storage/verify_session_storage_data.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1bd58466eab023e8c734d1e63bd997daed4b3e30 commit 1bd58466eab023e8c734d1e63bd997daed4b3e30 Author: Daniel Murphy <dmurph@chromium.org> Date: Thu May 31 07:07:21 2018 [SessionStorageS13N] Enabling mojo SessionStorage by default Bug: 716490 Change-Id: I08c9bc35d1e9f8f86adc6c88fb7ab8069bcf7e8f Reviewed-on: https://chromium-review.googlesource.com/1072918 Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#563169} [modify] https://crrev.com/1bd58466eab023e8c734d1e63bd997daed4b3e30/content/public/common/content_features.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/299143ea1768cc81e76244b66bdd4546c0a95273 commit 299143ea1768cc81e76244b66bdd4546c0a95273 Author: Daniel Murphy <dmurph@chromium.org> Date: Fri Jun 01 17:09:16 2018 Revert "[SessionStorageS13N] Enabling mojo SessionStorage by default" This reverts commit 1bd58466eab023e8c734d1e63bd997daed4b3e30. Reason for revert: Causing crashes on Canary Bug: 848651 Original change's description: > [SessionStorageS13N] Enabling mojo SessionStorage by default > > Bug: 716490 > Change-Id: I08c9bc35d1e9f8f86adc6c88fb7ab8069bcf7e8f > Reviewed-on: https://chromium-review.googlesource.com/1072918 > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Commit-Queue: Daniel Murphy <dmurph@chromium.org> > Cr-Commit-Position: refs/heads/master@{#563169} TBR=dmurph@chromium.org,jam@chromium.org,mek@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 716490 Change-Id: I569f05103e4e00210d8dcac116c90713162e7679 Reviewed-on: https://chromium-review.googlesource.com/1081835 Reviewed-by: Daniel Murphy <dmurph@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#563691} [modify] https://crrev.com/299143ea1768cc81e76244b66bdd4546c0a95273/content/public/common/content_features.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/de8ccf8bbd3d4cfce1d03f49f379d207dcddd07f commit de8ccf8bbd3d4cfce1d03f49f379d207dcddd07f Author: Daniel Murphy <dmurph@chromium.org> Date: Fri Jun 01 17:10:38 2018 Revert "[SessionStorageS13N] Enabling mojo SessionStorage by default" This reverts commit 1bd58466eab023e8c734d1e63bd997daed4b3e30. Reason for revert: Causing crashes on Canary Bug: 848651 Original change's description: > [SessionStorageS13N] Enabling mojo SessionStorage by default > > Bug: 716490 > Change-Id: I08c9bc35d1e9f8f86adc6c88fb7ab8069bcf7e8f > Reviewed-on: https://chromium-review.googlesource.com/1072918 > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Commit-Queue: Daniel Murphy <dmurph@chromium.org> > Cr-Commit-Position: refs/heads/master@{#563169} TBR=dmurph@chromium.org,jam@chromium.org,mek@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 716490 Change-Id: I569f05103e4e00210d8dcac116c90713162e7679 Reviewed-on: https://chromium-review.googlesource.com/1081835 Reviewed-by: Daniel Murphy <dmurph@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#563691}(cherry picked from commit fb4c131d97a12dfeb9ec8578d229c9fea7666b0c) Reviewed-on: https://chromium-review.googlesource.com/1081877 Cr-Commit-Position: refs/branch-heads/3447@{#5} Cr-Branched-From: b8db51736cc3a3bda2a15aa8805871f9f12c0853-refs/heads/master@{#563478} [modify] https://crrev.com/de8ccf8bbd3d4cfce1d03f49f379d207dcddd07f/content/public/common/content_features.cc
Adding context from the crash reported in bug 848651: - https://bugs.chromium.org/p/chromium/issues/detail?id=848651#c11 - https://bugs.chromium.org/p/chromium/issues/detail?id=848651#c12 - https://bugs.chromium.org/p/chromium/issues/detail?id=848651#c14
Also: https://bugs.chromium.org/p/chromium/issues/detail?id=848651#c18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5916ae319c99a68094bd318d3759763563fbfc2f commit 5916ae319c99a68094bd318d3759763563fbfc2f Author: Daniel Murphy <dmurph@chromium.org> Date: Tue Jun 19 00:08:24 2018 Reland "[SessionStorageS13N] Enabling mojo SessionStorage by default" This is a reland of 1bd58466eab023e8c734d1e63bd997daed4b3e30 Original change's description: > [SessionStorageS13N] Enabling mojo SessionStorage by default > > Bug: 716490 > Change-Id: I08c9bc35d1e9f8f86adc6c88fb7ab8069bcf7e8f > Reviewed-on: https://chromium-review.googlesource.com/1072918 > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Commit-Queue: Daniel Murphy <dmurph@chromium.org> > Cr-Commit-Position: refs/heads/master@{#563169} Bug: 716490 Change-Id: I5c5911a5f98e84934837fb9025431a8f98bea6ba Reviewed-on: https://chromium-review.googlesource.com/1104825 Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#568244} [modify] https://crrev.com/5916ae319c99a68094bd318d3759763563fbfc2f/content/public/common/content_features.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3e3eb3f17d17de467705d58f504da6ca63d2e9c5 commit 3e3eb3f17d17de467705d58f504da6ca63d2e9c5 Author: Daniel Murphy <dmurph@chromium.org> Date: Tue Jun 19 16:36:40 2018 Revert "Reland "[SessionStorageS13N] Enabling mojo SessionStorage by default"" This reverts commit 5916ae319c99a68094bd318d3759763563fbfc2f. Bug: 854102 Reason for revert: Renderers still crashing - will have to investigate further. Original change's description: > Reland "[SessionStorageS13N] Enabling mojo SessionStorage by default" > > This is a reland of 1bd58466eab023e8c734d1e63bd997daed4b3e30 > > Original change's description: > > [SessionStorageS13N] Enabling mojo SessionStorage by default > > > > Bug: 716490 > > Change-Id: I08c9bc35d1e9f8f86adc6c88fb7ab8069bcf7e8f > > Reviewed-on: https://chromium-review.googlesource.com/1072918 > > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > > Commit-Queue: Daniel Murphy <dmurph@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#563169} > > Bug: 716490 > Change-Id: I5c5911a5f98e84934837fb9025431a8f98bea6ba > Reviewed-on: https://chromium-review.googlesource.com/1104825 > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > Commit-Queue: Daniel Murphy <dmurph@chromium.org> > Cr-Commit-Position: refs/heads/master@{#568244} TBR=dmurph@chromium.org,jam@chromium.org,mek@chromium.org Change-Id: I5cb433aa9dd9acefb8cb34cb9cc7e5820b9931cf No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 716490 Reviewed-on: https://chromium-review.googlesource.com/1106398 Reviewed-by: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#568486} [modify] https://crrev.com/3e3eb3f17d17de467705d58f504da6ca63d2e9c5/content/public/common/content_features.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3042d2e45c7a4eccb91a6f3ee51b4818a07e89e5 commit 3042d2e45c7a4eccb91a6f3ee51b4818a07e89e5 Author: Daniel Murphy <dmurph@chromium.org> Date: Tue Jun 19 16:51:14 2018 Revert "Reland "[SessionStorageS13N] Enabling mojo SessionStorage by default"" This reverts commit 5916ae319c99a68094bd318d3759763563fbfc2f. Bug: 854102 Reason for revert: Renderers still crashing - will have to investigate further. Original change's description: > Reland "[SessionStorageS13N] Enabling mojo SessionStorage by default" > > This is a reland of 1bd58466eab023e8c734d1e63bd997daed4b3e30 > > Original change's description: > > [SessionStorageS13N] Enabling mojo SessionStorage by default > > > > Bug: 716490 > > Change-Id: I08c9bc35d1e9f8f86adc6c88fb7ab8069bcf7e8f > > Reviewed-on: https://chromium-review.googlesource.com/1072918 > > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > > Commit-Queue: Daniel Murphy <dmurph@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#563169} > > Bug: 716490 > Change-Id: I5c5911a5f98e84934837fb9025431a8f98bea6ba > Reviewed-on: https://chromium-review.googlesource.com/1104825 > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > Commit-Queue: Daniel Murphy <dmurph@chromium.org> > Cr-Commit-Position: refs/heads/master@{#568244} TBR=dmurph@chromium.org,jam@chromium.org,mek@chromium.org Change-Id: I5cb433aa9dd9acefb8cb34cb9cc7e5820b9931cf No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 716490 Reviewed-on: https://chromium-review.googlesource.com/1106398 Reviewed-by: Daniel Murphy <dmurph@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#568486}(cherry picked from commit 3e3eb3f17d17de467705d58f504da6ca63d2e9c5) Reviewed-on: https://chromium-review.googlesource.com/1106399 Reviewed-by: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/branch-heads/3465@{#3} Cr-Branched-From: e2efbcdc641c80311c32b56221389c5d7700af22-refs/heads/master@{#568285} [modify] https://crrev.com/3042d2e45c7a4eccb91a6f3ee51b4818a07e89e5/content/public/common/content_features.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/217f9a337351440154d0769acb9283d763d07914 commit 217f9a337351440154d0769acb9283d763d07914 Author: Daniel Murphy <dmurph@chromium.org> Date: Fri Jun 22 20:36:50 2018 [SessionStorageS13N] Fixing StoragePartitionImpl RemoveLocalStorage tests Session was assuming that InitiateConnection() would always complete asynchronously. In tests, this doesn't happen. This fixes one case where a callback was registered after the call to InitiateConnection() Bug: 716490 Change-Id: I606446ba5e5ba5907c9c37ab440cc38bef2838d8 Reviewed-on: https://chromium-review.googlesource.com/1112486 Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#569742} [modify] https://crrev.com/217f9a337351440154d0769acb9283d763d07914/content/browser/dom_storage/session_storage_context_mojo.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2eed4538eaabedf06e3e3e938cfb7685fddc57ca commit 2eed4538eaabedf06e3e3e938cfb7685fddc57ca Author: Daniel Murphy <dmurph@chromium.org> Date: Fri Jun 22 21:30:30 2018 Reland "[SessionStorageS13N] Enabling mojo SessionStorage by default" This is a reland of 1bd58466eab023e8c734d1e63bd997daed4b3e30 Original change's description: > [SessionStorageS13N] Enabling mojo SessionStorage by default > > Bug: 716490 > Change-Id: I08c9bc35d1e9f8f86adc6c88fb7ab8069bcf7e8f > Reviewed-on: https://chromium-review.googlesource.com/1072918 > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Commit-Queue: Daniel Murphy <dmurph@chromium.org> > Cr-Commit-Position: refs/heads/master@{#563169} Bug: 716490 Change-Id: Ieae476bcb794047f5f57760eeb3e2e811838bc03 Reviewed-on: https://chromium-review.googlesource.com/1110777 Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#569786} [modify] https://crrev.com/2eed4538eaabedf06e3e3e938cfb7685fddc57ca/content/public/common/content_features.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e763162f778955442c10aff057dedc06f9bf7678 commit e763162f778955442c10aff057dedc06f9bf7678 Author: Daniel Murphy <dmurph@chromium.org> Date: Thu Jul 19 20:31:37 2018 Revert "[SessionStorageS13N] Enabling mojo SessionStorage by default" This reverts commit 1bd58466eab023e8c734d1e63bd997daed4b3e30. Reason for revert: Too many fishy crashes - I want to wait another cycle Bug: 857464 Original change's description: > [SessionStorageS13N] Enabling mojo SessionStorage by default > > Bug: 716490 > Change-Id: I08c9bc35d1e9f8f86adc6c88fb7ab8069bcf7e8f > Reviewed-on: https://chromium-review.googlesource.com/1072918 > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Commit-Queue: Daniel Murphy <dmurph@chromium.org> > Cr-Commit-Position: refs/heads/master@{#563169} TBR=dmurph@chromium.org,jam@chromium.org,mek@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 716490 Change-Id: Ia1df84d49c46ab2ebd5f58d389d34cea0d235bd1 Reviewed-on: https://chromium-review.googlesource.com/1144081 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#576609} [modify] https://crrev.com/e763162f778955442c10aff057dedc06f9bf7678/content/public/common/content_features.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3692ad153b0ef17e64fd2fe7a8ab2c9031427295 commit 3692ad153b0ef17e64fd2fe7a8ab2c9031427295 Author: Daniel Murphy <dmurph@chromium.org> Date: Fri Jul 20 22:13:16 2018 Reland "[SessionStorageS13N] Enabling mojo SessionStorage by default" This is a reland of 1bd58466eab023e8c734d1e63bd997daed4b3e30. I want to get this feature back on in Canary so I can continue to see crashes in the wild - there are still no crashes reproduced in tests or reports. TBR=jam@chromium.org TBR=mek@chromium.org Original change's description: > [SessionStorageS13N] Enabling mojo SessionStorage by default > > Bug: 716490 > Change-Id: I08c9bc35d1e9f8f86adc6c88fb7ab8069bcf7e8f > Reviewed-on: https://chromium-review.googlesource.com/1072918 > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Commit-Queue: Daniel Murphy <dmurph@chromium.org> > Cr-Commit-Position: refs/heads/master@{#563169} Bug: 716490 Change-Id: I6c91ffb8302ea9bead0809ef293f9a007edd608c Reviewed-on: https://chromium-review.googlesource.com/1145201 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#577010} [modify] https://crrev.com/3692ad153b0ef17e64fd2fe7a8ab2c9031427295/content/public/common/content_features.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/304663b467d33fbe0a7e552565aceb5a59d8b2b0 commit 304663b467d33fbe0a7e552565aceb5a59d8b2b0 Author: Daniel Murphy <dmurph@chromium.org> Date: Thu Aug 09 16:27:00 2018 Revert "[SessionStorageS13N] Enabling mojo SessionStorage by default" This reverts commit 1bd58466eab023e8c734d1e63bd997daed4b3e30. Reason for revert: The crashes are still happening, and we aren't closer to finding the cause. Changing focus to the onion-souping effort. Bug: 859464, 857464, 867850, 866827 Original change's description: > [SessionStorageS13N] Enabling mojo SessionStorage by default > > Bug: 716490 > Change-Id: I08c9bc35d1e9f8f86adc6c88fb7ab8069bcf7e8f > Reviewed-on: https://chromium-review.googlesource.com/1072918 > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Commit-Queue: Daniel Murphy <dmurph@chromium.org> > Cr-Commit-Position: refs/heads/master@{#563169} TBR=dmurph@chromium.org,jam@chromium.org,mek@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 716490 Change-Id: Ic5223ccbff4d61264c070b3518cf63ddb83deeb0 Reviewed-on: https://chromium-review.googlesource.com/1157446 Reviewed-by: Daniel Murphy <dmurph@chromium.org> [modify] https://crrev.com/304663b467d33fbe0a7e552565aceb5a59d8b2b0/chrome/browser/browsing_data/browsing_data_remover_browsertest.cc [modify] https://crrev.com/304663b467d33fbe0a7e552565aceb5a59d8b2b0/content/public/common/content_features.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bbe0692bd9283569546670318df6e3d8e605be8c commit bbe0692bd9283569546670318df6e3d8e605be8c Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Thu Aug 09 19:10:24 2018 Reland "[SessionStorageS13N] Enabling mojo SessionStorage by default" This reverts commit 304663b467d33fbe0a7e552565aceb5a59d8b2b0. Reason for revert: Due to Gerrit outage http://crbug.com/872722 , we are reverting this CL. Please, re-land it after all clear is given. If you have questions, please ask on the bug. Sorry for the inconvenience. Original change's description: > Revert "[SessionStorageS13N] Enabling mojo SessionStorage by default" > > This reverts commit 1bd58466eab023e8c734d1e63bd997daed4b3e30. > > Reason for revert: The crashes are still happening, and we aren't > closer to finding the cause. Changing focus to the > onion-souping effort. > > Bug: 859464, 857464, 867850, 866827 > > Original change's description: > > [SessionStorageS13N] Enabling mojo SessionStorage by default > > > > Bug: 716490 > > Change-Id: I08c9bc35d1e9f8f86adc6c88fb7ab8069bcf7e8f > > Reviewed-on: https://chromium-review.googlesource.com/1072918 > > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > > Commit-Queue: Daniel Murphy <dmurph@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#563169} > > TBR=dmurph@chromium.org,jam@chromium.org,mek@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 716490 > Change-Id: Ic5223ccbff4d61264c070b3518cf63ddb83deeb0 > Reviewed-on: https://chromium-review.googlesource.com/1157446 > Reviewed-by: Daniel Murphy <dmurph@chromium.org> TBR=dmurph@chromium.org,jam@chromium.org,mek@chromium.org Change-Id: Ia063033d68cd05bc46ca9259ed9f49e5ee06bab9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 859464, 857464, 867850, 866827, 716490 Reviewed-on: https://chromium-review.googlesource.com/1169843 Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> [modify] https://crrev.com/bbe0692bd9283569546670318df6e3d8e605be8c/chrome/browser/browsing_data/browsing_data_remover_browsertest.cc [modify] https://crrev.com/bbe0692bd9283569546670318df6e3d8e605be8c/content/public/common/content_features.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6ef5af6759c379b78b518789649b1e73e8e91a2a commit 6ef5af6759c379b78b518789649b1e73e8e91a2a Author: Dirk Pranke <dpranke@chromium.org> Date: Thu Aug 09 22:12:03 2018 Revert "Reland "[SessionStorageS13N] Enabling mojo SessionStorage by default"" This reverts commit bbe0692bd9283569546670318df6e3d8e605be8c. Reason for revert: We actually want this change reverted :). The original CL was bad, the revert was a manual thing done by the sheriff. The GoB fix then re-landed this, and now we want to reland it again. Original change's description: > Reland "[SessionStorageS13N] Enabling mojo SessionStorage by default" > > This reverts commit 304663b467d33fbe0a7e552565aceb5a59d8b2b0. > > Reason for revert: Due to Gerrit outage http://crbug.com/872722 , we are reverting this CL. Please, re-land it after all clear is given. If you have questions, please ask on the bug. Sorry for the inconvenience. > > Original change's description: > > Revert "[SessionStorageS13N] Enabling mojo SessionStorage by default" > > > > This reverts commit 1bd58466eab023e8c734d1e63bd997daed4b3e30. > > > > Reason for revert: The crashes are still happening, and we aren't > > closer to finding the cause. Changing focus to the > > onion-souping effort. > > > > Bug: 859464, 857464, 867850, 866827 > > > > Original change's description: > > > [SessionStorageS13N] Enabling mojo SessionStorage by default > > > > > > Bug: 716490 > > > Change-Id: I08c9bc35d1e9f8f86adc6c88fb7ab8069bcf7e8f > > > Reviewed-on: https://chromium-review.googlesource.com/1072918 > > > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > > > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > > > Commit-Queue: Daniel Murphy <dmurph@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#563169} > > > > TBR=dmurph@chromium.org,jam@chromium.org,mek@chromium.org > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > Bug: 716490 > > Change-Id: Ic5223ccbff4d61264c070b3518cf63ddb83deeb0 > > Reviewed-on: https://chromium-review.googlesource.com/1157446 > > Reviewed-by: Daniel Murphy <dmurph@chromium.org> > > TBR=dmurph@chromium.org,jam@chromium.org,mek@chromium.org > > Change-Id: Ia063033d68cd05bc46ca9259ed9f49e5ee06bab9 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 859464, 857464, 867850, 866827, 716490 > Reviewed-on: https://chromium-review.googlesource.com/1169843 > Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> TBR=dmurph@chromium.org,jam@chromium.org,mek@chromium.org,tandrii@chromium.org Change-Id: I3ff96a37dd11d2986651dbd8a7156178c20fb018 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 859464, 857464, 867850, 866827, 716490 Reviewed-on: https://chromium-review.googlesource.com/1170005 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#581909} [modify] https://crrev.com/6ef5af6759c379b78b518789649b1e73e8e91a2a/chrome/browser/browsing_data/browsing_data_remover_browsertest.cc [modify] https://crrev.com/6ef5af6759c379b78b518789649b1e73e8e91a2a/content/public/common/content_features.cc
I believe this is done now! After it is in stable for a release, then we will remove all the old code.
The Storage team monitors Internals>Storage. The Internals>Services>Storage label will be deprecated & removed.
Comment 1 by jsb...@chromium.org
, May 22 2017