New issue
Advanced search Search tips

Issue 716483 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Record CanMakePaymentMetrics on Desktop

Project Member Reported by se...@chromium.org, Apr 28 2017

Issue description

^^^
 

Comment 1 by se...@chromium.org, May 2 2017

Summary: Record CanMakePaymentMetrics on Desktop (was: Hookup the Journey Logger for PaymentRequest on Desktop)
Project Member

Comment 2 by bugdroid1@chromium.org, May 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20b49d7b4fb728890b2298345326cb3f1a41f555

commit 20b49d7b4fb728890b2298345326cb3f1a41f555
Author: sebsg <sebsg@chromium.org>
Date: Thu May 04 20:23:17 2017

[Payments] Record CanMakePayment metrics on Desktop

Plug in the JourneyLogger on the Desktop code and use it
to record CanMakePayment metrics.

BUG= 716483 

Review-Url: https://codereview.chromium.org/2851893002
Cr-Commit-Position: refs/heads/master@{#469447}

[modify] https://crrev.com/20b49d7b4fb728890b2298345326cb3f1a41f555/chrome/browser/payments/android/journey_logger_android.cc
[modify] https://crrev.com/20b49d7b4fb728890b2298345326cb3f1a41f555/chrome/browser/payments/chrome_payment_request_delegate.cc
[modify] https://crrev.com/20b49d7b4fb728890b2298345326cb3f1a41f555/chrome/browser/payments/chrome_payment_request_delegate.h
[modify] https://crrev.com/20b49d7b4fb728890b2298345326cb3f1a41f555/chrome/browser/ui/views/payments/payment_request_browsertest.cc
[modify] https://crrev.com/20b49d7b4fb728890b2298345326cb3f1a41f555/chrome/browser/ui/views/payments/payment_request_browsertest_base.cc
[modify] https://crrev.com/20b49d7b4fb728890b2298345326cb3f1a41f555/chrome/browser/ui/views/payments/payment_request_browsertest_base.h
[add] https://crrev.com/20b49d7b4fb728890b2298345326cb3f1a41f555/chrome/browser/ui/views/payments/payment_request_can_make_payment_metrics_browsertest.cc
[modify] https://crrev.com/20b49d7b4fb728890b2298345326cb3f1a41f555/chrome/test/BUILD.gn
[modify] https://crrev.com/20b49d7b4fb728890b2298345326cb3f1a41f555/chrome/test/data/payments/can_make_payment_metrics.js
[modify] https://crrev.com/20b49d7b4fb728890b2298345326cb3f1a41f555/chrome/test/data/payments/payment_request_can_make_payment_metrics_test.html
[modify] https://crrev.com/20b49d7b4fb728890b2298345326cb3f1a41f555/components/payments/content/payment_request.cc
[modify] https://crrev.com/20b49d7b4fb728890b2298345326cb3f1a41f555/components/payments/content/payment_request.h
[modify] https://crrev.com/20b49d7b4fb728890b2298345326cb3f1a41f555/components/payments/core/autofill_payment_instrument_unittest.cc
[modify] https://crrev.com/20b49d7b4fb728890b2298345326cb3f1a41f555/components/payments/core/journey_logger.cc
[modify] https://crrev.com/20b49d7b4fb728890b2298345326cb3f1a41f555/components/payments/core/journey_logger.h
[modify] https://crrev.com/20b49d7b4fb728890b2298345326cb3f1a41f555/components/payments/core/payment_request_delegate.h
[modify] https://crrev.com/20b49d7b4fb728890b2298345326cb3f1a41f555/components/payments/core/test_payment_request_delegate.cc
[modify] https://crrev.com/20b49d7b4fb728890b2298345326cb3f1a41f555/components/payments/core/test_payment_request_delegate.h

Comment 3 by se...@chromium.org, May 4 2017

Status: Fixed (was: Started)
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment