Issue metadata
Sign in to add a comment
|
[Password Generation] Detect whether or not there's a autocomplete="new-password"
Reported by
krystian...@gmail.com,
Apr 28 2017
|
||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.81 Safari/537.36 Steps to reproduce the problem: Let's have a "change your password" page with three inputs that are of type "password": 1. New password (has autocomplete="new-password") 2. New password confirmation (has autocomplete="new-password") 3. Old password for verification (has autocomplete="current-password") What is the expected behavior? Password Generation UI should popup on "new password" input and put the value in it and the next one (new password confirmation). What went wrong? It doesn't matter on which input[type="password"] I click. The result is the same - I get autocomplete for my current password. Did this work before? No Chrome version: 58.0.3029.81 Channel: stable OS Version: 10.0 Flash Version: When there are multiple inputs with the type of "password" on the page, Password Generator gets confused and doesn't show its UI where it's needed.
,
May 2 2017
,
May 4 2017
Able to reproduce the issue on Windows 10 and mac 10.12.4 using chrome reported version #58.0.3029.81 and latest canary #60.0.3088.3. On OS-Linux, the old password field, new password and password confirmation fields did not autofill with the saved password. Bisect Information: ===================== Good build: 51.0.2703.0 Revision(385938) Bad Build : 51.0.2704.0 Revision(386251) Change Log URL: https://chromium.googlesource.com/chromium/src/+log/3943d65cbc744467a489b7013cd736025851ef24..6d958c3b506da818850411246e247b4e1849c2d2 From the above change log suspecting below change Review url: https://codereview.chromium.org/1814193002 dvadym@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Thanks...!!
,
May 4 2017
Can we get this fixed before M60 hits stable?Please feel free to update the label accordingly.
,
May 22 2017
Change password forms are not supposed to be filled on load, they could be get filled by clicking on field. So it works as expected. So it's not release blocker (so I'm removing labels). Yeah, processing of autocomplete attributes for generation is broken, but it's not because of recent changes. We should fix this.
,
May 22 2017
Technical explanations what's broken: Processing of autocomplete attributes for password generation was implemented before implementatation of change password forms, so there is an assumption in code that only sign-up forms are supported: 1.It's required that username is marked with autocomplete attribute https://cs.chromium.org/chromium/src/components/autofill/content/renderer/password_generation_agent.cc?type=cs&q=AutocompleteAttributesSetForGeneration&l=117 2.If there are autocomplete attributes, the first password element is taken as the candidate for generation https://cs.chromium.org/chromium/src/components/autofill/content/renderer/password_generation_agent.cc?type=cs&l=426 So we need to loose the requirement on marking of username element and to implement correct choosing of input element for generation.
,
Jun 1 2017
Please don't publicize my e-mail :( I can send you URL and user data privately since I don't want it to be public. Where can I send it to?
,
Jun 1 2017
Sorry, I didn't know it's hidden. Repeating comment #7, I was asking whether the form from the issue description is available online. I will ping you privately, if you prefer.
,
Jun 1 2017
I've sent the data.
,
Jun 1 2017
,
Jun 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6121d9064193b5d9eef9092425909b4e6cec3bcb commit 6121d9064193b5d9eef9092425909b4e6cec3bcb Author: pkalinnikov <pkalinnikov@chromium.org> Date: Fri Jun 09 12:00:52 2017 [PasswordGeneration] Improve change/confirm password field detection. Use autocomplete attributes to discover change/confirm password fields when no PasswordFormGenerationData is found for a possible password form. BUG= 716464 Review-Url: https://codereview.chromium.org/2917933002 Cr-Commit-Position: refs/heads/master@{#478250} [modify] https://crrev.com/6121d9064193b5d9eef9092425909b4e6cec3bcb/chrome/renderer/autofill/password_generation_agent_browsertest.cc [modify] https://crrev.com/6121d9064193b5d9eef9092425909b4e6cec3bcb/components/autofill/content/renderer/password_form_conversion_utils.cc [modify] https://crrev.com/6121d9064193b5d9eef9092425909b4e6cec3bcb/components/autofill/content/renderer/password_form_conversion_utils.h [modify] https://crrev.com/6121d9064193b5d9eef9092425909b4e6cec3bcb/components/autofill/content/renderer/password_generation_agent.cc
,
Jun 9 2017
#10: I checked this patch on the site you've sent me, seems working. Can you confirm that this works as you expected?
,
Sep 19 2017
I can confirm it's fixed. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by ligim...@chromium.org
, Apr 28 2017Components: UI>Browser>Passwords
Labels: Prestable-58.0.3029.81 Needs-Triage-M58 Needs-Bisect