New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 716464 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug-Regression



Sign in to add a comment

[Password Generation] Detect whether or not there's a autocomplete="new-password"

Reported by krystian...@gmail.com, Apr 28 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.81 Safari/537.36

Steps to reproduce the problem:
Let's have a "change your password" page with three inputs that are of type "password":

1. New password (has autocomplete="new-password")
2. New password confirmation (has autocomplete="new-password")
3. Old password for verification (has autocomplete="current-password")

What is the expected behavior?
Password Generation UI should popup on "new password" input and put the value in it and the next one (new password confirmation).

What went wrong?
It doesn't matter on which input[type="password"] I click. The result is the same - I get autocomplete for my current password.

Did this work before? No 

Chrome version: 58.0.3029.81  Channel: stable
OS Version: 10.0
Flash Version: 

When there are multiple inputs with the type of "password" on the page, Password Generator gets confused and doesn't show its UI where it's needed.
 
example.mp4
308 KB View Download
Cc: ligim...@chromium.org
Components: UI>Browser>Passwords
Labels: Prestable-58.0.3029.81 Needs-Triage-M58 Needs-Bisect

Comment 2 by vabr@chromium.org, May 2 2017

Components: -UI -UI>Browser>Passwords UI>Browser>Passwords>Generation
Labels: Hotlist-Polish
Labels: -Type-Bug -Pri-2 -Needs-Bisect -Needs-Triage-M58 hasbisect-per-revision M-60 OS-Mac Pri-1 Type-Bug-Regression
Owner: dvadym@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on Windows 10 and mac 10.12.4 using chrome reported version #58.0.3029.81 and latest canary #60.0.3088.3.
On OS-Linux, the old password field, new password and password confirmation fields did not autofill with the saved password.

Bisect Information:
=====================
Good build: 51.0.2703.0    Revision(385938)
Bad Build : 51.0.2704.0    Revision(386251)

Change Log URL: 
https://chromium.googlesource.com/chromium/src/+log/3943d65cbc744467a489b7013cd736025851ef24..6d958c3b506da818850411246e247b4e1849c2d2

From the above change log suspecting below change
Review url: https://codereview.chromium.org/1814193002

dvadym@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thanks...!!
Labels: ReleaseBlock-Stable
Can we get this fixed before M60 hits stable?Please feel free to update the label accordingly.

Comment 5 by dvadym@chromium.org, May 22 2017

Labels: -OS-Windows -Pri-1 -Arch-x86_64 -ReleaseBlock-Stable -OS-Mac -M-60 -hasbisect-per-revision -Prestable-58.0.3029.81 OS-All Pri-2
Change password forms are not supposed to be filled on load, they could be get filled by clicking on field. So it works as expected. So it's not release blocker (so I'm removing labels).

Yeah, processing of autocomplete attributes for generation is broken, but it's not because of recent changes. We should fix this.

Comment 6 by dvadym@chromium.org, May 22 2017

Technical explanations what's broken:

Processing of autocomplete attributes for password generation was implemented before implementatation of change password forms, so there is an assumption in code that only sign-up forms are supported:

1.It's required that username is marked with autocomplete attribute
https://cs.chromium.org/chromium/src/components/autofill/content/renderer/password_generation_agent.cc?type=cs&q=AutocompleteAttributesSetForGeneration&l=117

2.If there are autocomplete attributes, the first password element is taken as the candidate for generation
https://cs.chromium.org/chromium/src/components/autofill/content/renderer/password_generation_agent.cc?type=cs&l=426

So we need to loose the requirement on marking of username element and to implement correct choosing of input element for generation. 

Comment 7 Deleted

Please don't publicize my e-mail :(

I can send you URL and user data privately since I don't want it to be public. Where can I send it to?
Sorry, I didn't know it's hidden. Repeating comment #7, I was asking whether the form from the issue description is available online.

I will ping you privately, if you prefer.
I've sent the data.
Status: Started (was: Assigned)
Status: Fixed (was: Started)
#10: I checked this patch on the site you've sent me, seems working. Can you confirm that this works as you expected?
I can confirm it's fixed.

Sign in to add a comment