Issue metadata
Sign in to add a comment
|
1.1%-1.4% regression in memory.top_10_mobile_stress at 467369:467473 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Apr 28 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8981078745281479664
,
Apr 29 2017
=== Auto-CCing suspected CL author ben@chromium.org === Hi ben@chromium.org, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : ben Commit : b932d5ad0c349295c9d10de144f9358370e57b5c Date : Wed Apr 26 19:40:13 2017 Subject: Implement Connector::ApplySpec() & use to enforce navigation:frame. Bisect Details Configuration: android_nexus5_perf_bisect Benchmark : memory.top_10_mobile_stress Metric : memory:chrome:all_processes:reported_by_chrome:malloc:effective_size_avg/background/after_http_m_intl_taobao_com_group_purchase_html Change : 1.15% | 28738211.5714 -> 29094435.5714 Revision Result N chromium@467404 28738212 +- 2130247 14 good chromium@467413 28749072 +- 1936994 14 good chromium@467414 28840336 +- 486927 14 good chromium@467415 28997497 +- 516805 21 bad <-- chromium@467418 28862890 +- 2147507 14 bad chromium@467421 28587193 +- 3237169 14 bad chromium@467438 29047514 +- 315045 9 bad chromium@467473 29094436 +- 453167 14 bad Please refer to the following doc on diagnosing memory regressions: https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md To Run This Test src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests memory.top_10_mobile_stress Debug Info https://chromeperf.appspot.com/buildbucket_job_status/8981078745281479664 Is this bisect wrong? https://chromeperf.appspot.com/bad_bisect?try_job_id=5852663993860096 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Speed>Bisection. Thank you!
,
May 1 2017
,
May 2 2017
Issue 717639 has been merged into this issue.
,
May 2 2017
Issue 717637 has been merged into this issue.
,
May 2 2017
Issue 717640 has been merged into this issue.
,
May 3 2017
,
May 3 2017
Issue 718032 has been merged into this issue.
,
May 3 2017
Issue 718033 has been merged into this issue.
,
Jul 27 2017
Explictly assigning. A CL you landed tripped one of the speed metrics we measure in the lab. If this is the first time this has happened to one of your CLs, or if it's been a while, please read: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/addressing_performance_regressions.md We're looking for one of the following: 1. Justification via explanation 2. Plan to revert or fix 3. Angry rage throwing of equipment at my head Just be aware that I'm trained in trumpet playing and First Aid and am not afraid to use it. Note: This was a bulk edit message and not very personal.
,
Sep 21 2017
ben: any update on this? I know it's a pretty old regression at this point, but some of the regressions are up to 2.5mib, which is pretty big on Android. Adding reviewers of the CL (https://codereview.chromium.org/2816393002, "Implement Connector::ApplySpec() & use to enforce navigation:frame") in case they have thoughts.
,
Jan 8 2018
Archiving due to inactivity, feel free to re-open. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by rmcilroy@chromium.org
, Apr 28 2017