chrome://media-internals grows in memory through loads of <canvas> elements |
||||
Issue descriptionIf you watch a stream and have chrome://media-internals open, you will eventually run out of memory because of chrome://media-internals adding more and more CacheEntry objects which each contain 2 <canvas> elements. <canvas> elements are heavy and it's better to keep the count down, and the cache (if it really is a cache) should be size limited. After having a twitch stream open for 20 hours, there is about 85,000 CacheEntry objects, and 170,000 HTMLCanvasElements and the memory use is about 900 MB I am not sure what the canvas represents. I tried a few different resources and they stayed fully grey. This (the large amount of CacheEntry objects) might also be the cause of the heavy cpu usage of the media-internals page at time.
,
Apr 28 2017
Hah, I'm not sure those even work anymore, so we should probably just delete them.
,
Apr 28 2017
(They used to display buffering levels).
,
Apr 28 2017
give to sandersd@ who did some work on chrome://media-internals in Q1. bratell@opera.com, does this issue still repro on the latset dev buiild 59?
,
Apr 28 2017
I was seeing this in a build from before The Big Rename, but I read the source code from todayish and the code basically matched what I saw. I can check in a later build if you think this has been fixed, but not today.
,
Jun 16 2017
,
Jun 16 2017
Issue 734193 has been merged into this issue.
,
Jun 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1ff5a375ab0b3c53a6893a1e257c2d81a16a485b commit 1ff5a375ab0b3c53a6893a1e257c2d81a16a485b Author: Dale Curtis <dalecurtis@chromium.org> Date: Fri Jun 16 23:55:52 2017 Remove dead code around media-internals buffering extents. BUG= 716381 , 734193 TEST=chrome://media-internals still works Change-Id: I1f8f1bf4bb209b84ec718ced4a34ca3190457e71 Reviewed-on: https://chromium-review.googlesource.com/538899 Reviewed-by: Dan Sanders <sandersd@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#480229} [modify] https://crrev.com/1ff5a375ab0b3c53a6893a1e257c2d81a16a485b/content/browser/media/media_internals.cc [modify] https://crrev.com/1ff5a375ab0b3c53a6893a1e257c2d81a16a485b/content/browser/media/media_internals_proxy.cc [modify] https://crrev.com/1ff5a375ab0b3c53a6893a1e257c2d81a16a485b/content/browser/media/media_internals_proxy.h [delete] https://crrev.com/df131c01ccdbc3f32eb7fe6066a2d75ef8e5a07e/content/browser/resources/media/cache_entry.js [modify] https://crrev.com/1ff5a375ab0b3c53a6893a1e257c2d81a16a485b/content/browser/resources/media/client_renderer.js [delete] https://crrev.com/df131c01ccdbc3f32eb7fe6066a2d75ef8e5a07e/content/browser/resources/media/disjoint_range_set.js [delete] https://crrev.com/df131c01ccdbc3f32eb7fe6066a2d75ef8e5a07e/content/browser/resources/media/disjoint_range_set_test.html [modify] https://crrev.com/1ff5a375ab0b3c53a6893a1e257c2d81a16a485b/content/browser/resources/media/main.js [modify] https://crrev.com/1ff5a375ab0b3c53a6893a1e257c2d81a16a485b/content/browser/resources/media/media_internals.js [modify] https://crrev.com/1ff5a375ab0b3c53a6893a1e257c2d81a16a485b/content/renderer/media/render_media_log.cc [modify] https://crrev.com/1ff5a375ab0b3c53a6893a1e257c2d81a16a485b/content/renderer/media/render_media_log.h [modify] https://crrev.com/1ff5a375ab0b3c53a6893a1e257c2d81a16a485b/content/renderer/media/render_media_log_unittest.cc [modify] https://crrev.com/1ff5a375ab0b3c53a6893a1e257c2d81a16a485b/media/base/media_log.cc [modify] https://crrev.com/1ff5a375ab0b3c53a6893a1e257c2d81a16a485b/media/base/media_log.h [modify] https://crrev.com/1ff5a375ab0b3c53a6893a1e257c2d81a16a485b/media/base/media_log_event.h [modify] https://crrev.com/1ff5a375ab0b3c53a6893a1e257c2d81a16a485b/media/blink/webmediaplayer_impl.cc
,
Jun 17 2017
Should be fixed now. |
||||
►
Sign in to add a comment |
||||
Comment 1 by xhw...@chromium.org
, Apr 28 2017Labels: Media-Internals