Issue metadata
Sign in to add a comment
|
Regression: Blue focus is seen missing in 'Choose you language & keyboard' screen. |
||||||||||||||||||||||
Issue descriptionChrome Version: 60.0.3080.3/9501.0.0 dev channel Kip,Paine,Blaze OS: Chrome OS What steps will reproduce the problem? (1)Recover build via USB >> Go to 'Choose your Language & Keyboard' screen. (2)Now click on Language/Keyboard drop down (or) hit tab such that focus shifts to language/keyboard drop down and Observe. Expected: Blue focus line should be seen when clicked or on tabbing for Language and Keyboard drop downs. Actual: Instead blue focus is seen missing. This is regression issue as blue focus is seen in 59.0.3065.0/9453.0.0 dev channel Kip. Attaching screen shots for reference.
,
May 2 2017
Reproduction is simple: gn gen out/Release --args="is_debug=false use_goma=true target_os=chromeos is_chrome_branded=true is_official_build=true" && ninja -C out/Release/ -j3000 chrome chrome_sandbox && (UDD=$HOME/cros-test-user-data-dir-tmp ; rm -rf $HOME/cros-test-user-data-dir-tmp ; mkdir -p $HOME/cros-test-user-data-dir-tmp ; ./out/Release/chrome --login-manager --login-profile=user --user-data-dir=$UDD --disable-setuid-sandbox --no-sandbox --remote-debugging-port=9999 ) It will start with "Welcome" screen, just press Enter (Or click on "language selection button", which is focused by default), and observe that language selection dropdown is not focused.
,
May 2 2017
Investigating...
,
May 2 2017
@alemate: I am able to reproduce the issue, but wow can I get to the DevTools from that screen?
,
May 2 2017
+alemate, see question at previous comment.
,
May 2 2017
Fix is at https://codereview.chromium.org/2856933004 (see screenshot at http://imgur.com/a/ShyWe). I believe that this needs to be merged to M59 given that the original change https://codereview.chromium.org/2814813002 made it to the M59 branch.
,
May 3 2017
--remote-debugging-port=9999 means that you can open http://localhost:9999 and observe DevTools connected to ChromeOS browser.
,
May 3 2017
Marking this fixed. Requesting merge.
,
May 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c9acca9df826b31c2b58b50565172428396afb30 commit c9acca9df826b31c2b58b50565172428396afb30 Author: dpapad <dpapad@chromium.org> Date: Wed May 03 01:55:31 2017 ChromeOS OOBE: Fix language and keyboard md-select look. BUG= 716374 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2856933004 Cr-Commit-Position: refs/heads/master@{#468866} [modify] https://crrev.com/c9acca9df826b31c2b58b50565172428396afb30/chrome/browser/resources/chromeos/login/oobe_i18n_dropdown.css [modify] https://crrev.com/c9acca9df826b31c2b58b50565172428396afb30/chrome/browser/resources/chromeos/login/oobe_i18n_dropdown.html [modify] https://crrev.com/c9acca9df826b31c2b58b50565172428396afb30/chrome/browser/resources/chromeos/login/oobe_welcome.html
,
May 3 2017
,
May 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8042be7bc5dbed587fc25830558eaff396648d6b commit 8042be7bc5dbed587fc25830558eaff396648d6b Author: Alexander Alekseev <alemate@chromium.org> Date: Thu May 04 00:23:40 2017 ChromeOS OOBE: Fix language and keyboard md-select look. BUG= 716374 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2856933004 Cr-Commit-Position: refs/heads/master@{#468866} (cherry picked from commit c9acca9df826b31c2b58b50565172428396afb30) Review-Url: https://codereview.chromium.org/2862613004 . Cr-Commit-Position: refs/branch-heads/3071@{#389} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/8042be7bc5dbed587fc25830558eaff396648d6b/chrome/browser/resources/chromeos/login/oobe_i18n_dropdown.css [modify] https://crrev.com/8042be7bc5dbed587fc25830558eaff396648d6b/chrome/browser/resources/chromeos/login/oobe_i18n_dropdown.html [modify] https://crrev.com/8042be7bc5dbed587fc25830558eaff396648d6b/chrome/browser/resources/chromeos/login/oobe_welcome.html
,
May 5 2017
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 5 2017
This has been already merged.
,
May 8 2017
9460.30.0, 59.0.3071.41 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by alemate@chromium.org
, May 2 2017Owner: dpa...@chromium.org