New issue
Advanced search Search tips

Issue 716340 link

Starred by 1 user
Status: Fixed
Owner:
l...@chromium.org
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

DevTools: multiple copies of the 'Source map detected' infobar can appear

Project Member Reported by l...@chromium.org, Apr 28 2017 
What steps will reproduce the problem?
(1) Setup a project with the Persistence experiment enabled
(2) Open Sources with a minified file that has an associated sourcemap
(3) Refresh the inspected page multiple times

What is the expected result?
After opening the minified file, a 'Source map detected' infobar appears.  Refreshing should not produce more duplicates.

What happens instead?
For each page refresh, a new infobar appears.
tooManyInfobars2.PNG
45.0 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, May 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/15d1662e1a70f83a71e629aa7daa43c3d887dcd0

commit 15d1662e1a70f83a71e629aa7daa43c3d887dcd0
Author: luoe <luoe@chromium.org>
Date: Tue May 02 00:42:52 2017

DevTools: only show one source map infobar at a time

The 'Source map detected' infobar is created when a script with a sourcemap is
updated. When Persistence is enabled, this may happen each time the user
refreshes the page, resulting in many duplicate infobars.

This CL checks for an existing sourceMapInfobar before creating a new one, or
removes it if the updated script has no sourcemap.

BUG= 716340 

Review-Url: https://codereview.chromium.org/2851483003
Cr-Commit-Position: refs/heads/master@{#468509}

[modify] https://crrev.com/15d1662e1a70f83a71e629aa7daa43c3d887dcd0/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js
Project Member

Comment 2 by bugdroid1@chromium.org, May 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95800412eeae82fb9ebf3779c4b9846bd44e401b

commit 95800412eeae82fb9ebf3779c4b9846bd44e401b
Author: luoe <luoe@chromium.org>
Date: Tue May 02 22:28:33 2017

DevTools: appropriately hide the source map infobar

After changing source map infobar's trigger, a mistake in the logic led
to the infobar showing up even when it should not.

Logic changed in: https://codereview.chromium.org/2851483003

BUG= 716340 

Review-Url: https://codereview.chromium.org/2855963002
Cr-Commit-Position: refs/heads/master@{#468795}

[modify] https://crrev.com/95800412eeae82fb9ebf3779c4b9846bd44e401b/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js

Comment 3 by l...@chromium.org, May 2 2017

Status: Fixed (was: Started)
►

Sign in to add a comment