New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 716339 link

Starred by 1 user
Status: Fixed
Owner:
toyoshim@chromium.org
Closed: Jul 2017
Cc:
kinuko@chromium.org
█ kenjibaheux@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug

Blocking:
issue 719819



Sign in to add a comment

Add Location.reload behavior controlling flag

Project Member Reported by toyoshim@chromium.org, Apr 28 2017 
We have switched Location.reload() behavior to take a new light-weight reload that is aligned with the UX triggered reload at m57.

But, we tentatively disable it at m58 because we have seen some compatibility issues.

For m59+, we do not have a flag to turn down this new behavior any more, and this is hard to revert on TOT and beta branch.

As a backup plan, we will add a experiment-controlled feature to use hard-reload for Location.reload(). This will be disabled by default for a moment, but could be turned on at some point.

This change is intended to be merged to the beta channel of m59.

Comment 1 by toyoshim@chromium.org, Apr 28 2017

Labels: M-59
Set M-59 that means I will revert this change once the patch is merged to the m59 branch though I may run A/B testing for a while on m60 Canary.
Project Member

Comment 2 by bugdroid1@chromium.org, May 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9ff98be419da56e5586093be8113b28e3a018484

commit 9ff98be419da56e5586093be8113b28e3a018484
Author: toyoshim <toyoshim@chromium.org>
Date: Fri May 05 15:53:28 2017

Add an experimental flag to change location.reload to take a hard-reload

BUG= 716339 

Review-Url: https://codereview.chromium.org/2852433004
Cr-Commit-Position: refs/heads/master@{#469663}

[modify] https://crrev.com/9ff98be419da56e5586093be8113b28e3a018484/chrome/browser/about_flags.cc
[modify] https://crrev.com/9ff98be419da56e5586093be8113b28e3a018484/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/9ff98be419da56e5586093be8113b28e3a018484/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/9ff98be419da56e5586093be8113b28e3a018484/content/child/runtime_features.cc
[modify] https://crrev.com/9ff98be419da56e5586093be8113b28e3a018484/content/public/common/content_features.cc
[modify] https://crrev.com/9ff98be419da56e5586093be8113b28e3a018484/content/public/common/content_features.h
[modify] https://crrev.com/9ff98be419da56e5586093be8113b28e3a018484/third_party/WebKit/Source/core/frame/LocalFrame.cpp
[modify] https://crrev.com/9ff98be419da56e5586093be8113b28e3a018484/third_party/WebKit/Source/core/frame/Location.cpp
[modify] https://crrev.com/9ff98be419da56e5586093be8113b28e3a018484/third_party/WebKit/Source/core/loader/NavigationScheduler.cpp
[modify] https://crrev.com/9ff98be419da56e5586093be8113b28e3a018484/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5
[modify] https://crrev.com/9ff98be419da56e5586093be8113b28e3a018484/third_party/WebKit/Source/web/WebRuntimeFeatures.cpp
[modify] https://crrev.com/9ff98be419da56e5586093be8113b28e3a018484/third_party/WebKit/public/web/WebRuntimeFeatures.h
[modify] https://crrev.com/9ff98be419da56e5586093be8113b28e3a018484/tools/metrics/histograms/enums.xml

Comment 3 by toyoshim@chromium.org, May 5 2017

Labels: Merge-Request-59
Project Member

Comment 4 by sheriffbot@chromium.org, May 5 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, May 8 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6350639bdc2104efa8ac1fbbbfac712f1bbb3e02

commit 6350639bdc2104efa8ac1fbbbfac712f1bbb3e02
Author: toyoshim <toyoshim@chromium.org>
Date: Mon May 08 06:58:07 2017

Add an experimental flag to change location.reload to take a hard-reload

BUG= 716339 

Review-Url: https://codereview.chromium.org/2852433004
Cr-Commit-Position: refs/heads/master@{#469663}
(cherry picked from commit 9ff98be419da56e5586093be8113b28e3a018484)
TBR=toyoshim@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2865013002
Cr-Commit-Position: refs/branch-heads/3071@{#443}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/6350639bdc2104efa8ac1fbbbfac712f1bbb3e02/chrome/browser/about_flags.cc
[modify] https://crrev.com/6350639bdc2104efa8ac1fbbbfac712f1bbb3e02/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/6350639bdc2104efa8ac1fbbbfac712f1bbb3e02/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/6350639bdc2104efa8ac1fbbbfac712f1bbb3e02/content/child/runtime_features.cc
[modify] https://crrev.com/6350639bdc2104efa8ac1fbbbfac712f1bbb3e02/content/public/common/content_features.cc
[modify] https://crrev.com/6350639bdc2104efa8ac1fbbbfac712f1bbb3e02/content/public/common/content_features.h
[modify] https://crrev.com/6350639bdc2104efa8ac1fbbbfac712f1bbb3e02/third_party/WebKit/Source/core/frame/LocalFrame.cpp
[modify] https://crrev.com/6350639bdc2104efa8ac1fbbbfac712f1bbb3e02/third_party/WebKit/Source/core/frame/Location.cpp
[modify] https://crrev.com/6350639bdc2104efa8ac1fbbbfac712f1bbb3e02/third_party/WebKit/Source/core/loader/NavigationScheduler.cpp
[modify] https://crrev.com/6350639bdc2104efa8ac1fbbbfac712f1bbb3e02/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5
[modify] https://crrev.com/6350639bdc2104efa8ac1fbbbfac712f1bbb3e02/third_party/WebKit/Source/web/WebRuntimeFeatures.cpp
[modify] https://crrev.com/6350639bdc2104efa8ac1fbbbfac712f1bbb3e02/third_party/WebKit/public/web/WebRuntimeFeatures.h
[modify] https://crrev.com/6350639bdc2104efa8ac1fbbbfac712f1bbb3e02/tools/metrics/histograms/histograms.xml

Comment 6 by toyoshim@chromium.org, May 8 2017 

Client side change was done.

Now, we should have the experiment flag on m59 and m60.
But this is just for a backup plan. We do not have a plan to launch this feature, but could use this when we see a serious problem on location.reload.

An experiment for stability check will run on the canary and dev channels.

Comment 7 by toyoshim@chromium.org, May 9 2017

Blocking: 719819
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1185dc517718591270d6aff442f454f77ac0c4e6

commit 1185dc517718591270d6aff442f454f77ac0c4e6
Author: Takashi Toyoshima <toyoshim@chromium.org>
Date: Tue Jul 04 06:01:49 2017

Remove an experimental flag to change location.reload to take a hard-reload

This change reverts a change of https://crrev.com/469663.

BUG= 716339 

Change-Id: I5c20908c365353abbee5d8d20672a7b491680fdb
Reviewed-on: https://chromium-review.googlesource.com/558333
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484057}
[modify] https://crrev.com/1185dc517718591270d6aff442f454f77ac0c4e6/chrome/browser/about_flags.cc
[modify] https://crrev.com/1185dc517718591270d6aff442f454f77ac0c4e6/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/1185dc517718591270d6aff442f454f77ac0c4e6/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/1185dc517718591270d6aff442f454f77ac0c4e6/content/child/runtime_features.cc
[modify] https://crrev.com/1185dc517718591270d6aff442f454f77ac0c4e6/content/public/common/content_features.cc
[modify] https://crrev.com/1185dc517718591270d6aff442f454f77ac0c4e6/content/public/common/content_features.h
[modify] https://crrev.com/1185dc517718591270d6aff442f454f77ac0c4e6/third_party/WebKit/Source/core/frame/LocalFrame.cpp
[modify] https://crrev.com/1185dc517718591270d6aff442f454f77ac0c4e6/third_party/WebKit/Source/core/frame/Location.cpp
[modify] https://crrev.com/1185dc517718591270d6aff442f454f77ac0c4e6/third_party/WebKit/Source/core/loader/NavigationScheduler.cpp
[modify] https://crrev.com/1185dc517718591270d6aff442f454f77ac0c4e6/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5
[modify] https://crrev.com/1185dc517718591270d6aff442f454f77ac0c4e6/third_party/WebKit/Source/platform/exported/WebRuntimeFeatures.cpp
[modify] https://crrev.com/1185dc517718591270d6aff442f454f77ac0c4e6/third_party/WebKit/public/platform/WebRuntimeFeatures.h

Comment 9 by toyoshim@chromium.org, Jul 4 2017

Status: Fixed (was: Started)
►

Sign in to add a comment