New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 716324 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: May 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 688900



Sign in to add a comment

Cryptohome should output performance related info to log

Project Member Reported by hashimoto@chromium.org, Apr 28 2017

Issue description

It'd be useful if cryptohome outputs info like the total amount of data to the log to include them in feedback reports.
 
Blocking: 688900
Project Member

Comment 2 by bugdroid1@chromium.org, May 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/41da3335fe9bbd17cc9c201b6c802d08f479a3ef

commit 41da3335fe9bbd17cc9c201b6c802d08f479a3ef
Author: Ryo Hashimoto <hashimoto@google.com>
Date: Tue May 02 12:20:28 2017

cryptohome: Leave migration performance log

The log will look like:
 INFO cryptohomed[1541]: Migrating to dircrypto.
 INFO cryptohomed[1541]: Number of files: 14083
 INFO cryptohomed[1541]: Number of directories: 3845
 INFO cryptohomed[1541]: Number of symlinks: 15
 INFO cryptohomed[1541]: Preparation took 1524 ms.
 INFO cryptohomed[1541]: Migrated 1454637243 bytes in 226361 ms at 6426 KB/s.
 INFO cryptohomed[1541]: Migration done.

BUG= chromium:716324 
TEST=manually

Change-Id: I0eeadc2af4677cae8974b73e3c73e42a4a5eaec2
Reviewed-on: https://chromium-review.googlesource.com/484163
Commit-Ready: Ryo Hashimoto <hashimoto@chromium.org>
Tested-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Dan Spaid <dspaid@chromium.org>

[modify] https://crrev.com/41da3335fe9bbd17cc9c201b6c802d08f479a3ef/cryptohome/dircrypto_data_migrator/migration_helper.cc

Status: Fixed (was: Assigned)
Labels: Merge-Request-59

Comment 5 by gkihumba@google.com, May 12 2017

Labels: Merge-Approved-56
Project Member

Comment 6 by sheriffbot@chromium.org, May 13 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by bugdroid1@chromium.org, May 15 2017

Labels: merge-merged-release-R59-9460.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/ef7d8acf62dae076ce2ce65bf16268e631b26385

commit ef7d8acf62dae076ce2ce65bf16268e631b26385
Author: Ryo Hashimoto <hashimoto@google.com>
Date: Mon May 15 03:27:54 2017

cryptohome: Leave migration performance log

The log will look like:
 INFO cryptohomed[1541]: Migrating to dircrypto.
 INFO cryptohomed[1541]: Number of files: 14083
 INFO cryptohomed[1541]: Number of directories: 3845
 INFO cryptohomed[1541]: Number of symlinks: 15
 INFO cryptohomed[1541]: Preparation took 1524 ms.
 INFO cryptohomed[1541]: Migrated 1454637243 bytes in 226361 ms at 6426 KB/s.
 INFO cryptohomed[1541]: Migration done.

BUG= chromium:716324 
TEST=manually

Change-Id: I0eeadc2af4677cae8974b73e3c73e42a4a5eaec2
Reviewed-on: https://chromium-review.googlesource.com/484163
Commit-Ready: Ryo Hashimoto <hashimoto@chromium.org>
Tested-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Dan Spaid <dspaid@chromium.org>
(cherry picked from commit 41da3335fe9bbd17cc9c201b6c802d08f479a3ef)
Reviewed-on: https://chromium-review.googlesource.com/505972
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org>

[modify] https://crrev.com/ef7d8acf62dae076ce2ce65bf16268e631b26385/cryptohome/dircrypto_data_migrator/migration_helper.cc

Labels: -Hotlist-Merge-Approved -Merge-Approved-56 -Merge-Approved-59

Comment 9 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 10 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment