New issue
Advanced search Search tips

Issue 716322 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Right-click on My Drive directory loses keyboard focus from the directory list

Project Member Reported by yamaguchi@chromium.org, Apr 28 2017

Issue description

Chrome Version: ToT

Steps To Reproduce:
(1) Open Files app.
(2) Left-click or tap on "My Drive" in the directory list, then make sure files are listed on the right side, and that My Drive is focused (turns blue).
(3) Right-click or long-tap on "My Drive". See nothing happens.
(4) Hit down arrow key.
(5) Hit enter key.

Expected Result:
(4) The focus moves to the next item in the directory list (i.e. "Shared with me").
(5) Expands "My Drive" directory.

Actual Result:
(4) Nothing happens seemingly.
(5) "New Folder" is created.

How frequently does this problem reproduce? (Always, sometimes, hard to
reproduce?)
Always.

What is the impact to the user, and is there a workaround? If so, what is
it?
User can still retry operations that was affected by this bug.
The UI goes into a wrong state once, but subsequent click to another part of the UI component will reset the status.

 
This is caused because step (4) opens an invisible context menu with all items hidden. The subsequent steps triggers invisible "New folder" command.

Here is the logic to prevent showing context menu when no action is available,
https://cs.chromium.org/chromium/src/ui/webui/resources/js/cr/ui/context_menu_handler.js?l=42

but hasVisibleItems detects <hr> element as non-hidden item.
https://cs.chromium.org/chromium/src/ui/webui/resources/js/cr/ui/menu.js?type=cs&q=hasvisibleitems&l=194
Project Member

Comment 2 by bugdroid1@chromium.org, May 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bce3863fc28dc7a2b05eb37a1055b2d43f8002a8

commit bce3863fc28dc7a2b05eb37a1055b2d43f8002a8
Author: yamaguchi <yamaguchi@chromium.org>
Date: Tue May 02 02:00:13 2017

Prevent opening context menu with all items hidden.

TEST=none
TEST=manually tested as noted in the bug
BUG= 716322 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2850753002
Cr-Commit-Position: refs/heads/master@{#468531}

[modify] https://crrev.com/bce3863fc28dc7a2b05eb37a1055b2d43f8002a8/ui/webui/resources/js/cr/ui/menu.js

Status: Fixed (was: Available)
Status: Verified (was: Fixed)
Verified on TOT 9544.0.0, 60.0.3096.0 with steps from bug description

Sign in to add a comment