New issue
Advanced search Search tips

Issue 716314 link

Starred by 1 user

Issue metadata

Status: Closed
Owner:
Closed: Nov 9
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Searching in a MTP folder is slow if the folder has a lot of files

Project Member Reported by satorux@chromium.org, Apr 28 2017

Issue description


Steps To Reproduce:
(1) In Files app, navigate to a MTP holder that has ~2000 image files
(2) Click on the search box
(3) Type some query

Expected Result:

Search result is shown immediately

Actual Result:

Search is slow

How frequently does this problem reproduce? (Always, sometimes, hard to
reproduce?)

I'm guessing that the file list in the folder is re-fetched, which is slow on MTP, when initiating a search.
 
Status: Started (was: Assigned)
I'm writing CL to incrementally retrieve current directory listing between normal directory and search result. However, search result is recursive, so in this CL not everything is cached. The retrieved result is dropped when a user moves to another directory. 

I feel the CL is too complicated given the fact practically only MTP is benefited from this (In some cases result is still not shown properly so I'm debugging for this). The CL is still incomplete, but I would like to hear opinions for that.
https://codereview.chromium.org/2925663006/

For the number, the search speed becomes ~10s to below one second by this patch with ~2000 files MTP folder.
Status: Assigned (was: Started)

Comment 4 by tetsui@chromium.org, Dec 19 2017

Cc: tetsui@chromium.org
Owner: ----
Status: Available (was: Assigned)

Comment 5 by sashab@chromium.org, Feb 24 2018

Labels: CrOS-FilesApp-ExternalMedia

Comment 6 by sashab@chromium.org, Feb 28 2018

Labels: -CrOS-FilesApp-ExternalMedia CrOSFilesFeature-ExternalMedia
Labels: CrOSFilesCategory-Performance
Owner: amistry@chromium.org
Status: Closed (was: Available)
Cannot reproduce on M72. Search on a directory with ~1000 files is always fast. There's been lots of changes to both the file manager (i.e. metadata caching improvements) and MTP code.

Sign in to add a comment