Issue metadata
Sign in to add a comment
|
Rename references to "Website Settings popup" in Page Info string descriptions |
||||||||||||||||||||||||
Issue descriptionThere are some left, especially for permission names. I think my renaming script might have excluded them because they are not in C++ files. It seems leftover uses are in strings and also in histograms.xml.
,
Jun 7 2017
Issue 708691 has been merged into this issue.
,
Jun 9 2017
,
Jun 20 2017
sperigo@, would you be able to take this? We need to update the following occurrences of "Website Settings popup" to "Page Info poppup": https://cs.chromium.org/search/?q=%22Website+Settings+popup%22&sq=package:chromium&type=cs (Assigning to meacer@ for now, since sperigo@ needs to go through go/chromium-account processing.)
,
Jun 21 2017
lgarron@ meacer@ Sure! I'll look into it.
,
Jun 21 2017
Assigning to sperigo@chromium.org.
,
Jun 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/36adb726c5dc4a04d5064b6dca82f78f29aad6e9 commit 36adb726c5dc4a04d5064b6dca82f78f29aad6e9 Author: sperigo <sperigo@chromium.org> Date: Thu Jun 22 16:50:45 2017 Replace all instances of 'Website Settings popup' with 'Page Info popup.' BUG= 716300 Review-Url: https://codereview.chromium.org/2945193002 Cr-Commit-Position: refs/heads/master@{#481565} [modify] https://crrev.com/36adb726c5dc4a04d5064b6dca82f78f29aad6e9/components/page_info_strings.grdp [modify] https://crrev.com/36adb726c5dc4a04d5064b6dca82f78f29aad6e9/tools/metrics/histograms/histograms.xml
,
Jun 22 2017
Great! sperigo: Feel free to mark this one as Fixed.
,
Jun 22 2017
,
Jun 22 2017
Also adding release milestone. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by est...@chromium.org
, May 6 2017Owner: lgar...@chromium.org
Status: Assigned (was: Untriaged)