MD settings doesn't show profile icon at HiDPI res. |
|||||||||||||||
Issue descriptionChrome 59.0.3071.25 OSX 10.12.4 What steps will reproduce the problem? (1) Visit chrome://settings/ on a HiDPI screen. (2) Press the profile icon. What is the expected result? The profile icon in the viewport shows up as HiDPI. What happens instead? The profile icon shows at 1x. The hi-res profile icon is clearly available, though, because the dropdown in the upper-right is able to show it HiDPI at similar dimensions (see screenshots).
,
May 1 2017
How shortly are we talking? There is only one commit in Issue 708863 . It was on April 12, and does not seem to have addressed the HiDPI issue.
,
May 1 2017
dbeam@, https://codereview.chromium.org/2807373003 has a TODO about Issue 710660 for HiDPI, but that bug seems bot be about blue borders and implies high-res images are already implemented. But I'm clearly not seeing high-res images on Canary on my computer. Could you re-triage?
,
May 2 2017
,
May 2 2017
What happens if the page is refreshed. I'm asking because there was something previously observed were the first view of the icon was lower res, and subsequent views are hires. I'm wondering if that's happening in this case or whether it's consistently low res.
,
May 2 2017
> What happens if the page is refreshed. Still low-res on: - Chrome 60.0.3087.0 - OSX 10.12.4 - 4K external monitor driven @2x. (Even if I refresh the page.)
,
May 2 2017
able to reproduce on Linux via --force-device-scale-factor=2
,
May 2 2017
i think just sending the avatar icon at the web UI's device scale factor is probably sufficient here (there's also zoom and other little bits to account for, but it's less big of a deal, IMO). here's a pretty simple fix for that: https://codereview.chromium.org/2857753003 for what it's worth: the user switcher (which is always showing on the top of the browser frame) seems to be 1x and it's probably been like this for a long time... so this probably isn't the end of the world (but maybe it's just not respecting a forced device scale factor?)
,
May 2 2017
> and other little bits to account for Also, dragging a window from a 1x monitor to a 2x monitor. But it seems `srcset` doesn't handle that in other web content, so I won't be too sad if we don't handle that case. ;-) > for what it's worth: the user switcher (which is always showing on the top of the browser frame) seems to be 1x I presume you mean on Linux, right? (On Mac, 2x works correctly; see the screenshots in the first post.)
,
May 2 2017
the user switcher icon** (the blurry little head and shoulders, my last attachment)
,
May 2 2017
> Also, dragging a window from a 1x monitor to a 2x monitor. that, putting something half on two monitors, page zoom, pinch zoom, etc. etc.
,
May 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5e3e6c3816510119e1c71f53f2f9b01459cfd0ca commit 5e3e6c3816510119e1c71f53f2f9b01459cfd0ca Author: dbeam <dbeam@chromium.org> Date: Wed May 03 00:20:58 2017 MD Settings: make avatar icon account for scale factor R=tommycli@chromium.org BUG= 716269 Review-Url: https://codereview.chromium.org/2857753003 Cr-Commit-Position: refs/heads/master@{#468831} [modify] https://crrev.com/5e3e6c3816510119e1c71f53f2f9b01459cfd0ca/chrome/browser/ui/webui/settings/profile_info_handler.cc
,
May 3 2017
,
May 4 2017
Tested the issue on Windows-10 (HiDPI),Mac Retina-10.12.4 and Linux Ubuntu-14.04 (HiDPI) using chrome version 60.0.3088.3 with the steps mentioned in comment#0. Observed that the profile icon displayed same as avatar icon. Please find the attached screen cast and please confirm the expected behavior. Thanks.
,
May 4 2017
|
|||||||||||||||
►
Sign in to add a comment |
|||||||||||||||
Comment 1 by tbuck...@chromium.org
, May 1 2017Status: Duplicate (was: Untriaged)