New issue
Advanced search Search tips

Issue 716257 link

Starred by 3 users
Status: Fixed
Owner:
calamity@chromium.org
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug


Show other hotlists

Hotlists containing this issue:
Hotlist-1
Hotlist-2


Sign in to add a comment

[MD Bookmarks] Dragging bookmarks on Mac can open bookmark rather than move it

Project Member Reported by tsergeant@chromium.org, Apr 27 2017 
Per bettes@, on Canary 60.0.3082.0 on Mac

From bookmarks bar folder to webUI (sidebar and content area): opens bookmark

Side bar > bookmarks bar: WAI
Side bar folder > side bar folder: opens bookmark

Content area > bookmarks bar: WAI
Content area > side bar: opens bookmark
Content area > content area: opens bookmark
Project Member

Comment 1 by bugdroid1@chromium.org, May 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/279fda406f81bcae7eba482b11806f106fab7b2e

commit 279fda406f81bcae7eba482b11806f106fab7b2e
Author: calamity <calamity@chromium.org>
Date: Mon May 01 04:21:58 2017

[MD Bookmarks] Fix drag and drop on Mac.

This CL fixes an issue where drag and drop wouldn't work on Mac because
the drop data was being cleared by the bookmark manager API's drop
handler before the bookmark manager's handler had handled the drop. This
has been fixed by adding a setTimeout to clearing the data, which was
also in the old bookmark manager, giving the bookmark manager a chance
to deal with the drop.

BUG= 716257 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2845243003
Cr-Commit-Position: refs/heads/master@{#468281}

[modify] https://crrev.com/279fda406f81bcae7eba482b11806f106fab7b2e/chrome/browser/resources/md_bookmarks/dnd_manager.js
[modify] https://crrev.com/279fda406f81bcae7eba482b11806f106fab7b2e/chrome/test/data/webui/md_bookmarks/dnd_manager_test.js
Project Member

Comment 2 by bugdroid1@chromium.org, May 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/99175652a133cca12297714b2cfbfc89b910cba3

commit 99175652a133cca12297714b2cfbfc89b910cba3
Author: calamity <calamity@chromium.org>
Date: Tue May 02 07:21:21 2017

[MD Bookmarks] Fix Drag and drop timer.

This CL fixes a misnamed member in the drag and drop manager.

BUG= 716257 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2853973002
Cr-Commit-Position: refs/heads/master@{#468578}

[modify] https://crrev.com/99175652a133cca12297714b2cfbfc89b910cba3/chrome/browser/resources/md_bookmarks/dnd_manager.js

Comment 3 by tsergeant@chromium.org, May 3 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment