New issue
Advanced search Search tips

Issue 716255 link

Starred by 0 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

depot_tools/git_common.py should use 'git worktree' instead of symlinks

Project Member Reported by aga...@chromium.org, Apr 27 2017

Issue description

When git_common creates a new workdir, it does so by whitelisting a bunch of files, creating a temp directory, and then symlinking those files into the .git directory. It's a little bit crazy, and prone to bizarre failure modes.

It should instead use 'git worktree', the built-in solution for having multiple checkouts pointing at a single set of objects. This also makes cleanup easier, and prevents any branches created in the temp workdir from polluting the parent repo's namespace.
 
Cc: -iannucci@chromium.org iannu...@google.com
Status: Available (was: Untriaged)

Sign in to add a comment