mash: Language/Keyboard select drop down does not show up |
||||||
Issue descriptionRepro: 1. Run OOBE with --mash; 2. Click on Language on lower left corner of welcome screen; 3. Try to select language or keyboard On step 3, nothing happens when clicking on the two elements. Select element seems working fine elsewhere (e.g. in a tab).
,
Feb 26 2018
,
Aug 1
,
Aug 15
Xiyuan, is this still an issue?
,
Aug 15
Yes, still a problem that pop up is put behind the renderer's window. And it is worse than before because Oobe webui is not full screen.
,
Dec 19
Think we need to resolve this for M73. We need to figure out a proper way to make popup RWHVAura a transient child of its parent RWHVAura. aura::client::GetTransientWindowClient [1] is nullptr under mash. [1] https://cs.chromium.org/chromium/src/content/browser/renderer_host/render_widget_host_view_aura.cc?rcl=dbb96a90540551b2878b7b0dd4fbfca7ef0ff0cf&l=432
,
Dec 19
Scrape #6. It turns out transient window handling works as expected. The problem is aura::client::ParentWindowWithContext in L456 does not create the popup as menu properly.
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5457d7e5a384a974af55dbb68b063fb031c720ed commit 5457d7e5a384a974af55dbb68b063fb031c720ed Author: Xiyuan Xia <xiyuan@chromium.org> Date: Wed Dec 19 20:51:00 2018 mash: Use TYPE_MENU for parent of a RWHVAura menu popup DesktopNativeWidgetTopLevelHandler::CreateParentWindow use TYPE_MENU to create parent for RWHVAura menu popup. This matches the classic behavior and fixes the problem on ChromeOS OOBE screen. Bug: 716233 Change-Id: Ifcfe23ab80e4741f3d629180c6b54ebe0acd727d Reviewed-on: https://chromium-review.googlesource.com/c/1384633 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#617943} [modify] https://crrev.com/5457d7e5a384a974af55dbb68b063fb031c720ed/ui/views/widget/desktop_aura/desktop_native_widget_aura.cc
,
Dec 19
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by xiy...@chromium.org
, Dec 12 201742.2 KB
42.2 KB View Download