New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 716224 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Show zero-query when expanding sheet via omnibox focus

Project Member Reported by mdjones@chromium.org, Apr 27 2017

Issue description

To avoid excessive animations when the omnibox is focused, the omnibox-suggestions should show in place of the zine content.
 
Attaching video with current behavior.

When the omnibox is focused from the peeking state, the suggestions content will not be shown. If focused from any other state, the existing content will be shown.
recording.mp4
2.8 MB View Download

Comment 2 by cl...@chromium.org, May 4 2017

I think we should return the previous, pre-Chrome Home behavior here. Show the most likely sites text-based UI when the omnibox is initially focused or empty.

Comment 3 by cl...@chromium.org, May 4 2017

(regardless of where the omnibox is focused from)

Comment 4 by k...@chromium.org, May 5 2017

Interesting - I can see how it addresses the challenge of excessive animation though I am curious to see how it will impact interaction with zero-query overall. I'm good with returning to previous pre-Chrome Home behavior for now though. If you close the keyboard, would it reveal Chrome Home again?

Comment 5 by cl...@chromium.org, May 5 2017

Yes, unfocusing the omnibox / closing the keyboard would show Chrome Home.
The pre-chrome-home behavior isn't exactly the same. There was a bug that caused zero-suggest to appear on the NTP and google results page when they shouldn't have. In these cases should we just show the bottom sheet content?

Comment 7 by k...@chromium.org, May 8 2017

Sounds reasonable to me. Why don't we show it on Google results pages?

Comment 8 by k...@chromium.org, May 8 2017

Labels: -Pri-2 Hotlist-Chrome-Home Pri-1
New Mocks courtesy of Chris: https://folio.googleplex.com/bijou-cleer/161018-Flow#%2FOmnibox.png%3Fc=show
Attaching video with just zero-suggest reenabled. Notably, you still see the content flash before the suggestions show up.
recording.mp4
4.2 MB View Download
Project Member

Comment 10 by bugdroid1@chromium.org, May 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9fc5a9b20adc654cbf6021ba20d6d5931b6f519

commit b9fc5a9b20adc654cbf6021ba20d6d5931b6f519
Author: mdjones <mdjones@chromium.org>
Date: Fri May 12 18:22:53 2017

[Home] Placeholder sheet content for omnibox focus

When the omnibox is being focused from the sheet's peeking state, the
bottom sheet content will be hidden to avoid excessive visual noise.
When the omnibox loses focus, the content is replaced by the
suggestions content. If the sheet is already expanded when the omnibox
is focused, the content will remain visible.

This change also re-enables zero-suggest for Chrome Home.

BUG= 716224 

Review-Url: https://codereview.chromium.org/2876093002
Cr-Commit-Position: refs/heads/master@{#471372}

[modify] https://crrev.com/b9fc5a9b20adc654cbf6021ba20d6d5931b6f519/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
[modify] https://crrev.com/b9fc5a9b20adc654cbf6021ba20d6d5931b6f519/chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarPhone.java
[modify] https://crrev.com/b9fc5a9b20adc654cbf6021ba20d6d5931b6f519/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheet.java
[modify] https://crrev.com/b9fc5a9b20adc654cbf6021ba20d6d5931b6f519/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetContentController.java
[modify] https://crrev.com/b9fc5a9b20adc654cbf6021ba20d6d5931b6f519/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetMetrics.java
[add] https://crrev.com/b9fc5a9b20adc654cbf6021ba20d6d5931b6f519/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/PlaceholderSheetContent.java
[modify] https://crrev.com/b9fc5a9b20adc654cbf6021ba20d6d5931b6f519/chrome/android/java_sources.gni

Comment 11 by cl...@chromium.org, May 12 2017

Yeah, we'll need to remove that flash. Also, tapping the back button should close the panel immediately and return to the page, not go to the Home screen. The way to get to the Home screen from the omnibox zero query UI should be the bottom nav bar, once issue 706249 is fixed.
Project Member

Comment 12 by bugdroid1@chromium.org, May 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e309521b316083148b2b2073fb589a086e010bc7

commit e309521b316083148b2b2073fb589a086e010bc7
Author: mdjones <mdjones@chromium.org>
Date: Fri May 19 16:45:20 2017

[Home] Hide sheet when back pressed

This change allows a single press of the back button to close the
bottom sheet if expanded via omnibox focus. This allows a user to
easily return to the page if they decide against using the omnibox.

The mechanism for detecting this case is simple: if the placeholder
content is showing, defocus and hide everything with one press. The
reason this works is because the placeholder sheet content will only
be showing if the user expanded the sheet from the peeking state by
focusing the omnibox.

BUG= 716224 

Review-Url: https://codereview.chromium.org/2896483003
Cr-Commit-Position: refs/heads/master@{#473212}

[modify] https://crrev.com/e309521b316083148b2b2073fb589a086e010bc7/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarPhone.java

Status: Fixed (was: Assigned)

Sign in to add a comment