Show zero-query when expanding sheet via omnibox focus |
|||
Issue descriptionTo avoid excessive animations when the omnibox is focused, the omnibox-suggestions should show in place of the zine content.
,
May 4 2017
I think we should return the previous, pre-Chrome Home behavior here. Show the most likely sites text-based UI when the omnibox is initially focused or empty.
,
May 4 2017
(regardless of where the omnibox is focused from)
,
May 5 2017
Interesting - I can see how it addresses the challenge of excessive animation though I am curious to see how it will impact interaction with zero-query overall. I'm good with returning to previous pre-Chrome Home behavior for now though. If you close the keyboard, would it reveal Chrome Home again?
,
May 5 2017
Yes, unfocusing the omnibox / closing the keyboard would show Chrome Home.
,
May 8 2017
The pre-chrome-home behavior isn't exactly the same. There was a bug that caused zero-suggest to appear on the NTP and google results page when they shouldn't have. In these cases should we just show the bottom sheet content?
,
May 8 2017
Sounds reasonable to me. Why don't we show it on Google results pages?
,
May 8 2017
New Mocks courtesy of Chris: https://folio.googleplex.com/bijou-cleer/161018-Flow#%2FOmnibox.png%3Fc=show
,
May 11 2017
Attaching video with just zero-suggest reenabled. Notably, you still see the content flash before the suggestions show up.
,
May 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b9fc5a9b20adc654cbf6021ba20d6d5931b6f519 commit b9fc5a9b20adc654cbf6021ba20d6d5931b6f519 Author: mdjones <mdjones@chromium.org> Date: Fri May 12 18:22:53 2017 [Home] Placeholder sheet content for omnibox focus When the omnibox is being focused from the sheet's peeking state, the bottom sheet content will be hidden to avoid excessive visual noise. When the omnibox loses focus, the content is replaced by the suggestions content. If the sheet is already expanded when the omnibox is focused, the content will remain visible. This change also re-enables zero-suggest for Chrome Home. BUG= 716224 Review-Url: https://codereview.chromium.org/2876093002 Cr-Commit-Position: refs/heads/master@{#471372} [modify] https://crrev.com/b9fc5a9b20adc654cbf6021ba20d6d5931b6f519/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java [modify] https://crrev.com/b9fc5a9b20adc654cbf6021ba20d6d5931b6f519/chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarPhone.java [modify] https://crrev.com/b9fc5a9b20adc654cbf6021ba20d6d5931b6f519/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheet.java [modify] https://crrev.com/b9fc5a9b20adc654cbf6021ba20d6d5931b6f519/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetContentController.java [modify] https://crrev.com/b9fc5a9b20adc654cbf6021ba20d6d5931b6f519/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetMetrics.java [add] https://crrev.com/b9fc5a9b20adc654cbf6021ba20d6d5931b6f519/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/PlaceholderSheetContent.java [modify] https://crrev.com/b9fc5a9b20adc654cbf6021ba20d6d5931b6f519/chrome/android/java_sources.gni
,
May 12 2017
Yeah, we'll need to remove that flash. Also, tapping the back button should close the panel immediately and return to the page, not go to the Home screen. The way to get to the Home screen from the omnibox zero query UI should be the bottom nav bar, once issue 706249 is fixed.
,
May 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e309521b316083148b2b2073fb589a086e010bc7 commit e309521b316083148b2b2073fb589a086e010bc7 Author: mdjones <mdjones@chromium.org> Date: Fri May 19 16:45:20 2017 [Home] Hide sheet when back pressed This change allows a single press of the back button to close the bottom sheet if expanded via omnibox focus. This allows a user to easily return to the page if they decide against using the omnibox. The mechanism for detecting this case is simple: if the placeholder content is showing, defocus and hide everything with one press. The reason this works is because the placeholder sheet content will only be showing if the user expanded the sheet from the peeking state by focusing the omnibox. BUG= 716224 Review-Url: https://codereview.chromium.org/2896483003 Cr-Commit-Position: refs/heads/master@{#473212} [modify] https://crrev.com/e309521b316083148b2b2073fb589a086e010bc7/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarPhone.java
,
May 24 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by mdjones@chromium.org
, May 3 20172.8 MB
2.8 MB View Download