New issue
Advanced search Search tips

Issue 716222 link

Starred by 2 users
Status: Fixed
Owner:
bsep@chromium.org
Closed: Sep 2017
Cc:
kylixrd@chromium.org
pkasting@chromium.org
Components:
EstimatedDays: ----
NextAction: 2017-09-29
OS: ----
Pri: 1
Type: Bug
Launch-M-Target: 64-Beta



Sign in to add a comment

Harmony - Implement variable padding between content and buttons

Project Member Reported by bsep@chromium.org, Apr 27 2017 
In the current spec we have either 16dips or 24dips of padding between the dialog content and the buttons, depending on whether the content is only text or has controls, respectively. Since right now the code is set up to assume content padding is either a fixed default or entirely ad-hoc, this will require some refactoring.
Project Member

Comment 1 by bugdroid1@chromium.org, May 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a42af916f8540c65e68d780e37bc07a8230eb5ba

commit a42af916f8540c65e68d780e37bc07a8230eb5ba
Author: bsep <bsep@chromium.org>
Date: Wed May 10 19:49:23 2017

Remove GridLayout::SetInsets in favor of an empty border on the host.

GridLayout::SetInsets is a way of introducing whitespace around the
edges of a view. However we normally accomplish that by setting an empty
border on the view instead. This patch changes all usages of the former
to the latter, and then deletes the method.

BUG= 716222 

Review-Url: https://codereview.chromium.org/2859193004
Cr-Commit-Position: refs/heads/master@{#470675}

[modify] https://crrev.com/a42af916f8540c65e68d780e37bc07a8230eb5ba/ash/shell/window_type_launcher.cc
[modify] https://crrev.com/a42af916f8540c65e68d780e37bc07a8230eb5ba/chrome/browser/chromeos/profiles/multiprofiles_session_aborted_dialog.cc
[modify] https://crrev.com/a42af916f8540c65e68d780e37bc07a8230eb5ba/chrome/browser/ui/views/collected_cookies_views.cc
[modify] https://crrev.com/a42af916f8540c65e68d780e37bc07a8230eb5ba/chrome/browser/ui/views/cookie_info_view.cc
[modify] https://crrev.com/a42af916f8540c65e68d780e37bc07a8230eb5ba/chrome/browser/ui/views/desktop_ios_promotion/desktop_ios_promotion_bubble_view.cc
[modify] https://crrev.com/a42af916f8540c65e68d780e37bc07a8230eb5ba/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc
[modify] https://crrev.com/a42af916f8540c65e68d780e37bc07a8230eb5ba/chrome/browser/ui/views/first_run_bubble.cc
[modify] https://crrev.com/a42af916f8540c65e68d780e37bc07a8230eb5ba/chrome/browser/ui/views/payments/cvc_unmask_view_controller.cc
[modify] https://crrev.com/a42af916f8540c65e68d780e37bc07a8230eb5ba/chrome/browser/ui/views/payments/editor_view_controller.cc
[modify] https://crrev.com/a42af916f8540c65e68d780e37bc07a8230eb5ba/chrome/browser/ui/views/payments/order_summary_view_controller.cc
[modify] https://crrev.com/a42af916f8540c65e68d780e37bc07a8230eb5ba/chrome/browser/ui/views/payments/payment_request_item_list.cc
[modify] https://crrev.com/a42af916f8540c65e68d780e37bc07a8230eb5ba/chrome/browser/ui/views/payments/payment_request_row_view.cc
[modify] https://crrev.com/a42af916f8540c65e68d780e37bc07a8230eb5ba/chrome/browser/ui/views/payments/payment_request_row_view.h
[modify] https://crrev.com/a42af916f8540c65e68d780e37bc07a8230eb5ba/chrome/browser/ui/views/payments/payment_request_sheet_controller.cc
[modify] https://crrev.com/a42af916f8540c65e68d780e37bc07a8230eb5ba/chrome/browser/ui/views/payments/payment_request_views_util.cc
[modify] https://crrev.com/a42af916f8540c65e68d780e37bc07a8230eb5ba/chrome/browser/ui/views/payments/payment_request_views_util.h
[modify] https://crrev.com/a42af916f8540c65e68d780e37bc07a8230eb5ba/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc
[modify] https://crrev.com/a42af916f8540c65e68d780e37bc07a8230eb5ba/chrome/browser/ui/views/profiles/profile_chooser_view.cc
[modify] https://crrev.com/a42af916f8540c65e68d780e37bc07a8230eb5ba/chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.cc
[modify] https://crrev.com/a42af916f8540c65e68d780e37bc07a8230eb5ba/mash/catalog_viewer/catalog_viewer.cc
[modify] https://crrev.com/a42af916f8540c65e68d780e37bc07a8230eb5ba/mash/example/window_type_launcher/window_type_launcher.cc
[modify] https://crrev.com/a42af916f8540c65e68d780e37bc07a8230eb5ba/ui/message_center/views/message_center_button_bar.cc
[modify] https://crrev.com/a42af916f8540c65e68d780e37bc07a8230eb5ba/ui/message_center/views/message_center_view_unittest.cc
[modify] https://crrev.com/a42af916f8540c65e68d780e37bc07a8230eb5ba/ui/views/layout/grid_layout.cc
[modify] https://crrev.com/a42af916f8540c65e68d780e37bc07a8230eb5ba/ui/views/layout/grid_layout.h
[modify] https://crrev.com/a42af916f8540c65e68d780e37bc07a8230eb5ba/ui/views/layout/grid_layout_unittest.cc
Project Member

Comment 2 by bugdroid1@chromium.org, May 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd45e5f7692fe435bfaa61981ecf56724ab4e31a

commit dd45e5f7692fe435bfaa61981ecf56724ab4e31a
Author: bsep <bsep@chromium.org>
Date: Wed May 24 02:45:01 2017

Renamed INSETS_PANEL to INSETS_DIALOG_CONTENTS. Renamed
INSETS_DIALOG_BUTTON to INSETS_DIALOG_BUTTON_ROW, and made it have a 0
top inset in Harmony to fix the double-wide margin between the
content and button row.

Defined most insets metrics in terms of distance metrics, and removed
their overrides from HarmonyLayoutProvider since they would now be
redundant.

Renamed DISTANCE_DIALOG_BUTTON_MARGIN to
DISTANCE_DIALOG_BUTTON_BOTTOM_MARGIN. Some callsites were using this
metric to mean "dialog content left/right margin" and those were
changed to use a new metric, DISTANCE_DIALOG_CONTENTS_HORIZONTAL_MARGIN.

Split DISTANCE_PANEL_CONTENT_MARGIN into three different metrics
depending on what the callsite actually meant (though all three have the
same ultimate value):
* DISTANCE_BUBBLE_CONTENTS_HORIZONTAL_MARGIN
* DISTANCE_BUBBLE_CONTENTS_VERTICAL_MARGIN
* DISTANCE_DIALOG_CONTENTS_VERTICAL_MARGIN

Opportunistically changed some usages of layout_constants.cc constants
to LayoutProvider metrics.

BUG= 716222 

Review-Url: https://codereview.chromium.org/2888563004
Cr-Commit-Position: refs/heads/master@{#474135}

[modify] https://crrev.com/dd45e5f7692fe435bfaa61981ecf56724ab4e31a/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc
[modify] https://crrev.com/dd45e5f7692fe435bfaa61981ecf56724ab4e31a/chrome/browser/ui/views/arc_app_dialog_view.cc
[modify] https://crrev.com/dd45e5f7692fe435bfaa61981ecf56724ab4e31a/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc
[modify] https://crrev.com/dd45e5f7692fe435bfaa61981ecf56724ab4e31a/chrome/browser/ui/views/cookie_info_view.cc
[modify] https://crrev.com/dd45e5f7692fe435bfaa61981ecf56724ab4e31a/chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc
[modify] https://crrev.com/dd45e5f7692fe435bfaa61981ecf56724ab4e31a/chrome/browser/ui/views/desktop_ios_promotion/desktop_ios_promotion_bubble_view.cc
[modify] https://crrev.com/dd45e5f7692fe435bfaa61981ecf56724ab4e31a/chrome/browser/ui/views/extensions/chooser_dialog_view.cc
[modify] https://crrev.com/dd45e5f7692fe435bfaa61981ecf56724ab4e31a/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc
[modify] https://crrev.com/dd45e5f7692fe435bfaa61981ecf56724ab4e31a/chrome/browser/ui/views/extensions/extension_uninstall_dialog_view.cc
[modify] https://crrev.com/dd45e5f7692fe435bfaa61981ecf56724ab4e31a/chrome/browser/ui/views/extensions/media_galleries_dialog_views.cc
[modify] https://crrev.com/dd45e5f7692fe435bfaa61981ecf56724ab4e31a/chrome/browser/ui/views/extensions/media_gallery_checkbox_view.cc
[modify] https://crrev.com/dd45e5f7692fe435bfaa61981ecf56724ab4e31a/chrome/browser/ui/views/extensions/request_file_system_dialog_view.cc
[modify] https://crrev.com/dd45e5f7692fe435bfaa61981ecf56724ab4e31a/chrome/browser/ui/views/harmony/chrome_layout_provider.cc
[modify] https://crrev.com/dd45e5f7692fe435bfaa61981ecf56724ab4e31a/chrome/browser/ui/views/harmony/chrome_layout_provider.h
[modify] https://crrev.com/dd45e5f7692fe435bfaa61981ecf56724ab4e31a/chrome/browser/ui/views/harmony/harmony_layout_provider.cc
[modify] https://crrev.com/dd45e5f7692fe435bfaa61981ecf56724ab4e31a/chrome/browser/ui/views/importer/import_lock_dialog_view.cc
[modify] https://crrev.com/dd45e5f7692fe435bfaa61981ecf56724ab4e31a/chrome/browser/ui/views/page_info/page_info_bubble_view.cc
[modify] https://crrev.com/dd45e5f7692fe435bfaa61981ecf56724ab4e31a/chrome/browser/ui/views/passwords/account_chooser_dialog_view.cc
[modify] https://crrev.com/dd45e5f7692fe435bfaa61981ecf56724ab4e31a/chrome/browser/ui/views/passwords/auto_signin_first_run_dialog_view.cc
[modify] https://crrev.com/dd45e5f7692fe435bfaa61981ecf56724ab4e31a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
[modify] https://crrev.com/dd45e5f7692fe435bfaa61981ecf56724ab4e31a/chrome/browser/ui/views/settings_reset_prompt_dialog.cc
[modify] https://crrev.com/dd45e5f7692fe435bfaa61981ecf56724ab4e31a/chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.cc
[modify] https://crrev.com/dd45e5f7692fe435bfaa61981ecf56724ab4e31a/chrome/browser/ui/views/task_manager_view.cc
[modify] https://crrev.com/dd45e5f7692fe435bfaa61981ecf56724ab4e31a/chrome/browser/ui/views/webshare/webshare_target_picker_view.cc
[modify] https://crrev.com/dd45e5f7692fe435bfaa61981ecf56724ab4e31a/ui/views/layout/grid_layout.cc
[modify] https://crrev.com/dd45e5f7692fe435bfaa61981ecf56724ab4e31a/ui/views/layout/layout_provider.cc
[modify] https://crrev.com/dd45e5f7692fe435bfaa61981ecf56724ab4e31a/ui/views/layout/layout_provider.h
[modify] https://crrev.com/dd45e5f7692fe435bfaa61981ecf56724ab4e31a/ui/views/window/dialog_client_view.cc

Comment 3 by abdulsyed@google.com, Sep 5 2017

Labels: Launch-M-Target-64-Beta
NextAction: 2017-09-29
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f9851702f1fd544b8f15f522e511595d74f74c6

commit 9f9851702f1fd544b8f15f522e511595d74f74c6
Author: Bret Sepulveda <bsep@chromium.org>
Date: Fri Sep 08 23:12:04 2017

Harmony - give dialogs variable margins around their content.

For Harmony we want to have the margin around dialog content vary.
Specifically we want the margin between the title and the content vary
depending on the type of the first UI element, and the margin between
the content and the buttons vary depending on type of the last UI
element. We give a smaller margin to text-type elements and a larger one
to control-type elements.

This patch implements that feature for all dialogs. Subclasses of
DialogDelegateView have no default margins and thus were given a best
guess as to the correct margins. Subclasses of BubbleDialogDelegateView
were given a default margin to be overriden by specific dialogs.

TBR=sky@chromium.org

Bug:  716222 
Change-Id: I407c6cc75f4baa0e0e71c80dc0583908f19ad468
Reviewed-on: https://chromium-review.googlesource.com/651906
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500729}
[modify] https://crrev.com/9f9851702f1fd544b8f15f522e511595d74f74c6/ash/system/session/logout_confirmation_dialog.cc
[modify] https://crrev.com/9f9851702f1fd544b8f15f522e511595d74f74c6/chrome/browser/chromeos/attestation/platform_verification_dialog.cc
[modify] https://crrev.com/9f9851702f1fd544b8f15f522e511595d74f74c6/chrome/browser/chromeos/enrollment_dialog_view.cc
[modify] https://crrev.com/9f9851702f1fd544b8f15f522e511595d74f74c6/chrome/browser/chromeos/options/vpn_config_view.cc
[modify] https://crrev.com/9f9851702f1fd544b8f15f522e511595d74f74c6/chrome/browser/chromeos/options/wifi_config_view.cc
[modify] https://crrev.com/9f9851702f1fd544b8f15f522e511595d74f74c6/chrome/browser/chromeos/options/wimax_config_view.cc
[modify] https://crrev.com/9f9851702f1fd544b8f15f522e511595d74f74c6/chrome/browser/chromeos/power/idle_action_warning_dialog_view.cc
[modify] https://crrev.com/9f9851702f1fd544b8f15f522e511595d74f74c6/chrome/browser/chromeos/ui/request_pin_view.cc
[modify] https://crrev.com/9f9851702f1fd544b8f15f522e511595d74f74c6/chrome/browser/ui/views/accessibility/invert_bubble_view.cc
[modify] https://crrev.com/9f9851702f1fd544b8f15f522e511595d74f74c6/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc
[modify] https://crrev.com/9f9851702f1fd544b8f15f522e511595d74f74c6/chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.cc
[modify] https://crrev.com/9f9851702f1fd544b8f15f522e511595d74f74c6/chrome/browser/ui/views/apps/app_info_dialog/app_info_header_panel.cc
[modify] https://crrev.com/9f9851702f1fd544b8f15f522e511595d74f74c6/chrome/browser/ui/views/arc_app_dialog_view.cc
[modify] https://crrev.com/9f9851702f1fd544b8f15f522e511595d74f74c6/chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc
[modify] https://crrev.com/9f9851702f1fd544b8f15f522e511595d74f74c6/chrome/browser/ui/views/certificate_selector.cc
[modify] https://crrev.com/9f9851702f1fd544b8f15f522e511595d74f74c6/chrome/browser/ui/views/chrome_cleaner_dialog_win.cc
[modify] https://crrev.com/9f9851702f1fd544b8f15f522e511595d74f74c6/chrome/browser/ui/views/collected_cookies_views.cc
[modify] https://crrev.com/9f9851702f1fd544b8f15f522e511595d74f74c6/chrome/browser/ui/views/confirm_bubble_views.cc
[modify] https://crrev.com/9f9851702f1fd544b8f15f522e511595d74f74c6/chrome/browser/ui/views/content_setting_bubble_contents.cc
[modify] https://crrev.com/9f9851702f1fd544b8f15f522e511595d74f74c6/chrome/browser/ui/views/create_application_shortcut_view.cc
[modify] https://crrev.com/9f9851702f1fd544b8f15f522e511595d74f74c6/chrome/browser/ui/views/create_application_shortcut_view.h
[modify] https://crrev.com/9f9851702f1fd544b8f15f522e511595d74f74c6/chrome/browser/ui/views/crypto_module_password_dialog_view.cc
[modify] https://crrev.com/9f9851702f1fd544b8f15f522e511595d74f74c6/chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc
[modify] https://crrev.com/9f9851702f1fd544b8f15f522e511595d74f74c6/chrome/browser/ui/views/download/download_danger_prompt_views.cc
[modify] https://crrev.com/9f9851702f1fd544b8f15f522e511595d74f74c6/chrome/browser/ui/views/extensions/bookmark_app_confirmation_view.cc
[modify] https://crrev.com/9f9851702f1fd544b8f15f522e511595d74f74c6/chrome/browser/ui/views/extensions/chooser_dialog_view.cc
[modify] https://crrev.com/9f9851702f1fd544b8f15f522e511595d74f74c6/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc
[modify] https://crrev.com/9f9851702f1fd544b8f15f522e511595d74f74c6/chrome/browser/ui/views/extensions/extension_uninstall_dialog_view.cc
[modify] https://crrev.com/9f9851702f1fd544b8f15f522e511595d74f74c6/chrome/browser/ui/views/extensions/media_galleries_dialog_views.cc
[modify] https://crrev.com/9f9851702f1fd544b8f15f522e511595d74f74c6/chrome/browser/ui/views/extensions/request_file_system_dialog_view.cc
[modify] https://crrev.com/9f9851702f1fd544b8f15f522e511595d74f74c6/chrome/browser/ui/views/extensions/request_file_system_dialog_view.h
[modify] https://crrev.com/9f9851702f1fd544b8f15f522e511595d74f74c6/chrome/browser/ui/views/external_protocol_dialog.cc
[modify] https://crrev.com/9f9851702f1fd544b8f15f522e511595d74f74c6/chrome/browser/ui/views/feature_promos/feature_promo_bubble_view.cc
[modify] https://crrev.com/9f9851702f1fd544b8f15f522e511595d74f74c6/chrome/browser/ui/views/first_run_bubble.cc
[modify] https://crrev.com/9f9851702f1fd544b8f15f522e511595d74f74c6/chrome/browser/ui/views/first_run_dialog.cc
[modify] https://crrev.com/9f9851702f1fd544b8f15f522e511595d74f74c6/chrome/browser/ui/views/harmony/harmony_layout_provider.cc
[modify] https://crrev.com/9f9851702f1fd544b8f15f522e511595d74f74c6/chrome/browser/ui/views/hung_renderer_view.cc
[modify] https://crrev.com/9f9851702f1fd544b8f15f522e511595d74f74c6/chrome/browser/ui/views/importer/import_lock_dialog_view.cc
[modify] https://crrev.com/9f9851702f1fd544b8f15f522e511595d74f74c6/chrome/browser/ui/views/login_view.cc
[modify] https://crrev.com/9f9851702f1fd544b8f15f522e511595d74f74c6/chrome/browser/ui/views/page_info/page_info_bubble_view.cc
[modify] https://crrev.com/9f9851702f1fd544b8f15f522e511595d74f74c6/chrome/browser/ui/views/passwords/account_chooser_dialog_view.cc
[modify] https://crrev.com/9f9851702f1fd544b8f15f522e511595d74f74c6/chrome/browser/ui/views/passwords/auto_signin_first_run_dialog_view.cc
[modify] https://crrev.com/9f9851702f1fd544b8f15f522e511595d74f74c6/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
[modify] https://crrev.com/9f9851702f1fd544b8f15f522e511595d74f74c6/chrome/browser/ui/views/profiles/forced_reauthentication_dialog_view.cc
[modify] https://crrev.com/9f9851702f1fd544b8f15f522e511595d74f74c6/chrome/browser/ui/views/safe_browsing/password_reuse_modal_warning_dialog.cc
[modify] https://crrev.com/9f9851702f1fd544b8f15f522e511595d74f74c6/chrome/browser/ui/views/safe_browsing/password_reuse_modal_warning_dialog.h
[modify] https://crrev.com/9f9851702f1fd544b8f15f522e511595d74f74c6/chrome/browser/ui/views/settings_reset_prompt_dialog.cc
[modify] https://crrev.com/9f9851702f1fd544b8f15f522e511595d74f74c6/chrome/browser/ui/views/sync/one_click_signin_dialog_view.cc
[modify] https://crrev.com/9f9851702f1fd544b8f15f522e511595d74f74c6/chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.cc
[modify] https://crrev.com/9f9851702f1fd544b8f15f522e511595d74f74c6/chrome/browser/ui/views/task_manager_view.cc
[modify] https://crrev.com/9f9851702f1fd544b8f15f522e511595d74f74c6/chrome/browser/ui/views/toolbar/home_button.cc
[modify] https://crrev.com/9f9851702f1fd544b8f15f522e511595d74f74c6/chrome/browser/ui/views/try_chrome_dialog.cc
[modify] https://crrev.com/9f9851702f1fd544b8f15f522e511595d74f74c6/chrome/browser/ui/views/uninstall_view.cc
[modify] https://crrev.com/9f9851702f1fd544b8f15f522e511595d74f74c6/chrome/browser/ui/views/webshare/webshare_target_picker_view.cc
[modify] https://crrev.com/9f9851702f1fd544b8f15f522e511595d74f74c6/ui/views/bubble/bubble_dialog_delegate.cc
[modify] https://crrev.com/9f9851702f1fd544b8f15f522e511595d74f74c6/ui/views/bubble/bubble_dialog_delegate_unittest.cc
[modify] https://crrev.com/9f9851702f1fd544b8f15f522e511595d74f74c6/ui/views/controls/message_box_view.cc
[modify] https://crrev.com/9f9851702f1fd544b8f15f522e511595d74f74c6/ui/views/layout/layout_provider.cc
[modify] https://crrev.com/9f9851702f1fd544b8f15f522e511595d74f74c6/ui/views/layout/layout_provider.h

Comment 5 by bsep@chromium.org, Sep 11 2017

Status: Fixed (was: Started)

Comment 6 by monor...@bugs.chromium.org, Sep 29 2017 

The NextAction date has arrived: 2017-09-29
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 6 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb0f7c794d474cabd0c5f15494160bd10bf38393

commit bb0f7c794d474cabd0c5f15494160bd10bf38393
Author: Bret Sepulveda <bsep@chromium.org>
Date: Sat Jan 06 00:06:11 2018

Harmony - Reduce dialog margins around checkboxes.

When I gave dialogs variable margins I used the larger CONTROL margin
for checkboxes. But they have an innner padding due to their text label,
so they should be using the smaller TEXT. Dialogs that were harmonized
after my initial pass are already doing this correctly, but some never
got updated.

Bug:  716222 
Change-Id: I6d11633b0c3cf7c12fa11c7629154d6b7cf9e5c9
Reviewed-on: https://chromium-review.googlesource.com/853115
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527437}
[modify] https://crrev.com/bb0f7c794d474cabd0c5f15494160bd10bf38393/chrome/browser/chromeos/options/vpn_config_view.cc
[modify] https://crrev.com/bb0f7c794d474cabd0c5f15494160bd10bf38393/chrome/browser/ui/views/create_application_shortcut_view.cc
[modify] https://crrev.com/bb0f7c794d474cabd0c5f15494160bd10bf38393/chrome/browser/ui/views/extensions/bookmark_app_confirmation_view.cc
[modify] https://crrev.com/bb0f7c794d474cabd0c5f15494160bd10bf38393/chrome/browser/ui/views/external_protocol_dialog.cc
[modify] https://crrev.com/bb0f7c794d474cabd0c5f15494160bd10bf38393/chrome/browser/ui/views/first_run_dialog.cc
[modify] https://crrev.com/bb0f7c794d474cabd0c5f15494160bd10bf38393/chrome/browser/ui/views/uninstall_view.cc
[modify] https://crrev.com/bb0f7c794d474cabd0c5f15494160bd10bf38393/ui/views/controls/message_box_view.cc
►

Sign in to add a comment