New issue
Advanced search Search tips

Issue 716221 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature



Sign in to add a comment

Add a flag in chrome://flags that overrides the ECT returned by NQE

Project Member Reported by tbansal@chromium.org, Apr 27 2017

Issue description

We should add a flag in chrome://flags that overrides the ECT returned by NQE. This would be useful for testing various features.
 

Comment 1 by bengr@chromium.org, Apr 30 2017

Thanks!

Comment 2 by bengr@chromium.org, Apr 30 2017

Cc: tbansal@chromium.org
 Issue 714801  has been merged into this issue.
Labels: -Pri-3 M-60 Pri-2
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, May 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d3e08ca678225b65a89c91f01329ecc11ef8b554

commit d3e08ca678225b65a89c91f01329ecc11ef8b554
Author: tbansal <tbansal@chromium.org>
Date: Thu May 04 19:51:09 2017

Add flag to override Effective Connection Type

Add flag to override Effective Connection Type (ECT) returned by
Network Quality Estimator (NQE). If ECT is overridden using both the
flag and the field trial, then the value set by the flag takes the
precedence.

BUG= 716221 

Review-Url: https://codereview.chromium.org/2850003002
Cr-Commit-Position: refs/heads/master@{#469432}

[modify] https://crrev.com/d3e08ca678225b65a89c91f01329ecc11ef8b554/chrome/browser/about_flags.cc
[modify] https://crrev.com/d3e08ca678225b65a89c91f01329ecc11ef8b554/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/d3e08ca678225b65a89c91f01329ecc11ef8b554/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/d3e08ca678225b65a89c91f01329ecc11ef8b554/chrome/browser/io_thread.cc
[modify] https://crrev.com/d3e08ca678225b65a89c91f01329ecc11ef8b554/chrome/browser/io_thread_unittest.cc
[modify] https://crrev.com/d3e08ca678225b65a89c91f01329ecc11ef8b554/chrome/common/chrome_switches.cc
[modify] https://crrev.com/d3e08ca678225b65a89c91f01329ecc11ef8b554/chrome/common/chrome_switches.h
[modify] https://crrev.com/d3e08ca678225b65a89c91f01329ecc11ef8b554/net/nqe/effective_connection_type.cc
[modify] https://crrev.com/d3e08ca678225b65a89c91f01329ecc11ef8b554/net/nqe/effective_connection_type.h
[modify] https://crrev.com/d3e08ca678225b65a89c91f01329ecc11ef8b554/net/nqe/network_quality_estimator_params.cc
[modify] https://crrev.com/d3e08ca678225b65a89c91f01329ecc11ef8b554/net/nqe/network_quality_estimator_params.h
[modify] https://crrev.com/d3e08ca678225b65a89c91f01329ecc11ef8b554/net/nqe/network_quality_estimator_unittest.cc
[modify] https://crrev.com/d3e08ca678225b65a89c91f01329ecc11ef8b554/tools/metrics/histograms/enums.xml

Comment 5 by bengr@chromium.org, May 8 2017

Labels: -Type-Bug Type-Feature
Status: Fixed (was: Started)

Sign in to add a comment