New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 716220 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Replace swipe in Chrome Home with a button

Project Member Reported by mdjones@chromium.org, Apr 27 2017

Issue description

To avoid accidental swipes on the bottom toolbar that open Chrome Home, there should instead be a button that can be tapped to enter the half state.

Tasks:
- Remove handle.
- Add button on left side of toolbar.
- Disable swipe until the sheet is opened.
 
Attaching screenshots of implementation:
Screenshot_20170428-185457.png
405 KB View Download
Screenshot_20170428-185504.png
72.7 KB View Download

Comment 2 by cl...@chromium.org, Apr 28 2017

Cool, you handled it before I even managed to get you specs! :)

Can we ensure the icon is centered in the space between the left side of the screen and the omnibox?

Visually, it should be:
[16 dp padding][24 dp icon][16dp padding][omnibox]

…with the icon having the standard tap target size, of course.
Project Member

Comment 3 by bugdroid1@chromium.org, May 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d484eacb1a1016a1f2fda3bc57b8e309fd08df76

commit d484eacb1a1016a1f2fda3bc57b8e309fd08df76
Author: mdjones <mdjones@chromium.org>
Date: Tue May 02 21:34:45 2017

[Home] Add expand button and flag to enable it

This change adds an alternate UI for the Chrome Home bottom sheet.
Instead of being able to swipe up when the sheet is peeking, there is
the option to have a button that sits to the left of the omnibox that
expands the sheet when pressed. The feature name for this UI is
"ChromeHomeExpandButton".

This flag runs into the same problems as Chrome Home when first
being enabled -- native is not ready when UI is initialized. To
avoid yet another Chrome restart, the pull-handle version of the UI
will appear briefly before switching to the button.

BUG= 716220 

Review-Url: https://codereview.chromium.org/2853583002
Cr-Commit-Position: refs/heads/master@{#468781}

[modify] https://crrev.com/d484eacb1a1016a1f2fda3bc57b8e309fd08df76/chrome/android/java/res/layout/toolbar_phone_common.xml
[modify] https://crrev.com/d484eacb1a1016a1f2fda3bc57b8e309fd08df76/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java
[modify] https://crrev.com/d484eacb1a1016a1f2fda3bc57b8e309fd08df76/chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarPhone.java
[modify] https://crrev.com/d484eacb1a1016a1f2fda3bc57b8e309fd08df76/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java
[modify] https://crrev.com/d484eacb1a1016a1f2fda3bc57b8e309fd08df76/chrome/android/java/src/org/chromium/chrome/browser/util/FeatureUtilities.java
[modify] https://crrev.com/d484eacb1a1016a1f2fda3bc57b8e309fd08df76/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheet.java
[modify] https://crrev.com/d484eacb1a1016a1f2fda3bc57b8e309fd08df76/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetMetrics.java
[modify] https://crrev.com/d484eacb1a1016a1f2fda3bc57b8e309fd08df76/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/d484eacb1a1016a1f2fda3bc57b8e309fd08df76/chrome/browser/about_flags.cc
[modify] https://crrev.com/d484eacb1a1016a1f2fda3bc57b8e309fd08df76/chrome/browser/android/chrome_feature_list.cc
[modify] https://crrev.com/d484eacb1a1016a1f2fda3bc57b8e309fd08df76/chrome/browser/android/chrome_feature_list.h
[modify] https://crrev.com/d484eacb1a1016a1f2fda3bc57b8e309fd08df76/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/d484eacb1a1016a1f2fda3bc57b8e309fd08df76/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/d484eacb1a1016a1f2fda3bc57b8e309fd08df76/tools/metrics/histograms/histograms.xml

I've been using this on Canary and it's fantastic. Chrome Home is such a big deal, I think people are going to start browsing on their phones more because of Chrome Home (once it ships, of course)
Status: Fixed (was: Assigned)
I have a small idea/request to improve this feature: once you tap the arrow button, the android system back button should change to pointing downward (like it does when you tap the URL bar). It should do this because it would give users a 'hint' that tapping it brings the bar back down again, it just makes more sense to have the arrow pointing down. Even for me, I initially did not realize tapping the system back button would bring the bar down, I was still pulling the bar down. screenshot attached 
Screenshot_20170531-224834.png
103 KB View Download
Is this possible? (my previous post) This expand button method feels incomplete because the system back button doesn't put down once you tap the expand button. It's just a cosmetic change, tapping the back button already brings it down...

Comment 8 by k...@chromium.org, Jun 8 2017

Yep that's fair. I filed https://bugs.chromium.org/p/chromium/issues/detail?id=731200 to track that if it is possible without being too hacky.
Thank you!
Dev just updated to version 61 and I just wanted to say thank you to whoever came up with the idea to move the button over to the other side of the address bar, this is just fantastic to use now. For people with wider phones, having the button all the way on the left side was quite a thumb stretch and wasn't 'one-handed friendly'. Also, this new location means this same layout can be used on Chrome for iPhone

Sign in to add a comment