New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 716203 link

Starred by 1 user
Status: Fixed
Owner:
█ jstenback@chromium.org
Last visit > 30 days ago
Closed: May 2017
Cc:
ikilpatrick@chromium.org
█ mbarowsky+blinkimage@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Remove unnecessary zoom argument from GetImage()

Project Member Reported by jstenback@chromium.org, Apr 27 2017 
Currently CSSValue::GetImage() (etc) take a zoom argument which appears to be unnecessary as the current zoom level can be retrieved from the LayoutObject that's also passed in. I'm proposing we remove that zoom argument and simply extract the zoom level from the given LayoutObject in the few cases where it's used.

Comment 1 by schenney@chromium.org, Apr 28 2017

Components: -Blink>Paint Blink>Image
Labels: BugSource-Chromium PaintTeamTriaged-20170428 OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows
Project Member

Comment 2 by bugdroid1@chromium.org, May 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a11f72c868235d4673cd96c7eea24ad9e7eb4b55

commit a11f72c868235d4673cd96c7eea24ad9e7eb4b55
Author: jstenback <jstenback@chromium.org>
Date: Fri May 05 01:09:14 2017

Remove unnecessary zoom argument from GetImage() as its value is always available through the LayoutObject argument. (rebased)

BUG= 716203 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2847303002
Cr-Commit-Position: refs/heads/master@{#469560}

[modify] https://crrev.com/a11f72c868235d4673cd96c7eea24ad9e7eb4b55/third_party/WebKit/Source/core/css/CSSImageGeneratorValue.cpp
[modify] https://crrev.com/a11f72c868235d4673cd96c7eea24ad9e7eb4b55/third_party/WebKit/Source/core/css/CSSImageGeneratorValue.h
[modify] https://crrev.com/a11f72c868235d4673cd96c7eea24ad9e7eb4b55/third_party/WebKit/Source/core/css/CSSPaintImageGenerator.h
[modify] https://crrev.com/a11f72c868235d4673cd96c7eea24ad9e7eb4b55/third_party/WebKit/Source/core/css/CSSPaintValue.cpp
[modify] https://crrev.com/a11f72c868235d4673cd96c7eea24ad9e7eb4b55/third_party/WebKit/Source/core/css/CSSPaintValue.h
[modify] https://crrev.com/a11f72c868235d4673cd96c7eea24ad9e7eb4b55/third_party/WebKit/Source/core/layout/LayoutImageResource.cpp
[modify] https://crrev.com/a11f72c868235d4673cd96c7eea24ad9e7eb4b55/third_party/WebKit/Source/core/layout/LayoutImageResource.h
[modify] https://crrev.com/a11f72c868235d4673cd96c7eea24ad9e7eb4b55/third_party/WebKit/Source/core/layout/LayoutImageResourceStyleImage.cpp
[modify] https://crrev.com/a11f72c868235d4673cd96c7eea24ad9e7eb4b55/third_party/WebKit/Source/core/layout/LayoutImageResourceStyleImage.h
[modify] https://crrev.com/a11f72c868235d4673cd96c7eea24ad9e7eb4b55/third_party/WebKit/Source/core/layout/LayoutObject.h
[modify] https://crrev.com/a11f72c868235d4673cd96c7eea24ad9e7eb4b55/third_party/WebKit/Source/core/layout/shapes/ShapeOutsideInfo.cpp
[modify] https://crrev.com/a11f72c868235d4673cd96c7eea24ad9e7eb4b55/third_party/WebKit/Source/core/paint/BoxPainter.cpp
[modify] https://crrev.com/a11f72c868235d4673cd96c7eea24ad9e7eb4b55/third_party/WebKit/Source/core/paint/ImagePainter.cpp
[modify] https://crrev.com/a11f72c868235d4673cd96c7eea24ad9e7eb4b55/third_party/WebKit/Source/core/paint/ListMarkerPainter.cpp
[modify] https://crrev.com/a11f72c868235d4673cd96c7eea24ad9e7eb4b55/third_party/WebKit/Source/core/paint/NinePieceImagePainter.cpp
[modify] https://crrev.com/a11f72c868235d4673cd96c7eea24ad9e7eb4b55/third_party/WebKit/Source/core/paint/SVGImagePainter.cpp
[modify] https://crrev.com/a11f72c868235d4673cd96c7eea24ad9e7eb4b55/third_party/WebKit/Source/core/style/StyleFetchedImage.cpp
[modify] https://crrev.com/a11f72c868235d4673cd96c7eea24ad9e7eb4b55/third_party/WebKit/Source/core/style/StyleFetchedImage.h
[modify] https://crrev.com/a11f72c868235d4673cd96c7eea24ad9e7eb4b55/third_party/WebKit/Source/core/style/StyleFetchedImageSet.cpp
[modify] https://crrev.com/a11f72c868235d4673cd96c7eea24ad9e7eb4b55/third_party/WebKit/Source/core/style/StyleFetchedImageSet.h
[modify] https://crrev.com/a11f72c868235d4673cd96c7eea24ad9e7eb4b55/third_party/WebKit/Source/core/style/StyleGeneratedImage.cpp
[modify] https://crrev.com/a11f72c868235d4673cd96c7eea24ad9e7eb4b55/third_party/WebKit/Source/core/style/StyleGeneratedImage.h
[modify] https://crrev.com/a11f72c868235d4673cd96c7eea24ad9e7eb4b55/third_party/WebKit/Source/core/style/StyleImage.h
[modify] https://crrev.com/a11f72c868235d4673cd96c7eea24ad9e7eb4b55/third_party/WebKit/Source/core/style/StyleInvalidImage.h
[modify] https://crrev.com/a11f72c868235d4673cd96c7eea24ad9e7eb4b55/third_party/WebKit/Source/core/style/StylePendingImage.h
[modify] https://crrev.com/a11f72c868235d4673cd96c7eea24ad9e7eb4b55/third_party/WebKit/Source/modules/csspaint/CSSPaintDefinition.cpp
[modify] https://crrev.com/a11f72c868235d4673cd96c7eea24ad9e7eb4b55/third_party/WebKit/Source/modules/csspaint/CSSPaintDefinition.h
[modify] https://crrev.com/a11f72c868235d4673cd96c7eea24ad9e7eb4b55/third_party/WebKit/Source/modules/csspaint/CSSPaintImageGeneratorImpl.cpp
[modify] https://crrev.com/a11f72c868235d4673cd96c7eea24ad9e7eb4b55/third_party/WebKit/Source/modules/csspaint/CSSPaintImageGeneratorImpl.h

Comment 3 by jstenback@chromium.org, May 5 2017

Status: Fixed (was: Assigned)
Landed, per above comment. Closing.
►

Sign in to add a comment