New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 716201 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug
Proj-XR
Proj-XR-VR



Sign in to add a comment

Laser/Reticle does not appear in VR Shell if controller reports a gyro vector of (0, 0, 0)

Project Member Reported by bsheedy@chromium.org, Apr 27 2017

Issue description

If the gyro Vector3dF passed to ElbowModel::Update is (0, 0, 0), the pointer and reticle in VR Shell are no longer rendered. This shouldn't be an issue during actual use unless someone's trying to use VR Shell in zero gravity, but it causes the pointer to be missing during automated tests if using the automated emulated Daydream controller.

Works fine if at least one element is non-zero. My initial guess is that the length of the vector is being calculated somewhere, and when it's zero, causes math errors, as the beam_direction vector in vr_shell_gl.cc is (nan, nan, nan) in this case.
 
Components: UI>Browser>VR
Project Member

Comment 2 by bugdroid1@chromium.org, May 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f00f17c2badfd4132e5cac30413804ce34f72cbe

commit f00f17c2badfd4132e5cac30413804ce34f72cbe
Author: acondor <acondor@google.com>
Date: Mon May 01 18:55:34 2017

Fix controller positioning in VrShell when gyro reads are small

BUG= 716201 

Review-Url: https://codereview.chromium.org/2853843002
Cr-Commit-Position: refs/heads/master@{#468375}

[modify] https://crrev.com/f00f17c2badfd4132e5cac30413804ce34f72cbe/chrome/browser/android/vr_shell/elbow_model.cc
[modify] https://crrev.com/f00f17c2badfd4132e5cac30413804ce34f72cbe/device/vr/vr_math.cc

Comment 3 by acondor@google.com, May 1 2017

Status: Fixed (was: Assigned)

Sign in to add a comment