Laser/Reticle does not appear in VR Shell if controller reports a gyro vector of (0, 0, 0) |
||
Issue descriptionIf the gyro Vector3dF passed to ElbowModel::Update is (0, 0, 0), the pointer and reticle in VR Shell are no longer rendered. This shouldn't be an issue during actual use unless someone's trying to use VR Shell in zero gravity, but it causes the pointer to be missing during automated tests if using the automated emulated Daydream controller. Works fine if at least one element is non-zero. My initial guess is that the length of the vector is being calculated somewhere, and when it's zero, causes math errors, as the beam_direction vector in vr_shell_gl.cc is (nan, nan, nan) in this case.
,
May 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f00f17c2badfd4132e5cac30413804ce34f72cbe commit f00f17c2badfd4132e5cac30413804ce34f72cbe Author: acondor <acondor@google.com> Date: Mon May 01 18:55:34 2017 Fix controller positioning in VrShell when gyro reads are small BUG= 716201 Review-Url: https://codereview.chromium.org/2853843002 Cr-Commit-Position: refs/heads/master@{#468375} [modify] https://crrev.com/f00f17c2badfd4132e5cac30413804ce34f72cbe/chrome/browser/android/vr_shell/elbow_model.cc [modify] https://crrev.com/f00f17c2badfd4132e5cac30413804ce34f72cbe/device/vr/vr_math.cc
,
May 1 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by bsheedy@chromium.org
, Apr 27 2017