FontFamilyMapObserver Use upto 300KB of memory on Android |
||
Issue descriptionIIUC, The FontFamilyMapObserver(s) listen to changes to font on the disk made by system. These observers were removed in 2013 by this CL in https://chromiumcodereview.appspot.com/12529014 to reduce memory on Android because there is no exposed way to change font preferences. But were later added in 2014 by https://codereview.chromium.org/444843002 by mistake (as remembered by chrishtr@). Removing these observers on Android should give back at least 300KB of memory, it could be higher as the comment in RegisterFontFamilyMapObserver() on says 700.
,
May 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c517d74afe77cf489a7a59c2b24039df512ae2a7 commit c517d74afe77cf489a7a59c2b24039df512ae2a7 Author: ssid <ssid@chromium.org> Date: Tue May 02 18:47:16 2017 Android: disables observing changes for font prefs. On Android, there's no exposed way to change font preferences. This will save ~200KB of heap. This change was done in crrev.com/12529014 but was later reverted in crrev.com/444843002 by mistake. So, remove them again. BUG= 716195 Review-Url: https://codereview.chromium.org/2850503006 Cr-Commit-Position: refs/heads/master@{#468717} [modify] https://crrev.com/c517d74afe77cf489a7a59c2b24039df512ae2a7/chrome/browser/ui/prefs/prefs_tab_helper.cc
,
May 5 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by ssid@chromium.org
, Apr 27 2017