Customize Touch Bar item should be the third item in the View menu |
||||
Issue descriptionChrome Version: 60.0.3082.0 OS: macOS 10.12 Currently the Customize Touch Bar... item is the last menu item, in its own section. It should instead reside within the first item grouping, just after Always Show Toolbar in Fullscreen.
,
May 5 2017
,
May 6 2017
FYI, I have a fix here: https://codereview.chromium.org/2865763002/ But I'll have to make sure it looks okay on anything earlier than 10.12.1 before I submit it
,
May 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bf3edb98a3b2787fcf36198f9fe9e5600db95dba commit bf3edb98a3b2787fcf36198f9fe9e5600db95dba Author: spqchan <spqchan@chromium.org> Date: Wed May 10 18:01:20 2017 [Mac] Move the "Customize Touch Bar" Menu Item Move the "Customize Touch Bar" menu item so that it's the third item in the Views menu. This is done by removing "setAutomaticCustomizeTouchBarMenuItemEnabled" and manually adding the item in MainMenu.xib. AppKit will name and validate the menu item, and hides it on systems that do not have a Touch Bar. However, this is only available in 10.12.1+. We manually have to remove that item if it's not supported. See "The Customization Menu Item" section in the following link for more details: https://developer.apple.com/reference/appkit/nstouchbar BUG= 716185 Review-Url: https://codereview.chromium.org/2865763002 Cr-Commit-Position: refs/heads/master@{#470641} [modify] https://crrev.com/bf3edb98a3b2787fcf36198f9fe9e5600db95dba/base/mac/sdk_forward_declarations.h [modify] https://crrev.com/bf3edb98a3b2787fcf36198f9fe9e5600db95dba/chrome/app/chrome_command_ids.h [modify] https://crrev.com/bf3edb98a3b2787fcf36198f9fe9e5600db95dba/chrome/app/generated_resources.grd [modify] https://crrev.com/bf3edb98a3b2787fcf36198f9fe9e5600db95dba/chrome/app/nibs/MainMenu.xib [modify] https://crrev.com/bf3edb98a3b2787fcf36198f9fe9e5600db95dba/chrome/browser/app_controller_mac.mm
,
May 11 2017
,
May 16 2017
Checked on Macbook touchbar pro 10.12.1 on latest canary version 60.0.3100.0(official build) and 'customize touch bar' option is seen in view section.
,
May 16 2017
As per Comment#6 adding TE-Verified labels as the issue is found to be fixed. Thank You. |
||||
►
Sign in to add a comment |
||||
Comment 1 by shrike@chromium.org
, May 4 2017