New issue
Advanced search Search tips

Issue 716169 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocking:
issue 388780



Sign in to add a comment

Use Union instead of Overload for DOMMatrix/DOMMatrixReadOnly Constructors

Project Member Reported by xlai@chromium.org, Apr 27 2017

Issue description

Comment 1 by xlai@chromium.org, Apr 27 2017

Cc: zcorpan@gmail.com
Cc: jinho.b...@samsung.com

Comment 3 by junov@chromium.org, May 2 2017

Owner: fs...@chromium.org

Comment 4 by gog...@gmail.com, May 3 2017

Is anyone working on it? If not, may I look into it?
I'm waiting resoving the spec.

Comment 5 by gog...@gmail.com, May 3 2017

I have been fixing https://codereview.chromium.org/2709763004/(Make WebkitCSSMatrix an alias as of DOMMatrix that has been waiting for fixing other spec issue.
It is from the issue, and the spec is resolved. 
So I want to fix it asap :)

Comment 6 by fs...@chromium.org, May 4 2017

Status: Started (was: Assigned)

Comment 7 by fs...@chromium.org, May 4 2017

Cc: fs...@chromium.org
 Issue 716178  has been merged into this issue.

Comment 8 by fs...@chromium.org, May 8 2017

Just an update. This work is already in on https://codereview.chromium.org/2859293002, but we are having some issues with the WPT that I'd like to solve first.

If we can't solve them by tomorrow, I'll submit it anyway.
Project Member

Comment 9 by bugdroid1@chromium.org, May 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6156f7b21c2555d4ce52cecff7f5851ebb57652e

commit 6156f7b21c2555d4ce52cecff7f5851ebb57652e
Author: fserb <fserb@chromium.org>
Date: Thu May 11 05:45:21 2017

Use union instead of overload fo DOMMatrix/DOMMatrixReadOnly

Fixes DOMMatrix-001 tests that were just broken as written (missing brackets)

BUG= 716169 

Review-Url: https://codereview.chromium.org/2859293002
Cr-Commit-Position: refs/heads/master@{#470827}

[modify] https://crrev.com/6156f7b21c2555d4ce52cecff7f5851ebb57652e/third_party/WebKit/LayoutTests/external/wpt/css/geometry-1/DOMMatrix-001-expected.txt
[modify] https://crrev.com/6156f7b21c2555d4ce52cecff7f5851ebb57652e/third_party/WebKit/LayoutTests/external/wpt/css/geometry-1/DOMMatrix-001.html
[modify] https://crrev.com/6156f7b21c2555d4ce52cecff7f5851ebb57652e/third_party/WebKit/Source/bindings/core/v8/BUILD.gn
[modify] https://crrev.com/6156f7b21c2555d4ce52cecff7f5851ebb57652e/third_party/WebKit/Source/core/geometry/DOMMatrix.cpp
[modify] https://crrev.com/6156f7b21c2555d4ce52cecff7f5851ebb57652e/third_party/WebKit/Source/core/geometry/DOMMatrix.h
[modify] https://crrev.com/6156f7b21c2555d4ce52cecff7f5851ebb57652e/third_party/WebKit/Source/core/geometry/DOMMatrix.idl
[modify] https://crrev.com/6156f7b21c2555d4ce52cecff7f5851ebb57652e/third_party/WebKit/Source/core/geometry/DOMMatrixReadOnly.cpp
[modify] https://crrev.com/6156f7b21c2555d4ce52cecff7f5851ebb57652e/third_party/WebKit/Source/core/geometry/DOMMatrixReadOnly.h
[modify] https://crrev.com/6156f7b21c2555d4ce52cecff7f5851ebb57652e/third_party/WebKit/Source/core/geometry/DOMMatrixReadOnly.idl

Comment 10 by fs...@chromium.org, May 11 2017

Status: Fixed (was: Started)
Aaaaaand we are out! :)

Sign in to add a comment