New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 716156 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Purge directory data when migrating to USS

Project Member Reported by pnoland@chromium.org, Apr 27 2017

Issue description

Right now, directory data is untouched when migrating a type to USS. The leftover data should be deleted.
 

Comment 1 by s...@chromium.org, Apr 27 2017

Cc: s...@chromium.org
Labels: Sync-V2
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/47c2232d3a2cbad52c1f38696f37ece1f0c8154c

commit 47c2232d3a2cbad52c1f38696f37ece1f0c8154c
Author: pnoland <pnoland@chromium.org>
Date: Fri Apr 28 23:06:40 2017

[sync] Purge directory data when migrating to USS

Make use of the existing PurgeEntriesWithTypeIn to purge the directory
of entries of the type we just migrated. Add a test that ensures this
happens.

R=skym@chromium.org

BUG= 716156 

Review-Url: https://codereview.chromium.org/2842373004
Cr-Commit-Position: refs/heads/master@{#468170}

[modify] https://crrev.com/47c2232d3a2cbad52c1f38696f37ece1f0c8154c/components/sync/engine_impl/model_type_registry.cc
[modify] https://crrev.com/47c2232d3a2cbad52c1f38696f37ece1f0c8154c/components/sync/engine_impl/model_type_registry_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment