New issue
Advanced search Search tips

Issue 716154 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Rename AdaptiveRendererFactory to CourierRenderer

Project Member Reported by tguilbert@chromium.org, Apr 27 2017

Issue description

The introduction of the RendererFactorySelector (in the context of  crbug.com/663503 ) allows us to choose between different types of renderers after WMPI has been created.

The AdaptiveRendererFactory currently takes a RendererFactory as a construction parameter. When creating a Renderer, it chooses between using the passed factory, or creating CourierRenderer (for media remoting).

This logic can be moved into the RendererFactorySelector, and the AdaptiveRendererFactory can be renamed to the CourierRendererFactory.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/16d9d7d9ca1db157277bb1170eda38fac52eed7c

commit 16d9d7d9ca1db157277bb1170eda38fac52eed7c
Author: tguilbert <tguilbert@chromium.org>
Date: Fri May 05 03:24:42 2017

Rename AdaptiveRendererFactory

The introduction of the RendererFactorySelector allows us to choose
between different types of renderers after WMPI has been created.

The AdaptiveRendererFactory currently takes a RendererFactory* as a
construction parameter. When creating a Renderer, it chooses between
using the passed factory, or creating a CourierRenderer, for remoting.

This CL moves the decision logic from the AdaptiveRendererFactory to
the RendererFactorySelector, and renames the ARF to the
CourierRendererFactory.

BUG= 716154 
TEST= added UTs

Review-Url: https://codereview.chromium.org/2826883002
Cr-Commit-Position: refs/heads/master@{#469585}

[modify] https://crrev.com/16d9d7d9ca1db157277bb1170eda38fac52eed7c/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/16d9d7d9ca1db157277bb1170eda38fac52eed7c/media/base/renderer_factory_selector.cc
[modify] https://crrev.com/16d9d7d9ca1db157277bb1170eda38fac52eed7c/media/base/renderer_factory_selector.h
[modify] https://crrev.com/16d9d7d9ca1db157277bb1170eda38fac52eed7c/media/base/renderer_factory_selector_unittest.cc
[modify] https://crrev.com/16d9d7d9ca1db157277bb1170eda38fac52eed7c/media/remoting/BUILD.gn
[delete] https://crrev.com/9b503962a017a8d69adfdae9300684c299922640/media/remoting/adaptive_renderer_factory.cc
[delete] https://crrev.com/9b503962a017a8d69adfdae9300684c299922640/media/remoting/adaptive_renderer_factory.h
[add] https://crrev.com/16d9d7d9ca1db157277bb1170eda38fac52eed7c/media/remoting/courier_renderer_factory.cc
[add] https://crrev.com/16d9d7d9ca1db157277bb1170eda38fac52eed7c/media/remoting/courier_renderer_factory.h

Status: Fixed (was: Assigned)

Sign in to add a comment