New issue
Advanced search Search tips

Issue 716147 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Settings icon is not visible on Chrome OS in extension with contrasting foreground/background tab colors

Project Member Reported by lgar...@chromium.org, Apr 27 2017

Issue description

Chrome Version: Chrome 59.0,3065,0
OS: Chrome OS
Device: Chromebook Pixel 1

What steps will reproduce the problem?
(1) Install https://chrome.google.com/webstore/detail/grass/mmiboiefncpfjihjdedpaoammipkilla?hl=en
(2) Open chrome://settings
(3) Open a new tab

What is the expected result?
The chrome://settings icon stays visible on in the tab strip.

What happens instead?
The chrome://settings icon is not visible.

I'm guessing that there is logic to turn the Settings icon white because the foreground tab strip tab color for the theme is dark (green). However, the background tab color is white, where this is not visible.

I can only reproduce with this theme on Chrome OS.
- With the same theme on macOS, the icon is gray for fg and bg tabs.
- With a different theme on Chrome OS, the icon is also gray for fg and bg tabs.

 

Comment 1 by xiy...@chromium.org, Apr 28 2017

Cc: dbeam@chromium.org
Owner: steve...@chromium.org
Status: Assigned (was: Untriaged)
stevenjb@, could you take a look? 

Comment 2 by est...@chromium.org, Apr 28 2017

This might be fixable, but I'm not sure how much I'd prioritize it. If we don't colorize like this it's quite possible for the icon to be invisible on either a fg or bg tab, e.g. on Mac if you install a grey theme the icon will be invisible. I think Views is overall in a better place than Mac here, even if not perfect.
Cc: steve...@chromium.org
Owner: est...@chromium.org
Agreed.
a) Settings opens in its own window by default on Chrome OS.
b) The problem doesn't seem unique to settings? Any icon with a similar color scheme would have the same problem, wouldn't it?

estade@ - you seem to know more about this than I do? Putting this on your plate unless you think there is something Settings specific you think we should do.

Comment 4 by est...@chromium.org, Apr 28 2017

Cc: est...@chromium.org
Owner: ----
Status: Available (was: Assigned)
Correct, it's not specific to settings. I'm not going to be working on it any time soon, though I can help answer questions if anyone takes it up. (I think priority 3 is appropriate.)

Comment 5 by est...@chromium.org, Apr 28 2017

Labels: OS-Linux OS-Windows
Project Member

Comment 6 by sheriffbot@chromium.org, Apr 30 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment