New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 716142 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Make offline page cache sizes counted towards cache in settings

Project Member Reported by romax@chromium.org, Apr 27 2017

Issue description

In Chrome Setting->Privacy->Clear browsing data. Make temporary offline pages contribute to the number when 'cache' is selected.
 

Comment 1 by romax@chromium.org, May 2 2017

Status: Started (was: Assigned)
There will be two patches related.
1. Adding query interfaces for removed-on-cache-reset pages.
2. Adding CachedOfflinePageUtils and actual usage in cache_counter.cc
Project Member

Comment 2 by bugdroid1@chromium.org, May 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d71fd71eeed601adca80aedf34c5aaabb41a321

commit 8d71fd71eeed601adca80aedf34c5aaabb41a321
Author: romax <romax@chromium.org>
Date: Thu May 04 00:36:27 2017

[Offline Pages] Adding support for removed-on-cache-reset pages to query.

Adding support for "removed on cache reset" pages to the query interface.
Also Adding a new interface on OfflinePageModel to delete pages matching
a specific query.

BUG= 716142 

Review-Url: https://codereview.chromium.org/2858803002
Cr-Commit-Position: refs/heads/master@{#469219}

[modify] https://crrev.com/8d71fd71eeed601adca80aedf34c5aaabb41a321/components/offline_pages/core/client_policy_controller_unittest.cc
[modify] https://crrev.com/8d71fd71eeed601adca80aedf34c5aaabb41a321/components/offline_pages/core/offline_page_model_query.cc
[modify] https://crrev.com/8d71fd71eeed601adca80aedf34c5aaabb41a321/components/offline_pages/core/offline_page_model_query.h
[modify] https://crrev.com/8d71fd71eeed601adca80aedf34c5aaabb41a321/components/offline_pages/core/offline_page_model_query_unittest.cc

Project Member

Comment 3 by bugdroid1@chromium.org, May 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/444db4b416dbc2ed7fed540cfbc0d6ec7774ed65

commit 444db4b416dbc2ed7fed540cfbc0d6ec7774ed65
Author: romax <romax@chromium.org>
Date: Tue May 16 23:52:38 2017

[Offline Pages] Add cached offline page utils and show usage in settings.

Added some utility functions for cached offline pages:
Get sizes of all cached offline pages;
Delete all cached offline pages.
Also added the usage of cached offline pages to the number shown at:
Chrome Settings -> Privacy -> Clear Browsing Data -> Cache

BUG= 716142 

Review-Url: https://codereview.chromium.org/2860573004
Cr-Commit-Position: refs/heads/master@{#472255}

[modify] https://crrev.com/444db4b416dbc2ed7fed540cfbc0d6ec7774ed65/chrome/browser/android/offline_pages/offline_page_utils.cc
[modify] https://crrev.com/444db4b416dbc2ed7fed540cfbc0d6ec7774ed65/chrome/browser/android/offline_pages/offline_page_utils.h
[modify] https://crrev.com/444db4b416dbc2ed7fed540cfbc0d6ec7774ed65/chrome/browser/android/offline_pages/offline_page_utils_unittest.cc
[modify] https://crrev.com/444db4b416dbc2ed7fed540cfbc0d6ec7774ed65/chrome/browser/browsing_data/cache_counter.cc
[modify] https://crrev.com/444db4b416dbc2ed7fed540cfbc0d6ec7774ed65/chrome/browser/browsing_data/cache_counter.h
[modify] https://crrev.com/444db4b416dbc2ed7fed540cfbc0d6ec7774ed65/chrome/browser/browsing_data/conditional_cache_counting_helper_browsertest.cc
[modify] https://crrev.com/444db4b416dbc2ed7fed540cfbc0d6ec7774ed65/chrome/browser/ui/webui/options/chromeos/storage_manager_handler.cc
[modify] https://crrev.com/444db4b416dbc2ed7fed540cfbc0d6ec7774ed65/chrome/browser/ui/webui/options/chromeos/storage_manager_handler.h
[modify] https://crrev.com/444db4b416dbc2ed7fed540cfbc0d6ec7774ed65/chrome/browser/ui/webui/settings/chromeos/device_storage_handler.cc
[modify] https://crrev.com/444db4b416dbc2ed7fed540cfbc0d6ec7774ed65/chrome/browser/ui/webui/settings/chromeos/device_storage_handler.h
[modify] https://crrev.com/444db4b416dbc2ed7fed540cfbc0d6ec7774ed65/components/browsing_data/content/conditional_cache_counting_helper.cc
[modify] https://crrev.com/444db4b416dbc2ed7fed540cfbc0d6ec7774ed65/components/browsing_data/content/conditional_cache_counting_helper.h
[modify] https://crrev.com/444db4b416dbc2ed7fed540cfbc0d6ec7774ed65/components/offline_pages/core/offline_page_types.h

Comment 4 by romax@chromium.org, May 17 2017

Status: Fixed (was: Started)

Sign in to add a comment