New issue
Advanced search Search tips

Issue 716128 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jun 2017
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

[clang] Create a host wrapper script for clang/clang++

Project Member Reported by cmt...@chromium.org, Apr 27 2017

Issue description

To make clang the default host compiler we need a host clang wrapper script to process command line flags for clang similarly to the way the target wrapper script processes clang command line flags.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/3e3db6c0a84bec9b89eb72b8434e66c2657f873e

commit 3e3db6c0a84bec9b89eb72b8434e66c2657f873e
Author: Caroline Tice <cmtice@google.com>
Date: Wed May 31 19:38:40 2017

Add host wrapper for clang/clang++.

Create a host_wrapper script for clang, to properly handle &
process command line flags (similarly to the target compiler
wrapper script).  Update the clang ebuild to set up host clang to
use the wrapper script. Also extract common wrapper definitions
from target & host wrapper scripts into common_wrapper_script.

BUG= chromium:716128 
TEST=Successful trybot builds/runs with chromiumos-sdk, veyron_jaq,
elm, peppy.  Will re-run trybots with latest changes.

Change-Id: I3121865516257da40d749d362921cbb2d9530fe5
Reviewed-on: https://chromium-review.googlesource.com/489563
Commit-Ready: Caroline Tice <cmtice@chromium.org>
Tested-by: Caroline Tice <cmtice@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>

[add] https://crrev.com/3e3db6c0a84bec9b89eb72b8434e66c2657f873e/sys-devel/llvm/files/clang_host_wrapper.header
[add] https://crrev.com/3e3db6c0a84bec9b89eb72b8434e66c2657f873e/sys-devel/gcc/files/wrapper_script_common
[rename] https://crrev.com/3e3db6c0a84bec9b89eb72b8434e66c2657f873e/sys-devel/llvm/llvm-5.0_pre300080-r7.ebuild
[modify] https://crrev.com/3e3db6c0a84bec9b89eb72b8434e66c2657f873e/sys-devel/gcc/gcc-9999.ebuild
[add] https://crrev.com/3e3db6c0a84bec9b89eb72b8434e66c2657f873e/sys-devel/gcc/files/sysroot_wrapper.hardened.header
[add] https://crrev.com/3e3db6c0a84bec9b89eb72b8434e66c2657f873e/sys-devel/llvm/files/clang_host_wrapper.body
[add] https://crrev.com/3e3db6c0a84bec9b89eb72b8434e66c2657f873e/sys-devel/llvm/files/wrapper_script_common
[add] https://crrev.com/3e3db6c0a84bec9b89eb72b8434e66c2657f873e/sys-devel/gcc/files/sysroot_wrapper.hardened.body
[delete] https://crrev.com/d7e8d5eae676747aadbd988c862b8bd2be80fd0f/sys-devel/gcc/files/sysroot_wrapper.hardened

Status: Fixed (was: Assigned)

Comment 3 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61
Status: Verified (was: Fixed)
Closing. Please reopen it if its not fixed. Thanks!

Sign in to add a comment