New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 716125 link

Starred by 1 user
Status: Verified
Owner:
jorgelo@chromium.org
Closed: May 2017
Cc:
█ wad@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

platform_TLSDate autotest fails due to missing time.sh

Project Member Reported by derat@chromium.org, Apr 27 2017 
The platform_TLSDate autotest fails when I run it on an M60 lumpy system with a ToT build of the tlsdate package:

/tmp/test_that_results_GCyY6d/results-1-platform_TLSDate                    FAIL: Unhandled OSError: [Errno 2] No such file or directory: '/usr/local/autotest/tests/platform_TLSDate/src/time.sh'

It doesn't appear to be part of any suites.

Comment 1 by jorgelo@chromium.org, Apr 28 2017 

Now that i think about it, that's not a problem with tlsdate, that seems to be a problem with the test: it's complaining about a missing file in the test's src directory.

BTW, on a lumpy build from a couple of days ago, the test passes.

I wonder if your autotest package did not get emerged correctly or something.

Comment 2 by derat@chromium.org, Apr 28 2017 

I've never been able to convince autotest to run tests reliably, so that's entirely possible. :-(
Project Member

Comment 3 by bugdroid1@chromium.org, May 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/6e415c60e348c618fa19651c3dc31841dc0ccd95

commit 6e415c60e348c618fa19651c3dc31841dc0ccd95
Author: Jorge Lucangeli Obes <jorgelo@chromium.org>
Date: Mon May 01 19:20:09 2017

Run tlsdate tests in bvt-perbuild.

tlsdate is crucial for Chrome OS since accurate time is required for
HTTPS connections.

These tests were not being executed, but they currently pass on lumpy
and kevin on ToT. Run in bvt-perbuild to see what's up.

Also fix some Autotest style issues.

BUG= chromium:716125 
TEST=They pass on lumpy, kevin.

Change-Id: I62ce03e7289b0d7f86d4800e03ad9ead2f0365eb
Reviewed-on: https://chromium-review.googlesource.com/490746
Commit-Ready: Jorge Lucangeli Obes <jorgelo@chromium.org>
Tested-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/6e415c60e348c618fa19651c3dc31841dc0ccd95/client/site_tests/platform_TLSDate/platform_TLSDate.py
[modify] https://crrev.com/6e415c60e348c618fa19651c3dc31841dc0ccd95/client/site_tests/platform_TLSDateActual/control
[modify] https://crrev.com/6e415c60e348c618fa19651c3dc31841dc0ccd95/client/site_tests/platform_TLSDateActual/platform_TLSDateActual.py
[modify] https://crrev.com/6e415c60e348c618fa19651c3dc31841dc0ccd95/client/site_tests/platform_TLSDate/control

Comment 4 by jorgelo@chromium.org, May 1 2017 

Will wait to see what the tests do in bvt-perbuild, if they pass will close this bug.

Comment 5 by jorgelo@chromium.org, May 23 2017

Status: Fixed (was: Assigned)
The tests are (mostly) passing, but definitely not failing with the error in OP. Closing. Issue 725655 tracks moving these out of -perbuild.

https://wmatrix.googleplex.com/unfiltered?hide_missing=True&releases=tot&tests=platform_TLSDate
https://wmatrix.googleplex.com/unfiltered?hide_missing=True&releases=tot&tests=platform_TLSDateActual

Comment 6 by helenzhang@chromium.org, Jul 27 2017

Status: Verified (was: Fixed)
test passed:
https://wmatrix.googleplex.com/testrun/unfiltered?test_ids=522492874
►

Sign in to add a comment