New issue
Advanced search Search tips

Issue 716117 link

Starred by 3 users

Issue metadata

Status: Started
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Task



Sign in to add a comment

nix the android-specific GYP_GONE code in chromium_tests

Project Member Reported by jbudorick@chromium.org, Apr 27 2017

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, May 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/686094f6b082e2595bc5d429cdcdaa3b76217501

commit 686094f6b082e2595bc5d429cdcdaa3b76217501
Author: jbudorick <jbudorick@chromium.org>
Date: Thu May 04 21:52:40 2017

[android] Write a runner script to the top-level output dir for gtests.

Android GN builds have been unable to build raw "unit_tests" as a target,
instead relying on unit_tests_apk or chrome/test:unit_tests. Linux builds,
in contrast, can do so without issue. I had thought that the issue was
that a "unit_tests" gn target in another directory was preventing gn
from creating a top-level alias. While this may be true, it's not the
reason for the discrepancy between Android and Linux builds. Instead,
the difference is that Linux builds create a unit_tests executable in
the top-level output directory, while Android builds create an APK and
a wrapper script in child directories.

This CL writes an additional wrapper script for gtest targets on Android
in the top-level directory that matches the suite's output_name (usually
its target name), allowing us to successfully build raw "unit_tests" on
Android. As a bonus, we can now run

  $ out/Release/unit_tests

(etc) on Android.

BUG=716117

Review-Url: https://codereview.chromium.org/2851523002
Cr-Commit-Position: refs/heads/master@{#469485}

[modify] https://crrev.com/686094f6b082e2595bc5d429cdcdaa3b76217501/build/config/android/internal_rules.gni
[modify] https://crrev.com/686094f6b082e2595bc5d429cdcdaa3b76217501/testing/test.gni

Project Member

Comment 2 by bugdroid1@chromium.org, May 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/3bed2fc03bc435464880411740b20031f80ed41c

commit 3bed2fc03bc435464880411740b20031f80ed41c
Author: John Budorick <jbudorick@chromium.org>
Date: Tue May 09 14:23:18 2017

Remove old GYP compatibility targets from chromium_tests. (RELAND)

Bug: 716117
Change-Id: I1dc4d65fdeaa184f0438927c23d766dd9de0f636
Reviewed-on: https://chromium-review.googlesource.com/497271
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>

[modify] https://crrev.com/3bed2fc03bc435464880411740b20031f80ed41c/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_android_android_blink_rel.json
[modify] https://crrev.com/3bed2fc03bc435464880411740b20031f80ed41c/scripts/slave/recipes/chromium.expected/full_chromium_android_fyi_x86_Cloud_Tester.json
[modify] https://crrev.com/3bed2fc03bc435464880411740b20031f80ed41c/scripts/slave/recipes/chromium.expected/full_chromium_swarm_Android_N5_Swarm.json
[modify] https://crrev.com/3bed2fc03bc435464880411740b20031f80ed41c/scripts/slave/recipes/chromium.expected/full_chromium_android_fyi_Nougat_Phone_Tester.json
[modify] https://crrev.com/3bed2fc03bc435464880411740b20031f80ed41c/scripts/slave/recipes/chromium.expected/full_chromium_android_fyi_Memory_Infra_Tester.json
[modify] https://crrev.com/3bed2fc03bc435464880411740b20031f80ed41c/scripts/slave/recipes/chromium.expected/full_chromium_android_Android_arm64_Builder__dbg_.json
[modify] https://crrev.com/3bed2fc03bc435464880411740b20031f80ed41c/scripts/slave/recipes/chromium.expected/full_chromium_android_Lollipop_Phone_Tester.json
[modify] https://crrev.com/3bed2fc03bc435464880411740b20031f80ed41c/scripts/slave/recipes/chromium.expected/full_chromium_android_fyi_x64_Device_Tester.json
[modify] https://crrev.com/3bed2fc03bc435464880411740b20031f80ed41c/scripts/slave/recipes/chromium.expected/full_chromium_android_Android_N5X_Swarm_Builder.json
[modify] https://crrev.com/3bed2fc03bc435464880411740b20031f80ed41c/scripts/slave/recipes/chromium.expected/full_chromium_android_Marshmallow_64_bit_Tester.json
[modify] https://crrev.com/3bed2fc03bc435464880411740b20031f80ed41c/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Site_Isolation_Android.json
[modify] https://crrev.com/3bed2fc03bc435464880411740b20031f80ed41c/scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus5X_Perf.json
[modify] https://crrev.com/3bed2fc03bc435464880411740b20031f80ed41c/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_gtest_test.expected/android.json
[modify] https://crrev.com/3bed2fc03bc435464880411740b20031f80ed41c/scripts/slave/recipes/chromium.expected/full_chromium_android_Android_arm_Builder__dbg_.json
[modify] https://crrev.com/3bed2fc03bc435464880411740b20031f80ed41c/scripts/slave/recipes/chromium.expected/full_client_v8_fyi_Android_Release__Nexus_5X_.json
[modify] https://crrev.com/3bed2fc03bc435464880411740b20031f80ed41c/scripts/slave/recipes/chromium.expected/full_chromium_linux_Android_Builder.json
[modify] https://crrev.com/3bed2fc03bc435464880411740b20031f80ed41c/scripts/slave/recipe_modules/chromium_tests/steps.py
[modify] https://crrev.com/3bed2fc03bc435464880411740b20031f80ed41c/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Android_VR_Tests.json
[modify] https://crrev.com/3bed2fc03bc435464880411740b20031f80ed41c/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Android_Builder__dbg_.json
[modify] https://crrev.com/3bed2fc03bc435464880411740b20031f80ed41c/scripts/slave/recipes/chromium.expected/full_chromium_linux_Android_Tests.json
[modify] https://crrev.com/3bed2fc03bc435464880411740b20031f80ed41c/scripts/slave/recipes/chromium.expected/full_chromium_linux_Android_Tests__dbg_.json
[modify] https://crrev.com/3bed2fc03bc435464880411740b20031f80ed41c/scripts/slave/recipes/chromium.expected/full_chromium_perf_fyi_Android_Swarming_N5X_Tester.json
[modify] https://crrev.com/3bed2fc03bc435464880411740b20031f80ed41c/scripts/slave/recipes/chromium.expected/full_chromium_webkit_Android_Builder.json
[modify] https://crrev.com/3bed2fc03bc435464880411740b20031f80ed41c/scripts/slave/recipe_modules/chromium_tests/tests/steps/local_gtest_test.expected/android.json
[modify] https://crrev.com/3bed2fc03bc435464880411740b20031f80ed41c/scripts/slave/recipes/chromium.expected/full_chromium_linux_Android_Builder__dbg_.json
[modify] https://crrev.com/3bed2fc03bc435464880411740b20031f80ed41c/scripts/slave/recipes/chromium.expected/full_chromium_android_fyi_Lollipop_Low_end_Tester.json
[modify] https://crrev.com/3bed2fc03bc435464880411740b20031f80ed41c/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Android_Release__Nexus_5X_.json
[modify] https://crrev.com/3bed2fc03bc435464880411740b20031f80ed41c/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Android_Builder_ARM64__dbg_.json
[modify] https://crrev.com/3bed2fc03bc435464880411740b20031f80ed41c/scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTAndroid_x64.json
[modify] https://crrev.com/3bed2fc03bc435464880411740b20031f80ed41c/scripts/slave/recipes/chromium.expected/full_chromium_swarm_Android_N5X_Swarm.json
[modify] https://crrev.com/3bed2fc03bc435464880411740b20031f80ed41c/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Android_Builder__dbg_.json

Project Member

Comment 3 by bugdroid1@chromium.org, May 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/3bed2fc03bc435464880411740b20031f80ed41c

commit 3bed2fc03bc435464880411740b20031f80ed41c
Author: John Budorick <jbudorick@chromium.org>
Date: Tue May 09 14:23:18 2017

Remove old GYP compatibility targets from chromium_tests. (RELAND)

Bug: 716117
Change-Id: I1dc4d65fdeaa184f0438927c23d766dd9de0f636
Reviewed-on: https://chromium-review.googlesource.com/497271
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>

[modify] https://crrev.com/3bed2fc03bc435464880411740b20031f80ed41c/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_android_android_blink_rel.json
[modify] https://crrev.com/3bed2fc03bc435464880411740b20031f80ed41c/scripts/slave/recipes/chromium.expected/full_chromium_android_fyi_x86_Cloud_Tester.json
[modify] https://crrev.com/3bed2fc03bc435464880411740b20031f80ed41c/scripts/slave/recipes/chromium.expected/full_chromium_swarm_Android_N5_Swarm.json
[modify] https://crrev.com/3bed2fc03bc435464880411740b20031f80ed41c/scripts/slave/recipes/chromium.expected/full_chromium_android_fyi_Nougat_Phone_Tester.json
[modify] https://crrev.com/3bed2fc03bc435464880411740b20031f80ed41c/scripts/slave/recipes/chromium.expected/full_chromium_android_fyi_Memory_Infra_Tester.json
[modify] https://crrev.com/3bed2fc03bc435464880411740b20031f80ed41c/scripts/slave/recipes/chromium.expected/full_chromium_android_Android_arm64_Builder__dbg_.json
[modify] https://crrev.com/3bed2fc03bc435464880411740b20031f80ed41c/scripts/slave/recipes/chromium.expected/full_chromium_android_Lollipop_Phone_Tester.json
[modify] https://crrev.com/3bed2fc03bc435464880411740b20031f80ed41c/scripts/slave/recipes/chromium.expected/full_chromium_android_fyi_x64_Device_Tester.json
[modify] https://crrev.com/3bed2fc03bc435464880411740b20031f80ed41c/scripts/slave/recipes/chromium.expected/full_chromium_android_Android_N5X_Swarm_Builder.json
[modify] https://crrev.com/3bed2fc03bc435464880411740b20031f80ed41c/scripts/slave/recipes/chromium.expected/full_chromium_android_Marshmallow_64_bit_Tester.json
[modify] https://crrev.com/3bed2fc03bc435464880411740b20031f80ed41c/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Site_Isolation_Android.json
[modify] https://crrev.com/3bed2fc03bc435464880411740b20031f80ed41c/scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus5X_Perf.json
[modify] https://crrev.com/3bed2fc03bc435464880411740b20031f80ed41c/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_gtest_test.expected/android.json
[modify] https://crrev.com/3bed2fc03bc435464880411740b20031f80ed41c/scripts/slave/recipes/chromium.expected/full_chromium_android_Android_arm_Builder__dbg_.json
[modify] https://crrev.com/3bed2fc03bc435464880411740b20031f80ed41c/scripts/slave/recipes/chromium.expected/full_client_v8_fyi_Android_Release__Nexus_5X_.json
[modify] https://crrev.com/3bed2fc03bc435464880411740b20031f80ed41c/scripts/slave/recipes/chromium.expected/full_chromium_linux_Android_Builder.json
[modify] https://crrev.com/3bed2fc03bc435464880411740b20031f80ed41c/scripts/slave/recipe_modules/chromium_tests/steps.py
[modify] https://crrev.com/3bed2fc03bc435464880411740b20031f80ed41c/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Android_VR_Tests.json
[modify] https://crrev.com/3bed2fc03bc435464880411740b20031f80ed41c/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Android_Builder__dbg_.json
[modify] https://crrev.com/3bed2fc03bc435464880411740b20031f80ed41c/scripts/slave/recipes/chromium.expected/full_chromium_linux_Android_Tests.json
[modify] https://crrev.com/3bed2fc03bc435464880411740b20031f80ed41c/scripts/slave/recipes/chromium.expected/full_chromium_linux_Android_Tests__dbg_.json
[modify] https://crrev.com/3bed2fc03bc435464880411740b20031f80ed41c/scripts/slave/recipes/chromium.expected/full_chromium_perf_fyi_Android_Swarming_N5X_Tester.json
[modify] https://crrev.com/3bed2fc03bc435464880411740b20031f80ed41c/scripts/slave/recipes/chromium.expected/full_chromium_webkit_Android_Builder.json
[modify] https://crrev.com/3bed2fc03bc435464880411740b20031f80ed41c/scripts/slave/recipe_modules/chromium_tests/tests/steps/local_gtest_test.expected/android.json
[modify] https://crrev.com/3bed2fc03bc435464880411740b20031f80ed41c/scripts/slave/recipes/chromium.expected/full_chromium_linux_Android_Builder__dbg_.json
[modify] https://crrev.com/3bed2fc03bc435464880411740b20031f80ed41c/scripts/slave/recipes/chromium.expected/full_chromium_android_fyi_Lollipop_Low_end_Tester.json
[modify] https://crrev.com/3bed2fc03bc435464880411740b20031f80ed41c/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Android_Release__Nexus_5X_.json
[modify] https://crrev.com/3bed2fc03bc435464880411740b20031f80ed41c/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Android_Builder_ARM64__dbg_.json
[modify] https://crrev.com/3bed2fc03bc435464880411740b20031f80ed41c/scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTAndroid_x64.json
[modify] https://crrev.com/3bed2fc03bc435464880411740b20031f80ed41c/scripts/slave/recipes/chromium.expected/full_chromium_swarm_Android_N5X_Swarm.json
[modify] https://crrev.com/3bed2fc03bc435464880411740b20031f80ed41c/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Android_Builder__dbg_.json

Project Member

Comment 6 by bugdroid1@chromium.org, May 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b094d1332d6ccf51ce097765dd2a38b2e5116f1

commit 5b094d1332d6ccf51ce097765dd2a38b2e5116f1
Author: ynovikov <ynovikov@chromium.org>
Date: Wed May 17 21:00:17 2017

Really remove override_isolate_target from chromium.gpu.fyi.json

BUG=716117
TBR=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2886033002
Cr-Commit-Position: refs/heads/master@{#472564}

[modify] https://crrev.com/5b094d1332d6ccf51ce097765dd2a38b2e5116f1/content/test/gpu/generate_buildbot_json.py

Components: Infra>Client>Chrome
Moving Infra>Client>Android -> Infra>Client>Chrome+OS=Android
Components: -Infra>Client>Android

Sign in to add a comment