Change to Dialog spec |
|||||||||||||||||||
Issue descriptionI made the mistake in crbug.com/707631 of changing the global dialog padding from 20px to 16px as a means to make webUI dialogs consistent with secondary UI. In reality, the spacing is too constrained for content-area modal dialogs so I'd like to update 2 parts of the spec: 1. Global padding should be 20px not 16px. This only pertains to the content area (title and body text), NOT the buttons. Buttons should still remain 16 from right and bottom edge of dialog. 2. The global ripple size is now 36px. With that change, let's remove the 4px top + right padding so that the 36x36 sits flush with the edge of the dialog. Aligning with the title is not necessary here. New spec: https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/specs#%2FSPEC-settings_dialogs.png%3Fz=width
,
May 1 2017
,
May 2 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 12 2018
,
May 12 2018
,
May 12 2018
,
May 16 2018
,
May 17 2018
,
May 17 2018
Screenshots for CL https://chromium-review.googlesource.com/c/chromium/src/+/1064598
,
May 17 2018
I talked with namratakannan@. The proposed padding works, and getting this into M68 is okay.
,
May 17 2018
Here are screenshots concerning the close button. The button height is larger than the title height which creates a larger space between the title and body than desired.
,
May 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/607e9a387d3b444550e8b107a15b40c62121f424 commit 607e9a387d3b444550e8b107a15b40c62121f424 Author: Esmael El-Moslimany <aee@chromium.org> Date: Thu May 17 23:55:02 2018 WebUI: update cr-dialog padding while keep print preview the same Bug: 716112 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I952279f79135d711ec4e46724217a8d66d6a6493 Reviewed-on: https://chromium-review.googlesource.com/1064598 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#559738} [modify] https://crrev.com/607e9a387d3b444550e8b107a15b40c62121f424/chrome/browser/resources/print_preview/new/destination_dialog.html [modify] https://crrev.com/607e9a387d3b444550e8b107a15b40c62121f424/chrome/browser/resources/print_preview/new/search_dialog_css.html [modify] https://crrev.com/607e9a387d3b444550e8b107a15b40c62121f424/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html
,
May 17 2018
,
May 22 2018
|
|||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||
Comment 1 by bettes@chromium.org
, Apr 27 2017